From: Heiko Stuebner <heiko@sntech.de>
To: Jakob Unterwurzacher <jakobunt@gmail.com>,
Quentin Schulz <quentin.schulz@cherry.de>
Cc: linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Jakob Unterwurzacher <jakob.unterwurzacher@cherry.de>
Subject: Re: [PATCH v2] arm64: dts: rockchip: add attiny_rst_gate to Ringneck
Date: Fri, 27 Sep 2024 11:39:49 +0200 [thread overview]
Message-ID: <3885598.FjKLVJYuhi@phil> (raw)
In-Reply-To: <050724b3-aed6-41d3-b2b4-18b90fbf0ad3@cherry.de>
Am Donnerstag, 26. September 2024, 15:24:03 CEST schrieb Quentin Schulz:
> Hi Jakob,
>
> On 9/26/24 3:20 PM, Jakob Unterwurzacher wrote:
> > Ringneck v1.4 can contain (placement option) an on-board ATtiny
> > microcontroller instead of an STM32. In normal operation, this
> > is transparent to the software, as both microcontrollers emulate
> > the same ICs (amc6821 and isl1208).
> >
> > For flashing the ATtiny, the SWITCH_REG1 regulator of the board's PMIC is
> > used to enable the ATtiny UPDI debug interface. If the STM32 is placed, or if
> > we are running on an older Ringneck revision, SWITCH_REG1 is not connected
> > and has no effect.
> >
> > Add attiny-updi-gate-regulator so userspace can control it via sysfs
> > (needs CONFIG_REGULATOR_USERSPACE_CONSUMER):
> >
> > echo enabled > /sys/devices/platform/attiny-updi-gate-regulator/state
> >
> > Signed-off-by: Jakob Unterwurzacher <jakob.unterwurzacher@cherry.de>
> > Tested-by: Quentin Schulz <quentin.schulz@cherry.de>
>
> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
>
> This is a candidate for backporting to stable branches as well I assume,
> @Heiko?
That is more on the darker side of gray here.
Looking at the stable-kernel-rules [0] the criteria is
"It must either fix a real bug that bothers people or just add a device ID"
This change instead is adding a new feature to allow said flashing from a
running system.
sidenote: please don't post new versions as replies to previous versions,
as that confuses tooling a lot.
Heiko
[0] https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-09-27 9:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 12:44 [PATCH] arm64: dts: rockchip: add attiny_rst_gate to Ringneck Jakob Unterwurzacher
2024-09-26 11:24 ` Quentin Schulz
2024-09-26 13:20 ` [PATCH v2] " Jakob Unterwurzacher
2024-09-26 13:24 ` Quentin Schulz
2024-09-27 9:39 ` Heiko Stuebner [this message]
2024-09-27 9:50 ` Quentin Schulz
2024-09-27 14:48 ` Heiko Stuebner
2024-09-30 10:55 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3885598.FjKLVJYuhi@phil \
--to=heiko@sntech.de \
--cc=jakob.unterwurzacher@cherry.de \
--cc=jakobunt@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=quentin.schulz@cherry.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).