From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH] usb: dwc2: host: Properly set the HFIR Date: Sat, 23 Jan 2016 18:53:37 +0100 Message-ID: <39287239.yyU0LGezZt@phil> References: <1453506971-31445-1-git-send-email-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1453506971-31445-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Douglas Anderson Cc: huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, gregory.herrero-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, johnyoun-HKixBCOQz3hWk0Htik3J/w@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, ming.lei-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org, balbi-l0cyMroinI0@public.gmane.org, John Youn , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, yousaf.kaukab-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org, william.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org, Julius Werner , dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rockchip.vger.kernel.org Am Freitag, 22. Januar 2016, 15:56:10 schrieb Douglas Anderson: > According to the most up to date version of the dwc2 databook, the FRINT > field of the HFIR register should be programmed to: > * 125 us * (PHY clock freq for HS) - 1 > * 1000 us * (PHY clock freq for FS/LS) - 1 > > This is opposed to older versions of the doc that claimed it should be: > * 125 us * (PHY clock freq for HS) > * 1000 us * (PHY clock freq for FS/LS) > > In case you didn't spot it, the difference is the "- 1". > > Let's add the "- 1" to match the newest user manual. It's presumed that > the "- 1" should have always been there and that this was always a > documentation error. If some hardware needs the "- 1" and other > hardware doesn't, we'll have to add a configuration parameter for it in > the future. Same setup and description as in Doug's 21-patch series, so on a veyron-jerry: Tested-by: Heiko Stuebner Heiko