public inbox for linux-rockchip@lists.infradead.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Olivia Mackall <olivia@selenic.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Daniel Golle <daniel@makrotopia.org>,
	Aurelien Jarno <aurelien@aurel32.net>
Cc: Sebastian Reichel <sebastian.reichel@collabora.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-crypto@vger.kernel.org
Subject: Re: [PATCH 6/7] arm64: dts: rockchip: Add rng node to RK3588
Date: Fri, 31 Jan 2025 11:16:59 +0100	[thread overview]
Message-ID: <3a0f3d55-3828-43c9-b2d2-291f767c50e0@kernel.org> (raw)
In-Reply-To: <20250130-rk3588-trng-submission-v1-6-97ff76568e49@collabora.com>

On 30/01/2025 17:31, Nicolas Frattaroli wrote:
> Add the RK3588's standalone hardware random number generator node to its
> device tree, and enable it on the one board I've tested it on and can
> verify it produces good output, the Rock 5B.
> 
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3588-base.dtsi   | 9 +++++++++
>  arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 4 ++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> index 8cfa30837ce72581d0b513a8274ab0177eb5ae15..1c72922bcbe1afd7c49beac771f8b7c6e5cc6e05 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> @@ -1921,6 +1921,15 @@ sdhci: mmc@fe2e0000 {
>  		status = "disabled";
>  	};
>  
> +	rng: rng@fe378000 {
> +		compatible = "rockchip,rk3588-rng";
> +		reg = <0x0 0xfe378000 0x0 0x200>;
> +		interrupts = <GIC_SPI 400 IRQ_TYPE_LEVEL_HIGH 0>;
> +		clocks = <&scmi_clk SCMI_HCLK_SECURE_NS>;
> +		resets = <&scmi_reset SCMI_SRST_H_TRNG_NS>;
> +		status = "disabled";

Why? What resources are missing?

> +	};
> +
>  	i2s0_8ch: i2s@fe470000 {
>  		compatible = "rockchip,rk3588-i2s-tdm";
>  		reg = <0x0 0xfe470000 0x0 0x1000>;
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> index d597112f1d5b8ee0b6a4fa17086c8671a5102583..00a915cf266202e26b274cab962f7bf6bcf76fc1 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -430,6 +430,10 @@ &pwm1 {
>  	status = "okay";
>  };
>  
> +&rng {
> +	status = "okay";

I don't see how RNG is board related.


Best regards,
Krzysztof

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2025-01-31 10:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-30 16:31 [PATCH 0/7] RK3588 Hardware Random Number Generator Driver Nicolas Frattaroli
2025-01-30 16:31 ` [PATCH 1/7] dt-bindings: reset: Add SCMI reset IDs for RK3588 Nicolas Frattaroli
2025-01-30 18:46   ` Conor Dooley
2025-01-30 16:31 ` [PATCH 2/7] dt-bindings: rng: add binding for Rockchip RK3588 RNG Nicolas Frattaroli
2025-01-30 18:42   ` Conor Dooley
2025-01-31  8:30   ` Krzysztof Kozlowski
2025-01-31  9:43     ` Nicolas Frattaroli
2025-01-30 16:31 ` [PATCH 3/7] hwrng: rockchip: store dev pointer in driver struct Nicolas Frattaroli
2025-01-30 16:31 ` [PATCH 4/7] hwrng: rockchip: eliminate some unnecessary dereferences Nicolas Frattaroli
2025-01-30 16:31 ` [PATCH 5/7] hwrng: rockchip: add support for rk3588's standalone TRNG Nicolas Frattaroli
2025-01-31  8:34   ` Krzysztof Kozlowski
2025-01-30 16:31 ` [PATCH 6/7] arm64: dts: rockchip: Add rng node to RK3588 Nicolas Frattaroli
2025-01-31 10:16   ` Krzysztof Kozlowski [this message]
2025-01-30 16:31 ` [PATCH 7/7] mailmap: add entry for Nicolas Frattaroli Nicolas Frattaroli
2025-01-31  8:36   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a0f3d55-3828-43c9-b2d2-291f767c50e0@kernel.org \
    --to=krzk@kernel.org \
    --cc=aurelien@aurel32.net \
    --cc=conor+dt@kernel.org \
    --cc=daniel@makrotopia.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=nicolas.frattaroli@collabora.com \
    --cc=olivia@selenic.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox