From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiner Kallweit Subject: Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection Date: Mon, 8 Apr 2019 20:45:45 +0200 Message-ID: <3bc293a8-5966-fb40-e0b1-636f3a3dfe77@gmail.com> References: <0cc96fab-e102-c0d1-ade0-90e3e06dc9f1@gmail.com> <20190407221312.GA14347@lunn.ch> <20190408181249.GH15267@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190408181249.GH15267@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org To: Andrew Lunn Cc: Florian Fainelli , David Miller , Ray Jui , Scott Branden , Richard Cochran , Kevin Hilman , Heiko Stuebner , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org On 08.04.2019 20:12, Andrew Lunn wrote: >> Splitting the series and waiting for a Tested-by, as proposed by Richard, >> may be problematic because most PHY drivers don't have a dedicated >> maintainer, and we lack the hardware to test. > > Well, we could split out those we know are likely to get tested. I > have a number of boards with Marvell devices i can test. Florian has > Broadcom boards. I also have a couple of boards with Micrel KSZ8041, > which would be interesting because they are Fast Ethernet. Bootlin can > test some of the mscc PHYs. > Great. Could you also test based on the series and the provide a Tested-by for the PHY's which have been tested? Even if I split out let's say the Marvell PHY driver, most likely just few of all the supported Marvell PHY's can be tested. > We also might want to get some targeted testing. The microchip_t1.c > could be interesting, since it is a T1 device. There was another T1 > added in the last year, but i forget which. > The T1 PHY driver isn't included in this series. It uses another feature constant: PHY_BASIC_T1_FEATURES > Just doing this testing might give us an idea if we really should > expect problems. > Sure. I tested and applied this change to the Realtek PHY driver already. > Andrew > Heiner