linux-rockchip.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: rockchip: fix broken build
@ 2015-07-06  3:37 Caesar Wang
  2015-07-06 13:16 ` Heiko Stübner
  0 siblings, 1 reply; 2+ messages in thread
From: Caesar Wang @ 2015-07-06  3:37 UTC (permalink / raw)
  To: heiko-4mtYJXux2i+zQB+pC5nmwQ
  Cc: dianders-F7+t8E8rja9g9hUCZPvPmw,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	kever.yang-TNX95d0MmH7DzftRWevZcw,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	fengguang.wu-ral2JQCrhuEAvxtiuMwx3w,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XcXa4x6EXUF0, Caesar Wang

The following was seen in branch[0] build.

arch/arm/mach-rockchip/platsmp.c:154:23: error:
    'rockchip_secondary_startup' undeclared (first use in this function)

branch[0]:
git://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git
v4.3-armsoc/soc

The broken build is caused by the commit
(fe4407c0dc58215a7abfb7532740d79ddabe7a7a)

Signed-off-by: Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

---

 arch/arm/mach-rockchip/platsmp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/mach-rockchip/platsmp.c b/arch/arm/mach-rockchip/platsmp.c
index 7ebd1c1..3e7a4b7 100644
--- a/arch/arm/mach-rockchip/platsmp.c
+++ b/arch/arm/mach-rockchip/platsmp.c
@@ -152,8 +152,7 @@ static int rockchip_boot_secondary(unsigned int cpu, struct task_struct *idle)
 		 */
 		mdelay(1); /* ensure the cpus other than cpu0 to startup */
 
-		writel(virt_to_phys(rockchip_secondary_startup),
-		       sram_base_addr + 8);
+		writel(virt_to_phys(secondary_startup), sram_base_addr + 8);
 		writel(0xDEADBEAF, sram_base_addr + 4);
 		dsb_sev();
 	}
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: rockchip: fix broken build
  2015-07-06  3:37 [PATCH] ARM: rockchip: fix broken build Caesar Wang
@ 2015-07-06 13:16 ` Heiko Stübner
  0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stübner @ 2015-07-06 13:16 UTC (permalink / raw)
  To: Caesar Wang
  Cc: fengguang.wu, linux-rockchip, linux-arm-kernel, dianders,
	kever.yang, linux-kernel

Am Montag, 6. Juli 2015, 11:37:23 schrieb Caesar Wang:
> The following was seen in branch[0] build.
> 
> arch/arm/mach-rockchip/platsmp.c:154:23: error:
>     'rockchip_secondary_startup' undeclared (first use in this function)
> 
> branch[0]:
> git://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git
> v4.3-armsoc/soc
> 
> The broken build is caused by the commit
> (fe4407c0dc58215a7abfb7532740d79ddabe7a7a)
> 
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>

applied to the soc branch.

Hopefully that will teach me to not publish stuff before going to bed ;-)


Thanks
Heiko

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-07-06 13:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-06  3:37 [PATCH] ARM: rockchip: fix broken build Caesar Wang
2015-07-06 13:16 ` Heiko Stübner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).