Re: [PATCH 1/7] iio: adc: rockchip_saradc: Add support for RK3588

Jonathan Cameron
2023-05-20T15:41:14Z

On Wed, 17 May 2023 04:30:45 +0530
Shreeya Patel <shreeya.patel@collabora.com> wrote:

> Refactor conversion operation to support rk3588 saradc and
> add separate start, read, powerdown in respective hooks.
>
> Signed-off-by: Simon Xue <xxm@rock-chips.com>
> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
Hi Shreeya,

This particular chain of tags has unclear authorship.
If Simon wrote the driver, then the author (from address) of the
patch should be Simon's. If it is a codeveloped situation look
at how to use the co-developed-by tag

Generally the nicest way to add new callbacks is to do them in their
own patch. Then introduce new devices with different callbacks in a follow
on patch. That means the first one can be reviewed to ensure there
is no functional change separate from the new code in the following patch.

> +static const struct rockchip_saradc_data rk3588_saradc_data = {
> + .channels = rockchip_rk3588_saradc_iio_channels,
> + .num_channels = ARRAY_SIZE(rockchip_rk3588_saradc_iio_channels),
> + .clk_rate = 1000000,
> + .start = rockchip_saradc_start_v2,

As mentioned above, I'd like to see the changes for old devices done in patch
1 and the support for new device in a new patch.

> + .read = rockchip_saradc_read_v2,
> };