From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F1D1C5AE59 for ; Thu, 5 Jun 2025 15:16:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nc1JfR4mH0CJFNB2uGHsnv8Ii1M4BACar23Q/zuVpCg=; b=qec29+TFDm/qo0 ld2gLjtSbVhTw7Kj4rb1Je2ynktDl8JAs/bBu3rRp9YM9OllzM/1t+ptnaZ5viyy+WwL650ACAv9/ 3tRT8L2qXWi6E77S8SFpC9Ah4F/Vi2d1RGnGylMxtRcRrlQWbZdwdRCgRbIys2GhY56imjyHFUp3a I4E40XIh2chlhGbnkHOeU2PeGEvRMxyaTKzWdgw4X3IMNwl0JaRX95eURZ3UF09Rg/ElUTU7YyCi8 ahNcFf/JFkpRb7G+LCXKOi/yjYCRHBrEPklY3wvKuvnFiJVrvL9f8MJdsh5P+hbvk6J0mMNqgXK8I E4LpFDXvyVdSbwHIa6Vw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uNCKm-0000000FsNA-1JjN; Thu, 05 Jun 2025 15:16:48 +0000 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uNCJK-0000000Fs6A-1EMe; Thu, 05 Jun 2025 15:15:19 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1749136492; cv=none; d=zohomail.com; s=zohoarc; b=ENI8hMjvEmJfVrQRZSFpDbyKHVOtvfZuTm5qF/vEk1X9P4OigUMMG7qLVI2qosebz8ddrxGGYzEZZiDtjkR/dCK0ZzXU3/xZFoNQI6xUCziEB0er4zPVxDzJaiJQt0t0dnHoGf0FOh/E7kyj9Lb841Ko3RteQbTAgBr7G0EjjoA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749136492; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=/GuYrfRIt3NP/tsfwxH5PFscLlX5erdLhDtZ3+v8kg0=; b=CiS2fKxauqWUQMP1ejrx8adcDEkkl3oZ9DnqHwWhoP2htA9pVuSul4sJER3KjYov9/oJHH+vXa3rrpAceqawTxO200NM8svS0Pbuz5sYizX1xmOcNiZIW3eUU/NUpsLul3u+Q05GGFSkV1fBADbU+vzKAf4pLubew6rSiEdAO4Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1749136492; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=/GuYrfRIt3NP/tsfwxH5PFscLlX5erdLhDtZ3+v8kg0=; b=e51u7eqbnLxwYY5yZzmLXXP5HnH4XLEy+59bYwU7yq79RAHad1ASKDdWUvA4NKtU WuBzAfplXeyVY87JQsYejDcYPp1lcBqOWM5b+r0qfTjEoxE3JGEyEtz3kpv7NbmYyMh S0FMhUYFU5gwxET6NfPaMpw+TuQSLF2t0mAg7jGE= Received: by mx.zohomail.com with SMTPS id 1749136491036595.9387295759052; Thu, 5 Jun 2025 08:14:51 -0700 (PDT) From: Nicolas Frattaroli To: Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Heiko Stuebner , Sascha Hauer , Jonathan Cameron , Sebastian Reichel , Diederik de Haas Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, kernel@collabora.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] PM / devfreq: rockchip-dfi: add support for LPDDR5 Date: Thu, 05 Jun 2025 17:14:46 +0200 Message-ID: <4244538.aeNJFYEL58@workhorse> In-Reply-To: References: <20250530-rk3588-dfi-improvements-v1-0-6e077c243a95@collabora.com> <20250530-rk3588-dfi-improvements-v1-2-6e077c243a95@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250605_081518_405421_C41ACAA2 X-CRM114-Status: GOOD ( 25.22 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hello Diederik, On Wednesday, 4 June 2025 10:24:33 Central European Summer Time Diederik de Haas wrote: > Hi Nicolas, > > On Fri May 30, 2025 at 3:38 PM CEST, Nicolas Frattaroli wrote: > > [...] > > + case ROCKCHIP_DDRTYPE_LPDDR5: > > + ddrmon_ver = readl_relaxed(dfi->regs); > > + if (ddrmon_ver < 0x40) { > > + *ctrl = DDRMON_CTRL_LPDDR5 | dfi->lp5_bank_mode; > > + *mask |= DDRMON_CTRL_LP5_BANK_MODE_MASK; > > + break; > > + } > > + > > + /* > > + * As it is unknown whether the unpleasant special case > > + * behaviour used by the vendor kernel is needed for any > > + * shipping hardware, ask users to report if they have > > + * some of that hardware. > > + */ > > + dev_err(&dfi->edev->dev, > > + "unsupported DDRMON version 0x%04X, please let linux-rockchip know!\n", > > + ddrmon_ver); > > + return -EOPNOTSUPP; > > I'm guessing you mean the linux-rockchip mailing list here? If so, I > think it's better to make that explicit as 'Joe User' who may run into > this issue may not be aware of that mailing list. The 'linux' and > 'rockchip' name combo is used in quite a few places. I agree it's ambiguous, the message as it is right now is the way it is because we're not allowed to linebreak user-facing messages for grep- ability and I also don't want to exceed 100 lines of width (though this is the one case where we're allowed to). I suppose I should just replace it with the e-mail address of the list. That should be clear enough and this error message also won't end up in random boot logs strewn across the internet if it really is just some engineering sample hardware or similar that's affected. Kind regards, Nicolas Frattaroli > > Cheers, > Diederik > > > + default: > > + dev_err(&dfi->edev->dev, "unsupported memory type 0x%X\n", > > + dfi->ddr_type); > > + return -EOPNOTSUPP; > > + } > > + > > + return 0; > > +} > > + > > static int rockchip_dfi_enable(struct rockchip_dfi *dfi) > > { > > void __iomem *dfi_regs = dfi->regs; > > int i, ret = 0; > > + u32 ctrl; > > + u32 ctrl_mask; > > > > mutex_lock(&dfi->mutex); > > > > @@ -136,8 +186,11 @@ static int rockchip_dfi_enable(struct rockchip_dfi *dfi) > > > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip