From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1635C282D1 for ; Thu, 6 Mar 2025 21:11:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IiyGbaJM7mW/FPm9Y9CSi6w1vKAouA46irq9xeKiwFw=; b=QWCohpoE1p2U0Qz350Vax0eowQ BhDpj/EHdj498wEexoeiHfymPdimlK/JU78sFTwFVuJ9bl491gw5T73f7xZmKNyuC1rNaLHwh4SkH TOnMfT7Y9WuvltMYjZldH46lPiBzUpex8bbXT6r5J/KtiY5o0eebKrak3lyzVhO9A+SOUJ4FH8yQP q+HPBJo1n6Zw2+EqlQH7UkDUxVygzRcoIxRqwlHJNyIgww7Nat8Qax6b8usyHIzOWoO1DA1G3UDlD 2CVuK5/hnCDeJnMrdHcuBmg7PW+uWyJT3/oLZthB3g2G/xrzRtHrawxYmn/Eh9mGbWvd+1wo00uH1 sCkW4YNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tqIUZ-0000000CE2y-0nLm; Thu, 06 Mar 2025 21:10:55 +0000 Received: from mail.manjaro.org ([2a01:4f8:c0c:51f3::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tqISu-0000000CDkQ-1zvH; Thu, 06 Mar 2025 21:09:13 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1741295347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L2c81lklMsWoewbTrDLPjzFIwtetRMhEGhB4+GnHcqo=; b=WiSqWs276XwmL6ya8O18OlaDotyFuFbRKOpfqddTDFGjegQF7yrFJ/fjZqymvfCuHegLIW HidnrhNz9DXyySlOqdgziypXpdovMd53ofUUCHADRAqZkUQUPdGWCoT5QwgqyhForVQcaS SLy+g0SDLLq6eKdiqA6beA27hQuYi3YHLH8XpvNpLeVyKuDz15NKBPDyQJ8NRaObqvesP5 H9nB8siyzS1lzqkqpfAsqgBKH871WqOw+loSNYZ1Nd6isC6x9WdSxTufdr7kj4JfcLX5Sy 0zdnbY4+vqADaC/N/SxFzkqHCoQHzOeX6cJc7+IpxSPj0pC/0zQrSGWPz25dUg== Date: Thu, 06 Mar 2025 22:09:06 +0100 From: Dragan Simic To: Jonas Karlman Cc: Heiko Stuebner , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Wadim Egorov , netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH 1/3] net: stmmac: dwmac-rk: Use DELAY_ENABLE macro for RK3328 In-Reply-To: <20250306203858.1677595-2-jonas@kwiboo.se> References: <20250306203858.1677595-1-jonas@kwiboo.se> <20250306203858.1677595-2-jonas@kwiboo.se> Message-ID: <427cbfc8c6b71bf70804a0d535ff9d18@manjaro.org> X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250306_130912_678590_93662FF0 X-CRM114-Status: GOOD ( 13.47 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hello Jonas, On 2025-03-06 21:38, Jonas Karlman wrote: > Support for Rockchip RK3328 GMAC and addition of the DELAY_ENABLE macro > was merged in the same merge window. This resulted in RK3328 not being > converted to use the new DELAY_ENABLE macro. > > Change to use the DELAY_ENABLE macro to help disable MAC delay when > RGMII_ID/RXID/TXID is used. > > Fixes: eaf70ad14cbb ("net: stmmac: dwmac-rk: Add handling for > RGMII_ID/RXID/TXID") > Signed-off-by: Jonas Karlman > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c > b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c > index 003fa5cf42c3..297fa93e4a39 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c > @@ -593,8 +593,7 @@ static void rk3328_set_to_rgmii(struct > rk_priv_data *bsp_priv, > regmap_write(bsp_priv->grf, RK3328_GRF_MAC_CON1, > RK3328_GMAC_PHY_INTF_SEL_RGMII | > RK3328_GMAC_RMII_MODE_CLR | > - RK3328_GMAC_RXCLK_DLY_ENABLE | > - RK3328_GMAC_TXCLK_DLY_ENABLE); > + DELAY_ENABLE(RK3328, tx_delay, rx_delay)); > > regmap_write(bsp_priv->grf, RK3328_GRF_MAC_CON0, > RK3328_GMAC_CLK_RX_DL_CFG(rx_delay) | Thanks for this patch... It's looking good to me, and good job spotting this issue! Please, feel free to include: Reviewed-by: Dragan Simic _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip