From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CCBDCF34A1 for ; Wed, 19 Nov 2025 13:34:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FKGAQWFHGItO0GXZqOWzx24Ib05gxRTGCrKzdpbRaEQ=; b=FC9wPqEhn2/DdL kpvhzdqeRGjsDrAHLJrWkQUiatmxkFluFts/uHYIkvNrqOnttynpWqAzObcsaN26Zv/IrjIa65q12 mdubMirzZTIQ/JUhn4/qW3q5L4LZJwnzTmrLfhY9u5699vKbd6/H4NijxruXSgOxAXkeMlr1YD601 9S/cQU3XleDR4VSH0Smb4KOnorFZtN3sE5BDGBUZj88Gbb8O2i/5lg1xt8rGULbyZzrph+7IU4ZGq 4jF8/Tj3IKR/G//ytnHcm15JKnK0smf76j9d6laMc45lTMoaT3KZ01qbAt27kmSnRqOFmG1pauq/1 Cm/9ChEuIUGJRYlrcWEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vLiKK-00000003ICC-1bw8; Wed, 19 Nov 2025 13:34:28 +0000 Received: from sender3-pp-f112.zoho.com ([136.143.184.112]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vLiKH-00000003IBS-0qjr; Wed, 19 Nov 2025 13:34:26 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1763559176; cv=none; d=zohomail.com; s=zohoarc; b=Ye0zlYSjY8a276BMMfjI/83jZrSxRWD1xIyYfPOLAE8Ua6GuF3F55j4fxRxvdR6eFQ6XQbuT5ZwnoTbip+BFc6pDsK84vpGuLQO3H90VxuNX4O9Y2+iB/Nqysm4TBIVuK2ZPxneJr88SYRHFJFMxdg0JWhqvMEFV01n0P2PzB3w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763559176; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=/VWCsLA/mkk3WiZovd+xaAf7ziw484tjuSfyKDbpymE=; b=Zwz62fMimGc/fpX3l5h0s0w3tkHs6sHM8bKfocUKBIAAv1HObYvDf355d2v88LpAkINnFicTKL612+Qspy+dMcgAr5h4wLbRXzurF49Wi++Tfm4UKCG1yoRLjUXKG6NTHLeWQ7Qjbujm6/acFQR9wTl6v3tAjTWoRjKno9nD6+4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1763559176; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=/VWCsLA/mkk3WiZovd+xaAf7ziw484tjuSfyKDbpymE=; b=RiyidxtdEZDgiubH8FxAC7DZ1KqEL+Xe6vMfemsGAtERjQOhQoGAXNPX3lDioFq1 vnKFEoOzG6JL8toQ9GAtUF59aQGWNrmjJRrhQ9uyLpWZFFOYjcM7vR+DZXyLjWDa4eY 7QzTcPfHfGITtRMbBLBp0bfoYRMbZFnwQx/9Un3E= Received: by mx.zohomail.com with SMTPS id 1763559173874830.1787013290812; Wed, 19 Nov 2025 05:32:53 -0800 (PST) From: Nicolas Frattaroli To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?UTF-8?B?S8O2bmln?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , Heiko =?UTF-8?B?U3TDvGJuZXI=?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Cristian Ciocaltea Cc: kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH v4 05/10] drm/bridge: dw-hdmi-qp: Set bridge supported_formats Date: Wed, 19 Nov 2025 14:32:45 +0100 Message-ID: <4348284.aeNJFYEL58@workhorse> In-Reply-To: <3863e0e5-677b-4225-9854-3ee420828275@collabora.com> References: <20251117-color-format-v4-0-0ded72bd1b00@collabora.com> <20251117-color-format-v4-5-0ded72bd1b00@collabora.com> <3863e0e5-677b-4225-9854-3ee420828275@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251119_053425_296186_F4871904 X-CRM114-Status: GOOD ( 26.00 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Tuesday, 18 November 2025 21:00:08 Central European Standard Time Cristian Ciocaltea wrote: > Hi Nicolas, > > On 11/17/25 9:11 PM, Nicolas Frattaroli wrote: > > The drm_bridge "supported_formats" member stores a bitmask of supported > > HDMI output formats if the bridge is in fact an HDMI bridge. > > > > However, until now, the synopsys dw-hdmi-qp driver did not set this > > member in the bridge it creates. > > > > Set it based on the platform data's supported_formats member, and > > default to BIT(HDMI_COLORSPACE_RGB) if it's absent, which preserves the > > previous behaviour. > > > > Signed-off-by: Nicolas Frattaroli > > --- > > drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c > > index fe4c026280f0..cf888236bd65 100644 > > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c > > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c > > @@ -1269,6 +1269,11 @@ struct dw_hdmi_qp *dw_hdmi_qp_bind(struct platform_device *pdev, > > dev_warn(dev, "Set ref_clk_rate to vendor default\n"); > > } > > > > + if (plat_data->supported_formats) > > + hdmi->bridge.supported_formats = plat_data->supported_formats; > > This duplicates a change already introduced via commit 1ff27c5929ab > ("drm/bridge: dw-hdmi-qp: Handle platform supported formats and color depth"). Hmm, looks like I didn't notice that when rebasing onto next-20251117. (Aside note, that commit is once again lacking from next-20251119, did it get dropped for some reason or did DRM as a whole not get pulled into that next version due to a conflict?) > > > + else > > + hdmi->bridge.supported_formats = BIT(HDMI_COLORSPACE_RGB); > > And this one looks redundant as well, since RGB is supposed to be mandatory: > supported_formats defaults to RGB in drm_bridge_connector_init() if there's no > HDMI bridge in the pipeline overriding it, while drmm_connector_hdmi_init() > errors out if supported_formats is unset or doesn't advertise RGB. Oops, yeah you're right > > Hence I think this patch can be dropped. Will do! Thanks for the quick review > > Regards, > Cristian > > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip