From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH] phy: rockchip-dp: fix return value check in rockchip_dp_phy_probe() Date: Tue, 14 Jun 2016 08:39:57 +0200 Message-ID: <4354296.6MbJoqdM2Z@diego> References: <1465860707-26005-1-git-send-email-weiyj_lk@163.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1465860707-26005-1-git-send-email-weiyj_lk@163.com> Sender: linux-kernel-owner@vger.kernel.org To: weiyj_lk@163.com Cc: Kishon Vijay Abraham I , Wei Yongjun , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org Am Montag, 13. Juni 2016, 23:31:47 schrieb weiyj_lk@163.com: > From: Wei Yongjun > > In case of error, the function devm_kzalloc() returns NULL pointer > not ERR_PTR(). The IS_ERR() test in the return value check should > be replaced with NULL test. > > Signed-off-by: Wei Yongjun obviously correct, thanks for catching. Reviewed-by: Heiko Stuebner