* [PATCH 30/30] iio: adc: rockchip_saradc: Demote Demote seemingly unintentional kerneldoc header [not found] <20200717165538.3275050-1-lee.jones@linaro.org> @ 2020-07-17 16:55 ` Lee Jones [not found] ` <20200717165538.3275050-31-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Lee Jones @ 2020-07-17 16:55 UTC (permalink / raw) To: jic23, knaack.h, lars, pmeerw Cc: linux-arm-kernel, linux-kernel, linux-iio, Lee Jones, Heiko Stuebner, Philipp Zabel, linux-rockchip This is the only use of kerneldoc in the source file and no descriptions are provided. Fixes the following W=1 kernel build warning(s): drivers/iio/adc/rockchip_saradc.c:190: warning: Function parameter or member 'reset' not described in 'rockchip_saradc_reset_controller' Cc: Heiko Stuebner <heiko@sntech.de> Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: linux-rockchip@lists.infradead.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/iio/adc/rockchip_saradc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c index 582ba047c4a67..cf4ec59c1dab0 100644 --- a/drivers/iio/adc/rockchip_saradc.c +++ b/drivers/iio/adc/rockchip_saradc.c @@ -183,7 +183,7 @@ static const struct of_device_id rockchip_saradc_match[] = { }; MODULE_DEVICE_TABLE(of, rockchip_saradc_match); -/** +/* * Reset SARADC Controller. */ static void rockchip_saradc_reset_controller(struct reset_control *reset) -- 2.25.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <20200717165538.3275050-31-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>]
* Re: [PATCH 30/30] iio: adc: rockchip_saradc: Demote Demote seemingly unintentional kerneldoc header [not found] ` <20200717165538.3275050-31-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> @ 2020-07-17 19:10 ` Heiko Stübner 2020-07-18 16:15 ` Jonathan Cameron 0 siblings, 1 reply; 3+ messages in thread From: Heiko Stübner @ 2020-07-17 19:10 UTC (permalink / raw) To: Lee Jones Cc: jic23-DgEjT+Ai2ygdnm+yROfE0A, knaack.h-Mmb7MZpHnFY, lars-Qo5EllUWu/uELgA04lAiVw, pmeerw-jW+XmwGofnusTnJN9+BGXg, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-iio-u79uwXL29TY76Z2rM5mHXA, Philipp Zabel, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Am Freitag, 17. Juli 2020, 18:55:38 CEST schrieb Lee Jones: > This is the only use of kerneldoc in the source file and no > descriptions are provided. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/adc/rockchip_saradc.c:190: warning: Function parameter or member 'reset' not described in 'rockchip_saradc_reset_controller' > > Cc: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> > Cc: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> > Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Signed-off-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Subject-line says "Demote Demote..." Otherwise Reviewed-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> > --- > drivers/iio/adc/rockchip_saradc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c > index 582ba047c4a67..cf4ec59c1dab0 100644 > --- a/drivers/iio/adc/rockchip_saradc.c > +++ b/drivers/iio/adc/rockchip_saradc.c > @@ -183,7 +183,7 @@ static const struct of_device_id rockchip_saradc_match[] = { > }; > MODULE_DEVICE_TABLE(of, rockchip_saradc_match); > > -/** > +/* > * Reset SARADC Controller. > */ > static void rockchip_saradc_reset_controller(struct reset_control *reset) > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 30/30] iio: adc: rockchip_saradc: Demote Demote seemingly unintentional kerneldoc header 2020-07-17 19:10 ` Heiko Stübner @ 2020-07-18 16:15 ` Jonathan Cameron 0 siblings, 0 replies; 3+ messages in thread From: Jonathan Cameron @ 2020-07-18 16:15 UTC (permalink / raw) To: Heiko Stübner Cc: Lee Jones, knaack.h, lars, pmeerw, linux-arm-kernel, linux-kernel, linux-iio, Philipp Zabel, linux-rockchip On Fri, 17 Jul 2020 21:10:27 +0200 Heiko Stübner <heiko@sntech.de> wrote: > Am Freitag, 17. Juli 2020, 18:55:38 CEST schrieb Lee Jones: > > This is the only use of kerneldoc in the source file and no > > descriptions are provided. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/iio/adc/rockchip_saradc.c:190: warning: Function parameter or member 'reset' not described in 'rockchip_saradc_reset_controller' > > > > Cc: Heiko Stuebner <heiko@sntech.de> > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > > Cc: linux-rockchip@lists.infradead.org > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > Subject-line says "Demote Demote..." > > Otherwise > Reviewed-by: Heiko Stuebner <heiko@sntech.de> Fixed up and applied. Thanks for whole set Lee. Jonathan > > > > --- > > drivers/iio/adc/rockchip_saradc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c > > index 582ba047c4a67..cf4ec59c1dab0 100644 > > --- a/drivers/iio/adc/rockchip_saradc.c > > +++ b/drivers/iio/adc/rockchip_saradc.c > > @@ -183,7 +183,7 @@ static const struct of_device_id rockchip_saradc_match[] = { > > }; > > MODULE_DEVICE_TABLE(of, rockchip_saradc_match); > > > > -/** > > +/* > > * Reset SARADC Controller. > > */ > > static void rockchip_saradc_reset_controller(struct reset_control *reset) > > > > > > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-18 16:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200717165538.3275050-1-lee.jones@linaro.org>
2020-07-17 16:55 ` [PATCH 30/30] iio: adc: rockchip_saradc: Demote Demote seemingly unintentional kerneldoc header Lee Jones
[not found] ` <20200717165538.3275050-31-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2020-07-17 19:10 ` Heiko Stübner
2020-07-18 16:15 ` Jonathan Cameron
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).