From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH] arm64: dts: rockchip: remove wrongly added idle states on rk3368 Date: Thu, 16 Mar 2017 14:21:15 +0100 Message-ID: <4545281.lFqtqln1ax@phil> References: <20170301223849.13401-1-heiko@sntech.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20170301223849.13401-1-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rockchip.vger.kernel.org Am Mittwoch, 1. M=E4rz 2017, 23:38:49 CET schrieb Heiko Stuebner: > As reported by Lorenzo, the residency/latency values defined in the > idle-state for rk3368 "make no sense". When introducing them I > simply took the idle-state node from the vendor kernel in error > as I didn't look up if these values were sane in the first place. > = > Talking to people and determining why they were used in this way > showed that it was meant to make sure the cpu_suspend callback > got initialized which at the 3.10 time was somehow required even > for wfi-based idle handling. > = > Of course the generic arch_cpu_idle() now does wfi-based idle-handling > already, so there is no need for this. > = > Reported-by: Lorenzo Pieralisi > Signed-off-by: Heiko Stuebner applied for 4.12 with Lorenzo's Ack after clarifying in the last paragraph: "Of course the generic arch_cpu_idle() now does wfi-based idle-handling already and the rk3368 does not implement any other idle states than the default WFI, so these wrong idle-states should go away." > --- > This has been sitting ere for way to long :-(, but finally I got > to finish the change. > = > arch/arm64/boot/dts/rockchip/rk3368.dtsi | 20 -------------------- > 1 file changed, 20 deletions(-) > = > diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi > b/arch/arm64/boot/dts/rockchip/rk3368.dtsi index 49d1191..5471ace 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi > @@ -107,23 +107,10 @@ > }; > }; > = > - idle-states { > - entry-method =3D "psci"; > - > - cpu_sleep: cpu-sleep-0 { > - compatible =3D "arm,idle-state"; > - arm,psci-suspend-param =3D <0x1010000>; > - entry-latency-us =3D <0x3fffffff>; > - exit-latency-us =3D <0x40000000>; > - min-residency-us =3D <0xffffffff>; > - }; > - }; > - > cpu_l0: cpu@0 { > device_type =3D "cpu"; > compatible =3D "arm,cortex-a53", "arm,armv8"; > reg =3D <0x0 0x0>; > - cpu-idle-states =3D <&cpu_sleep>; > enable-method =3D "psci"; > = > #cooling-cells =3D <2>; /* min followed by max */ > @@ -133,7 +120,6 @@ > device_type =3D "cpu"; > compatible =3D "arm,cortex-a53", "arm,armv8"; > reg =3D <0x0 0x1>; > - cpu-idle-states =3D <&cpu_sleep>; > enable-method =3D "psci"; > }; > = > @@ -141,7 +127,6 @@ > device_type =3D "cpu"; > compatible =3D "arm,cortex-a53", "arm,armv8"; > reg =3D <0x0 0x2>; > - cpu-idle-states =3D <&cpu_sleep>; > enable-method =3D "psci"; > }; > = > @@ -149,7 +134,6 @@ > device_type =3D "cpu"; > compatible =3D "arm,cortex-a53", "arm,armv8"; > reg =3D <0x0 0x3>; > - cpu-idle-states =3D <&cpu_sleep>; > enable-method =3D "psci"; > }; > = > @@ -157,7 +141,6 @@ > device_type =3D "cpu"; > compatible =3D "arm,cortex-a53", "arm,armv8"; > reg =3D <0x0 0x100>; > - cpu-idle-states =3D <&cpu_sleep>; > enable-method =3D "psci"; > = > #cooling-cells =3D <2>; /* min followed by max */ > @@ -167,7 +150,6 @@ > device_type =3D "cpu"; > compatible =3D "arm,cortex-a53", "arm,armv8"; > reg =3D <0x0 0x101>; > - cpu-idle-states =3D <&cpu_sleep>; > enable-method =3D "psci"; > }; > = > @@ -175,7 +157,6 @@ > device_type =3D "cpu"; > compatible =3D "arm,cortex-a53", "arm,armv8"; > reg =3D <0x0 0x102>; > - cpu-idle-states =3D <&cpu_sleep>; > enable-method =3D "psci"; > }; > = > @@ -183,7 +164,6 @@ > device_type =3D "cpu"; > compatible =3D "arm,cortex-a53", "arm,armv8"; > reg =3D <0x0 0x103>; > - cpu-idle-states =3D <&cpu_sleep>; > enable-method =3D "psci"; > }; > };