From: Heiko Stuebner <heiko@sntech.de>
To: linux-i2c@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Andi Shyti <andi.shyti@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/18] i2c: rk3x: remove printout on handled timeouts
Date: Thu, 11 Apr 2024 20:59:05 +0200 [thread overview]
Message-ID: <46619727.fMDQidcC6G@phil> (raw)
In-Reply-To: <20240410112418.6400-33-wsa+renesas@sang-engineering.com>
Am Mittwoch, 10. April 2024, 13:24:27 CEST schrieb Wolfram Sang:
> I2C and SMBus timeouts are not something the user needs to be informed
> about on controller level. The client driver may know if that really is
> a problem and give more detailed information to the user. The controller
> should just pass this information upwards. Remove the printout.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/i2c/busses/i2c-rk3x.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> index 086fdf262e7b..8c7367f289d3 100644
> --- a/drivers/i2c/busses/i2c-rk3x.c
> +++ b/drivers/i2c/busses/i2c-rk3x.c
> @@ -1106,9 +1106,6 @@ static int rk3x_i2c_xfer_common(struct i2c_adapter *adap,
> spin_lock_irqsave(&i2c->lock, flags);
>
> if (timeout == 0) {
> - dev_err(i2c->dev, "timeout, ipd: 0x%02x, state: %d\n",
> - i2c_readl(i2c, REG_IPD), i2c->state);
> -
> /* Force a STOP condition without interrupt */
> i2c_writel(i2c, 0, REG_IEN);
> val = i2c_readl(i2c, REG_CON) & REG_CON_TUNING_MASK;
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-04-11 18:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 11:24 [PATCH 00/18] i2c: remove printout on handled timeouts Wolfram Sang
2024-04-10 11:24 ` [PATCH 13/18] i2c: rk3x: " Wolfram Sang
2024-04-11 18:59 ` Heiko Stuebner [this message]
2024-04-12 21:12 ` Dragan Simic
2024-04-13 6:38 ` Wolfram Sang
2024-04-13 6:44 ` Dragan Simic
2024-04-13 7:10 ` Wolfram Sang
2024-04-13 8:07 ` Dragan Simic
2024-04-13 7:58 ` Heiko Stübner
2024-04-13 8:12 ` Dragan Simic
2024-04-13 14:35 ` Wolfram Sang
2024-04-16 19:02 ` Andi Shyti
2024-04-22 22:50 ` [PATCH 00/18] i2c: " Andi Shyti
2024-04-24 0:08 ` Andy Shevchenko
2024-04-24 9:00 ` Wolfram Sang
2024-04-24 12:41 ` Andy Shevchenko
2024-04-24 12:44 ` Andy Shevchenko
2024-04-27 18:03 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46619727.fMDQidcC6G@phil \
--to=heiko@sntech.de \
--cc=andi.shyti@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).