public inbox for linux-rockchip@lists.infradead.org
 help / color / mirror / Atom feed
From: "Andy Yan" <andyshrk@163.com>
To: "Marius Dinu" <m95d+git@psihoexpert.ro>
Cc: linux-rockchip@lists.infradead.org
Subject: Re:[PATCH] drm: rockchip: dw_dp: add missing dependency on bridge_connector
Date: Thu, 19 Mar 2026 17:48:54 +0800 (CST)	[thread overview]
Message-ID: <46dde1cc.8a7e.19d057f7bb7.Coremail.andyshrk@163.com> (raw)
In-Reply-To: <20260316084653.1559-1-m95d+git@psihoexpert.ro>


Hello Marius,

At 2026-03-16 16:46:53, "Marius Dinu" <m95d+git@psihoexpert.ro> wrote:
>Avoids this error:
>  ld: drivers/gpu/drm/rockchip/dw_dp-rockchip.o: in function `dw_dp_rockchip_bind':
>  /usr/src/linux/drivers/gpu/drm/rockchip/dw_dp-rockchip.c:108:(.text+0x188): undefined reference to `drm_bridge_connector_init'
>
>Signed-off-by: Marius Dinu <m95d+git@psihoexpert.ro>
>---
> drivers/gpu/drm/rockchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
>index 1479b8c4ed40..749a4b86c893 100644
>--- a/drivers/gpu/drm/rockchip/Kconfig
>+++ b/drivers/gpu/drm/rockchip/Kconfig
>@@ -13,6 +13,7 @@ config DRM_ROCKCHIP
> 	select DRM_ANALOGIX_DP if ROCKCHIP_ANALOGIX_DP
> 	select DRM_DISPLAY_DP_AUX_BUS if ROCKCHIP_ANALOGIX_DP
> 	select DRM_DW_DP if ROCKCHIP_DW_DP
>+	select DRM_BRIDGE_CONNECTOR if ROCKCHIP_DW_DP



I suggest put this in config ROCKCHIP_DW_DP,  keep the same style with ROCKCHIP_DW_HDMI_QP /ROCKCHIP_CDN_DP/ROCKCHIP_RGB


> 	select DRM_DW_HDMI if ROCKCHIP_DW_HDMI
> 	select DRM_DW_HDMI_QP if ROCKCHIP_DW_HDMI_QP
> 	select DRM_DW_MIPI_DSI if ROCKCHIP_DW_MIPI_DSI
>-- 
>2.52.0
>
>
>
>_______________________________________________
>Linux-rockchip mailing list
>Linux-rockchip@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-rockchip
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

      reply	other threads:[~2026-03-19  9:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16  8:46 [PATCH] drm: rockchip: dw_dp: add missing dependency on bridge_connector Marius Dinu
2026-03-19  9:48 ` Andy Yan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46dde1cc.8a7e.19d057f7bb7.Coremail.andyshrk@163.com \
    --to=andyshrk@163.com \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=m95d+git@psihoexpert.ro \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox