From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH] arm64: dts: rockchip: fix defines in pd_vio node for rk3399 Date: Sun, 22 Mar 2020 19:03:35 +0100 Message-ID: <48029127.kezn7BFppT@diego> References: <20200322140046.5824-1-jbx6244@gmail.com> <48a91cc1-7751-4df0-a2cd-940eb829fa16@gmail.com> <1a6f0ba0-c49c-c547-1252-eed404655f43@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <1a6f0ba0-c49c-c547-1252-eed404655f43-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Johan Jonker , Caesar Wang , kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: linux-rockchip.vger.kernel.org Am Sonntag, 22. März 2020, 17:14:54 CET schrieb Johan Jonker: > Hi, > > Why is 'pd_tcpc0, pd_tcpc1' grouped under 'pd_vio' instead of VD_LOGIC? ^^ You'll need to add Rockchip-people for that - I've done that now ;-) > On 3/22/20 4:45 PM, Johan Jonker wrote: > > Hi, > > > > The RK3399 TRM uses both > > > > 'pd_tcpc0, pd_tcpc1' > > > > as > > > > 'pd_tcpd0, pd_tcpd1'. > > > > What should we use here? We should probably just fix the nodename as you did. - For one tcpD seems to be appearing way more often than tcpC - and of course the header is part of the binding itself, so that shouldn't change without a really good reason Heiko > > > > Thanks. > > > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > >> index 8aac201f0..3dc8fe620 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > >> @@ -1087,12 +1087,12 @@ > >> pm_qos = <&qos_isp1_m0>, > >> <&qos_isp1_m1>; > >> }; > >> - pd_tcpc0@RK3399_PD_TCPC0 { > >> + pd_tcpc0@RK3399_PD_TCPD0 { > >> reg = ; > >> clocks = <&cru SCLK_UPHY0_TCPDCORE>, > >> <&cru SCLK_UPHY0_TCPDPHY_REF>; > >> }; > >> - pd_tcpc1@RK3399_PD_TCPC1 { > >> + pd_tcpc1@RK3399_PD_TCPD1 { > >> reg = ; > >> clocks = <&cru SCLK_UPHY1_TCPDCORE>, > >> <&cru SCLK_UPHY1_TCPDPHY_REF>; > > > >