From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B85DBE7849B for ; Sun, 1 Oct 2023 22:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D+h74Y/eWO81DroDy6q159z5jv9u4YGRoO1REzPs09w=; b=NhM73NTc7aaiiP JlUmEGTUCkt6IIppac6j+7gouuYmTVTMyXwRIuUOd8EaEmdSAZVmd+EZZ2ikamqJotvCPj49XPWZC fzepG7+4zR5QxlVFMyKOl4GNgce2Gq8xpir+2ta0bacaER+2dq6xqQQdSQ8MWjwP9iH2VZARxs5kA lG3eGZ8JqI8BYiq+QlJvI23J83kqPwFk+f1G7lylMoYZ9mVhjxN1H+vhTaDBp6PTH6L4B5dmW/YSP s1yBO811sx9uS28Criojp/EW5SxVSsxr1qVCx6JBkaR34OyCsvzPsesc7OvkFNxt4shBMZ4ZTB86C NrWkF1koh/CnQLicNLWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qn5CE-00Bi6b-2r; Sun, 01 Oct 2023 22:45:54 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qn5CB-00Bi4z-2W; Sun, 01 Oct 2023 22:45:53 +0000 Received: from i53875a3c.versanet.de ([83.135.90.60] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qn5C3-0002ng-SD; Mon, 02 Oct 2023 00:45:43 +0200 From: Heiko Stuebner To: Linus Walleij , Bartosz Golaszewski , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 16/23] gpio: rockchip: Convert to platform remove callback returning void Date: Mon, 02 Oct 2023 00:45:50 +0200 Message-ID: <4863315.31r3eYUQgx@phil> In-Reply-To: <20230928070706.2290137-17-u.kleine-koenig@pengutronix.de> References: <20230928070706.2290137-1-u.kleine-koenig@pengutronix.de> <20230928070706.2290137-17-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231001_154551_820806_EA0A663B X-CRM114-Status: GOOD ( 12.74 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Am Donnerstag, 28. September 2023, 09:06:59 CEST schrieb Uwe Kleine-K=F6nig: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > = > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig Reviewed-by: Heiko Stuebner _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip