Re: [PATCH 0/3] arm64: dts: rockchip: Add Radxa ROCK 5B+ and rebase Radxa ROCK 5B

From: Dragan Simic <dsimic@manjaro.org>
To: Alexey Charkov <alchark@gmail.com>
Cc: FUKAUMI Naoki <naoki@radxa.com>,
	heiko@sntech.de, robh@kernel.org, conor+dt@kernel.org,
	inindev@gmail.com, liujianfeng1994@gmail.com, jonas@kwiboo.se,
	dmt.yashin@gmail.com, sebastian.reichel@collabora.com,
	tim@feathertop.org, kever.yang@rock-chips.com,
	marcin.juszkiewicz@linaro.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	michael.riesch@wolfvision.net, macromorgan@hotmail.com,
	krzk+dt@kernel.org
Subject: Re: [PATCH 0/3] arm64: dts: rockchip: Add Radxa ROCK 5B+ and rebase Radxa ROCK 5B
Date: Wed, 25 Dec 2024 10:35:26 +0100	[thread overview]
Message-ID: <4bac4d58493cb0e7fc863095e02ffad3@manjaro.org> (raw)
In-Reply-To: <CABjd4YxLnays9Ho0bDR0pTyz5Tjx3C=0U6bcRdQ8ntyu68VVGg@mail.gmail.com>

Hello Alexey and Naoki,

On 2024-12-25 09:32, Alexey Charkov wrote:
> On Wed, Dec 25, 2024 at 12:22 PM FUKAUMI Naoki <naoki@radxa.com> wrote:
>> 
>> The Radxa ROCK 5B+ is an upgraded version of the Radxa ROCK 5B.
>> 
>> This patch series introduces a shared .dtsi that can be used on the
>> new Radxa ROCK 5B+, the existing Radxa ROCK 5B, and the upcoming Radxa
>> ROCK 5T.
>> 
>> This patch series includes "arm64: dts: rockchip: Add USB-C support to
>> ROCK 5B" by Sebastian Reichel[1].
>> 
>> [1] 
>> https://patchwork.kernel.org/project/linux-rockchip/patch/20241210163615.120594-1-sebastian.reichel@collabora.com/
>> 
>> FUKAUMI Naoki (3):
>>   dt-bindings: arm: rockchip: Add Radxa ROCK 5B+
>>   arm64: dts: rockchip: Add Radxa ROCK 5B+
>>   arm64: dts: rockchip: Convert Radxa ROCK 5B to use shared .dtsi
> 
> This one doesn't look equivalent to the existing ROCK 5B device tree
> after your changes (I've noticed in particular that fan cooling levels
> are different - but that's just the part I remember well since I
> modified it earlier, there might be more differences).
> 
> Would you mind rearranging the patches so that the split of ROCK 5B
> dts into a common .dtsi and per-board .dts additions could be made
> one-to-one equivalent without functional changes, and then add ROCK
> 5B+ and any other required changes on top of that?
> 
> See what Dragan did where he prepared parent .dtsi for per-variant OPPs 
> [1]
> 
> [1] 
> https://lore.kernel.org/linux-rockchip/9ffedc0e2ca7f167d9d795b2a8f43cb9f56a653b.1717923308.git.dsimic@manjaro.org/

Just a brief note that I agree with Alexey's recommendation above.
These patches should be reworked in a way that makes the transition
to using the shared dtsi file much more obvious.

Besides making these changes easier to review that way, and giving
better chances to ensuring there are no issues that managed to slip
through the cracks, it will also be much easier later to track down
any possible regressions, in case they eventually are discovered.

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip