From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3040BC4167B for ; Thu, 30 Nov 2023 12:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eWSXeGQq4rYu46K4ThzWZZ0g61v3RnmTLigXtECyBTk=; b=McumTwP/e40Cek rfDA0SikgdiOLW5MN3vYIyzBQu10uWfHVhlbvplSPiYwOfd5EVNnlNZMHTN06gY07KCq8UvMIehdk xSWfpQcC2gWR55icH5z7jypd6+eMv8XjW6o+UaIH0kj/Kg6SInvls2oeVkVg0/D2uCcVKhq4dYCp8 jqQzRXHHZhBSk5C9tOBAHwI/yekqvDTABmiEMqaCq93bLrKX/oRSvwswPt4lUD8BD24Ypz+KhIwZs 46TgyER/o3FYQ28GabRznmWF72ghsD8IGR7GJHuArNaXHaivweqGcYt7vljxLjEEKov4E/PI2225t gF7vtc2xEcGiBcgS/iOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8gDq-00ArhK-3D; Thu, 30 Nov 2023 12:32:51 +0000 Received: from mail-m12794.qiye.163.com ([115.236.127.94]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8gDn-00Arex-1k for linux-rockchip@lists.infradead.org; Thu, 30 Nov 2023 12:32:49 +0000 DKIM-Signature: a=rsa-sha256; b=e8MrUsVWZLiX5MpnY5R6sm2oBohVo8MnMibe6kRCFkSBnIsiD+m4tU4lt7VStHIPMC4O0io+WF1/sEzauJ5bh2lPIace3zvBT4tW5mQtvkpKJ/GFLPUVWFuQxtDGmPgf+xapi684hsW0bHdQoHXsjJOvfyxlA1MMTM0PUBpMbDg=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=xw5s3z0kYWPrNZEeAkS1HnYylOFQxmO2lako+w4LWo0=; h=date:mime-version:subject:message-id:from; Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m12779.qiye.163.com (Hmail) with ESMTPA id E8F5E780310; Thu, 30 Nov 2023 20:32:16 +0800 (CST) Message-ID: <4d6c5980-e573-4d85-bc9c-6726413a15d3@rock-chips.com> Date: Thu, 30 Nov 2023 20:32:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 08/12] dt-bindings: display: vop2: Add rk3588 support Content-Language: en-US To: Krzysztof Kozlowski , Andy Yan , heiko@sntech.de Cc: hjc@rock-chips.com, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org, sebastian.reichel@collabora.com, kever.yang@rock-chips.com, chris.obbard@collabora.com, s.hauer@pengutronix.de References: <20231122125316.3454268-1-andyshrk@163.com> <20231122125518.3454796-1-andyshrk@163.com> From: Andy Yan In-Reply-To: X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGU4eHlZPSEMfSU5LHkxDSE5VEwETFh oSFyQUDg9ZV1kYEgtZQVlOQ1VJSVVMVUpKT1lXWRYaDxIVHRRZQVlPS0hVSk1PSU5JVUpLS1VKQl kG X-HM-Tid: 0a8c20373177b24fkuuue8f5e780310 X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6ND46Lxw4KDw3TxdDPjUCPyo# GDZPFE5VSlVKTEtKSE9MTkhMQ05LVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBTkJOTTcG X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231130_043247_733794_DC2AEB9A X-CRM114-Status: GOOD ( 18.36 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Krzysztof: On 11/23/23 03:07, Krzysztof Kozlowski wrote: > On 22/11/2023 13:55, Andy Yan wrote: >> From: Andy Yan >> >> The vop2 on rk3588 is similar to which on rk356x >> but with 4 video ports and need to reference >> more grf modules. >> >> Signed-off-by: Andy Yan >> >> --- >> >> Changes in v2: >> - fix errors when running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> >> .../display/rockchip/rockchip-vop2.yaml | 27 +++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml >> index b60b90472d42..24148d9b3b14 100644 >> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml >> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml >> @@ -20,6 +20,7 @@ properties: >> enum: >> - rockchip,rk3566-vop >> - rockchip,rk3568-vop >> + - rockchip,rk3588-vop >> >> reg: >> items: >> @@ -42,26 +43,47 @@ properties: >> frame start (VSYNC), line flag and other status interrupts. >> >> clocks: >> + minItems: 3 >> items: >> - description: Clock for ddr buffer transfer. >> - description: Clock for the ahb bus to R/W the phy regs. >> - description: Pixel clock for video port 0. >> - description: Pixel clock for video port 1. >> - description: Pixel clock for video port 2. >> + - description: Pixel clock for video port 4. >> + - description: Peripheral clock for vop on rk3588. >> >> clock-names: >> + minItems: 3 > > You relax requirements for all existing variants here which is not > explained in commit msg. I assume this was not intentional, so you need > to re-constrain them in allOf:if:then. > > See for example: > https://elixir.bootlin.com/linux/v5.19-rc6/source/Documentation/devicetree/bindings/clock/samsung,exynos7-clock.yaml#L57 > for some ideas. > >> items: >> - const: aclk >> - const: hclk >> - const: dclk_vp0 >> - const: dclk_vp1 >> - const: dclk_vp2 >> + - const: dclk_vp3 >> + - const: pclk_vop >> >> rockchip,grf: >> $ref: /schemas/types.yaml#/definitions/phandle >> description: >> Phandle to GRF regs used for misc control >> >> + rockchip,vo-grf: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: >> + Phandle to VO GRF regs used for misc control, required for rk3588 > > Drop last sentence, instead add it to required in allOf:if:then. > > Is this valid for other variants? If not, should be disallowed in > allOf:if:then: for them. Only valid for rk3588 now. > >> + >> + rockchip,vop-grf: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: >> + Phandle to VOP GRF regs used for misc control, required for rk3588 >> + >> + rockchip,pmu: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: >> + Phandle to PMU regs used for misc control, required for rk3588 > > For all these three: what is "misc control"? Way too vague. Everything > is a misc and everything can be control. You must be here specific and > much more descriptive. improve in v3 > >> + >> ports: >> $ref: /schemas/graph.yaml#/properties/ports >> >> @@ -81,6 +103,11 @@ properties: >> description: >> Output endpoint of VP2 >> >> + port@3: >> + $ref: /schemas/graph.yaml#/properties/port >> + description: >> + Output endpoint of VP3 > > Valid for other variants? > Only valid for rk3588 now. Thanks for your review and guidance, I try to fix in v3 [0] [0]https://patchwork.kernel.org/project/linux-rockchip/patch/20231130122418.13258-1-andyshrk@163.com/ > Best regards, > Krzysztof > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip