Re: [PATCH v3.1 03/13] rockchip: dts: rk3399: Create initial rk3399-u-boot.dtsi

[Paul Kocialkowski <paul.kocialkowski@bootlin.com>]

Hi,

On Fri, 2019-04-26 at 19:07 +0530, Jagan Teki wrote:
> On Fri, Apr 26, 2019 at 7:04 PM Paul Kocialkowski
> <paul.kocialkowski@bootlin.com> wrote:
> > Hi,
> > 
> > On Fri, 2019-04-26 at 18:48 +0530, Jagan Teki wrote:
> > > u-boot,dm-pre-reloc is required for SDMMC booted rk3399 boards and
> > > which is U-Boot specific devicetrees binding.
> > > 
> > > Move it on global rk3399-u-boot.dtsi file and rest of the U-Boot
> > > bindings will move it future based on the requirement.
> > > 
> > > This would help to sync the devicetrees from Linux whenever required
> > > instead of adding specific nodes.
> > > 
> > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> > 
> > Since your patch has changed significantly, you can no longer include a
> > Reviewed-by that was given on a previous iteration.
> > 
> > It looks like we are still missing bits to have rk3399-u-boot.dtsi
> > included, so this patch does not get my Reviewed-by tag.
> 
> It will include rockchip-u-boot.dtsi automatically and I made the
> receptive changes to include other files in this patch [1] and sure I
> will ask Philipp to remove the reviewed-by tag, thanks.

Most importantly (now that I see the new series), you should certainly
have sent that patch as part of your new series because we now have an
inter-dependency between both series.

Could you clean that up and make a proper standalone series that
creates and populates rk3399-u-boot.dtsi?

Cheers,

Paul

> [1] https://patchwork.ozlabs.org/patch/1091543/
-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot