From mboxrd@z Thu Jan 1 00:00:00 1970 From: wlf Subject: Re: [PATCH 1/2] phy: rockchip-inno-usb2: fix uninitialized tmout variable Date: Fri, 18 Nov 2016 11:17:14 +0800 Message-ID: <4f75b364-c79a-2d03-00e1-42e941b75b2e@rock-chips.com> References: <20161116142259.2123506-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20161116142259.2123506-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann , Kishon Vijay Abraham I Cc: Heiko Stuebner , Douglas Anderson , Frank Wang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org Hi Arnd, 在 2016年11月16日 22:22, Arnd Bergmann 写道: > The newly added OTG support has an obvious uninitialized variable > access that gcc warns about: > > drivers/phy/phy-rockchip-inno-usb2.c: In function 'rockchip_chg_detect_work': > drivers/phy/phy-rockchip-inno-usb2.c:717:7: error: 'tmout' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > This replaces the use of the uninitialized variable with what > the value was in the previous USB_CHG_STATE_WAIT_FOR_DCD > state. > > Fixes: 0c42fe48fd23 ("phy: rockchip-inno-usb2: support otg-port for rk3399") > Signed-off-by: Arnd Bergmann > --- > drivers/phy/phy-rockchip-inno-usb2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/phy-rockchip-inno-usb2.c b/drivers/phy/phy-rockchip-inno-usb2.c > index eb89de59b68f..2f99ec95079c 100644 > --- a/drivers/phy/phy-rockchip-inno-usb2.c > +++ b/drivers/phy/phy-rockchip-inno-usb2.c > @@ -714,7 +714,7 @@ static void rockchip_chg_detect_work(struct work_struct *work) > delay = CHG_SECONDARY_DET_TIME; > rphy->chg_state = USB_CHG_STATE_PRIMARY_DONE; > } else { > - if (tmout) { > + if (rphy->dcd_retries == CHG_DCD_MAX_RETRIES) { > /* floating charger found */ > rphy->chg_type = POWER_SUPPLY_TYPE_USB_DCP; > rphy->chg_state = USB_CHG_STATE_DETECTED; Thanks very much for your help. Reviewed-by: William Wu Best Regards, wulf