Re: [PATCH 2/8] dt-bindings: nvmem: rockchip-otp: Add compatible for RK3588

Krzysztof Kozlowski
2023-05-04T14:39:43Z

On 04/05/2023 16:14, Cristian Ciocaltea wrote:
>>> + reset-names:
>>> + items:
>>> + - const: phy
>>> +
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + enum:
>>> + - rockchip,rk3588-otp
>>> + then:
>>> + properties:
>>> + clocks:
>>> + minItems: 4
>>> + maxItems: 4
>>> + clock-names:
>>> + items:
>>> + - const: otpc
>>> + - const: apb
>>> + - const: arb
>>> + - const: phy
>>
>> Keep the same order of clocks as in older variants, so you can keep the
>> list in top-level place and here only minItems: 4.
>>
>>> + resets:
>>> + minItems: 1
>>> + maxItems: 3
>>> + reset-names:
>>> + items:
>>> + - const: otpc
>>
>> Shouldn't this be phy?
>
> It seems there is no reset for PHY, or at least I couldn't find any
> reference in the RK3588 TRM, nor in the downstream driver implementation.

OK, just to be sure that this is not the same reset as rk3308 just
differently named in consumer.

Best regards,
Krzysztof