From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 245B3C001E0 for ; Fri, 28 Jul 2023 18:28:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dkFTzwYMeLxFLEvRtGqy8HFd75Pj+8pGW5QyNTnz04Q=; b=4a+pwJ1oLbhw1m 25caDqBeMm2brxOfSfDEi03NBH+LtAr0lOIcPn4oJGmkq+PHdNEcUWjWbfG2gO9VRTuMso891Svmv WDMMPwP3b8k4vdfjZ15Oxh40odC+XPoM+vuUAgGv3ukS7AN/NipBmIJr//HlVBCKeoql8/qDk8wa8 gd3rVtePPw2pttA/k1G+3CFPYGnowMOUznyaN5wsXNYjBDaXjcewl167klnXsUTvhbKak9P5Giann lFHDltQ6bGwdIVNqsNObUDFEyg5rRmAgpu6VphHzzUj4rY2Pma3NWrqM9+g41x0bYke36YO1j4Ov8 2VwUp3XUX0eA9dCG/8+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qPSCI-004WvL-1H; Fri, 28 Jul 2023 18:28:18 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qPS8v-004VFD-2y; Fri, 28 Jul 2023 18:24:51 +0000 Received: from [185.230.175.137] (helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qPS8p-0000d5-IO; Fri, 28 Jul 2023 20:24:43 +0200 From: Heiko Stuebner To: Jaehoon Chung , Ulf Hansson , Yangtao Li Cc: Yangtao Li , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 41/62] mmc: dw_mmc: rockchip: Convert to platform remove callback returning void Date: Fri, 28 Jul 2023 20:24:42 +0200 Message-ID: <5065221.NG923GbCHz@phil> In-Reply-To: <20230727070051.17778-41-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> <20230727070051.17778-41-frank.li@vivo.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230728_112449_960249_602980A3 X-CRM114-Status: GOOD ( 12.62 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Am Donnerstag, 27. Juli 2023, 09:00:30 CEST schrieb Yangtao Li: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Cc: Uwe Kleine-K=F6nig > Signed-off-by: Yangtao Li Acked-by: Heiko Stuebner _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip