Re: [PATCH 0/2] Describe the cameras in the PinePhone Pro dts

Dragan Simic
2025-02-28T16:02:07Z

Hello Olivier,

On 2025-02-28 16:19, Olivier Benjamin wrote:
> This series adds support for the Pine64 PinePhone Pro's rear and front
> cameras in Device Tree.
> This is based on some of Ondrej Jirman's patches hosted in his tree at
> https://codeberg.org/megi/linux, but I have also fully reviewed and
> re-written the code from the RK3399 datasheet, the PinePhone Pro
> schematic, and the IMX258-0AQH5 software reference manual.
>
> I have tested these changes on my PinePhone Pro and am able to take
> photos from both cameras using libcamera's cam.
>
> Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com>

I'm afraid that you haven't addressed the notes from the feedback
you received earlier? [*] Also, this should be the v2 of the series,
which should contain "PATCH v2" in the patch subjects, and provide
a summary of changes in the cover letter.

Or, did you just resend the v1 by mistake?

[*] https://lore.kernel.org/linux-rockchip/5127541.31r3eYUQgx@phil/

> ---
> Olivier Benjamin (2):
> arm64: dts: PinePhone Pro: describe I2c Bus 1 and IMX258 world
> camera
> arm64: dts: PinePhone Pro: describe the OV8858 user camera
>
> .../boot/dts/rockchip/rk3399-pinephone-pro.dts | 138
> +++++++++++++++++++++
> 1 file changed, 138 insertions(+)
> ---