Re: [PATCH v2 02/17] dt-bindings: mmc: Add support for rk3562 eMMC

Heiko Stuebner
2024-12-26T00:35:47Z

Hi Kever,

Am Dienstag, 24. Dezember 2024, 10:49:05 CET schrieb Kever Yang:
> rk3562 is using the same controller as rk3588.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> Changes in v2: None
>
> .../devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> index c3d5e0230af1..33f4288ff879 100644
> --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> @@ -14,16 +14,19 @@ properties:
> compatible:
> oneOf:

oneOf means what the naming suggests, the compatible needs to
either follow the "items", the old one means:
"rockchip,rk3576-dwcmshc", "rockchip,rk3588-dwcmshc"
or the enum below, which means "one" element from the enum
list.

> - items:
> - - const: rockchip,rk3576-dwcmshc
> + - const: rockchip,rk3568-dwcmshc
> - const: rockchip,rk3588-dwcmshc

That means, both the rk3568 and rk3588 entries in the enum below need
to stay, as they represent the single-value compatibles and the items
above should definitly not mention the rk3568, but instead be modified
to just include the rk3562. So just modify the items above to include it:

- items:
- enum:
- rockchip,rk3562-dwcmshc
- rockchip,rk3576-dwcmshc
- const: rockchip,rk3588-dwcmshc

> - enum:
> - - rockchip,rk3568-dwcmshc
> - - rockchip,rk3588-dwcmshc
> - snps,dwcmshc-sdhci
> - sophgo,cv1800b-dwcmshc
> - sophgo,sg2002-dwcmshc
> - sophgo,sg2042-dwcmshc
> - thead,th1520-dwcmshc

Heiko