From: "Dragan Simic" <dsimic@manjaro.org>
To: "Diederik de Haas" <diederik@cknow-tech.com>
Cc: "FUKAUMI Naoki" <naoki@radxa.com>,
heiko@sntech.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, jbx6244@gmail.com, pgwipeout@gmail.com,
jonas@kwiboo.se, ziyao@disroot.org, amadeus@jmu.edu.cn,
nicolas.frattaroli@collabora.com, pbrobinson@gmail.com,
wens@kernel.org, detlev.casanova@collabora.com,
stephen@radxa.com, sebastian.reichel@collabora.com,
liujianfeng1994@gmail.com, andy.yan@rock-chips.com,
damon.ding@rock-chips.com, kylepzak@projectinitiative.io,
devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2] arm64: dts: rockchip: Turn all LEDs on at boot for Radxa boards
Date: Tue, 11 Nov 2025 15:46:04 +0100 [thread overview]
Message-ID: <516e919a-42af-8707-4e75-a808df8971fd@manjaro.org> (raw)
In-Reply-To: <DE5W0143QGG2.3C7SW89IJKZ4P@cknow-tech.com>
Hello Diederik,
On Tuesday, November 11, 2025 14:07 CET, "Diederik de Haas" <diederik@cknow-tech.com> wrote:
> On Tue Nov 11, 2025 at 6:41 AM CET, FUKAUMI Naoki wrote:
> > Radxa's boards turn all LEDs on at boot(loader), but some boards don't
> > have `default-state` property in Linux kernel tree but have it in
> > U-Boot tree instead[1].
> >
> > This patch adds `default-state = "on"` for (almost) all LEDs (with a
> > few exceptions which should be "off" such as RGB LEDs on E25 and LAN/
> > WAN LEDs on E20C/E52C).
>
> I'm missing the *why* these changes would be an improvement.
>
> Personally, for both 'heartbeat' and 'netdev' triggers, I want them to
> be off by default and once it gets a 'heartbeat' or a 'netdev' trigger,
> THEN I want the LED to be on/blinking.
That's a good question for Naoki. My own preference would also
be to have the device's power LED turned on by U-Boot as quickly
as possible after supplying power to the board or turning it on
by pressing the power button. I'm actually not a big fan of
having all the LEDs shining for a couple of seconds or so, which
may actually look like some error condition to me.
Having all that in mind, I may suggest that just the U-Boot's
behavior is changed to turn the power LEDs on only.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-11-11 14:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 5:41 [PATCH v2] arm64: dts: rockchip: Turn all LEDs on at boot for Radxa boards FUKAUMI Naoki
2025-11-11 6:04 ` Dragan Simic
2025-11-11 13:07 ` Diederik de Haas
2025-11-11 14:46 ` Dragan Simic [this message]
2025-11-11 15:32 ` FUKAUMI Naoki
2025-11-11 16:14 ` Dragan Simic
2025-11-11 18:32 ` Quentin Schulz
2025-11-11 23:42 ` FUKAUMI Naoki
2025-11-12 9:40 ` Diederik de Haas
2025-11-12 10:34 ` Quentin Schulz
2025-11-12 11:36 ` FUKAUMI Naoki
2025-11-12 13:21 ` Diederik de Haas
2025-11-12 15:04 ` FUKAUMI Naoki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516e919a-42af-8707-4e75-a808df8971fd@manjaro.org \
--to=dsimic@manjaro.org \
--cc=amadeus@jmu.edu.cn \
--cc=andy.yan@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=damon.ding@rock-chips.com \
--cc=detlev.casanova@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=diederik@cknow-tech.com \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=kylepzak@projectinitiative.io \
--cc=linux-rockchip@lists.infradead.org \
--cc=liujianfeng1994@gmail.com \
--cc=naoki@radxa.com \
--cc=nicolas.frattaroli@collabora.com \
--cc=pbrobinson@gmail.com \
--cc=pgwipeout@gmail.com \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=stephen@radxa.com \
--cc=wens@kernel.org \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox