From: "Heiko Stübner" <heiko@sntech.de>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V3] clocksource/drivers/rockchip_timer: Convert init function to return error
Date: Sat, 18 Jun 2016 15:47:13 +0200 [thread overview]
Message-ID: <5185607.7BCdEvMvLD@diego> (raw)
In-Reply-To: <1466254447-2420-1-git-send-email-daniel.lezcano@linaro.org>
Am Samstag, 18. Juni 2016, 14:54:07 schrieb Daniel Lezcano:
> The init functions do not return any error. They behave as the following:
>
> - panic, thus leading to a kernel crash while another timer may work and
> make the system boot up correctly
>
> or
>
> - print an error and let the caller unaware if the state of the system
>
> Change that by converting the init functions to return an error conforming
> to the CLOCKSOURCE_OF_RET prototype.
>
> Proper error handling (rollback, errno value) will be changed later case
> by case, thus this change just return back an error or success in the init
> function.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
looks good now :-)
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
on a rk3399-evb
Tested-by: Heiko Stuebner <heiko@sntech.de>
Heiko
next prev parent reply other threads:[~2016-06-18 13:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1466112442-31105-1-git-send-email-daniel.lezcano@linaro.org>
[not found] ` <1466112442-31105-1-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-06-16 21:26 ` [PATCH V2 03/63] clocksource/drivers/rockchip_timer: Convert init function to return error Daniel Lezcano
2016-06-18 10:38 ` Heiko Stübner
2016-06-18 12:54 ` [PATCH V3] " Daniel Lezcano
2016-06-18 13:47 ` Heiko Stübner [this message]
2016-06-16 21:27 ` [PATCH V2 63/63] clocksources: Switch back to the clksrc table Daniel Lezcano
2016-06-17 8:36 ` Krzysztof Kozlowski
2016-06-17 16:04 ` Santosh Shilimkar
2016-06-18 13:48 ` Heiko Stübner
2016-06-20 7:43 ` Patrice Chotard
2016-06-20 9:19 ` Neil Armstrong
[not found] ` <1466112442-31105-64-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-06-17 16:18 ` Matthias Brugger
2016-06-20 9:17 ` Liviu Dudau
2016-06-20 17:03 ` Sylvain Lemieux
2016-06-21 6:00 ` Ray Jui
2016-06-21 6:45 ` Noam Camus
2016-06-24 7:13 ` Chen-Yu Tsai
2016-06-24 20:12 ` Carlo Caione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5185607.7BCdEvMvLD@diego \
--to=heiko@sntech.de \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox