From: Benjamin Gaignard <benjamin.gaignard@collabora.com>
To: Heiko Stuebner <heiko@sntech.de>,
Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH] arm64: dts: rockchip: rk3588is: Add AV1 decoder node
Date: Thu, 5 Oct 2023 17:39:18 +0200 [thread overview]
Message-ID: <531ea6cc-83b5-4c88-90a3-576e2e38bf80@collabora.com> (raw)
In-Reply-To: <2298521.ElGaqSPkdT@phil>
Le 05/10/2023 à 17:30, Heiko Stuebner a écrit :
> Am Donnerstag, 5. Oktober 2023, 17:12:10 CEST schrieb Sebastian Reichel:
>> Hi,
>>
>> On Thu, Oct 05, 2023 at 04:54:20PM +0200, Benjamin Gaignard wrote:
>>> Add node for AV1 video decoder.
>>>
>>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
>>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>> No need for my SoB. Instead have this one:
>>
>> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>>
>> Also worth mentioning, that this Patch needs one small fix in the DT
>> binding (adding "resets") and one small fix in the driver for out of
>> the box AV1 support:
>>
>> https://lore.kernel.org/all/20231005144934.169356-1-benjamin.gaignard@collabora.com/
>> https://lore.kernel.org/all/20231005145116.169411-1-benjamin.gaignard@collabora.com/
> additionally the node name should be generic.
> The phandle can of course be av1d but the node
> name itself needs a change.
Does "video-codec-av1@fdc70000" sound good for you ?
>
> Heiko
>
>
>>> ---
>>> arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 14 ++++++++++++++
>>> 1 file changed, 14 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
>>> index 5544f66c6ff4..835e66d85d5f 100644
>>> --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
>>> +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
>>> @@ -2304,6 +2304,20 @@ gpio4: gpio@fec50000 {
>>> #interrupt-cells = <2>;
>>> };
>>> };
>>> +
>>> + av1d: av1d@fdc70000 {
>>> + compatible = "rockchip,rk3588-av1-vpu";
>>> + reg = <0x0 0xfdc70000 0x0 0x800>;
>>> + interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH 0>;
>>> + interrupt-names = "vdpu";
>>> + clocks = <&cru ACLK_AV1>, <&cru PCLK_AV1>;
>>> + clock-names = "aclk", "hclk";
>>> + assigned-clocks = <&cru ACLK_AV1>, <&cru PCLK_AV1>;
>>> + assigned-clock-rates = <400000000>, <400000000>;
>>> + resets = <&cru SRST_A_AV1>, <&cru SRST_P_AV1>, <&cru SRST_A_AV1_BIU>, <&cru SRST_P_AV1_BIU>;
>>> + power-domains = <&power RK3588_PD_AV1>;
>>> + status = "okay";
>>> + };
>>> };
>>>
>>> #include "rk3588s-pinctrl.dtsi"
>
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2023-10-05 15:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 14:54 [PATCH] arm64: dts: rockchip: rk3588is: Add AV1 decoder node Benjamin Gaignard
2023-10-05 15:12 ` Sebastian Reichel
2023-10-05 15:30 ` Heiko Stuebner
2023-10-05 15:39 ` Benjamin Gaignard [this message]
2023-10-05 15:43 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531ea6cc-83b5-4c88-90a3-576e2e38bf80@collabora.com \
--to=benjamin.gaignard@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox