Re: [PATCH v2 0/3] Fix RV1106 SAR-ADC support

From: "Heiko Stübner" <heiko@sntech.de>
To: Vladislav Leonov <vlad@zlab.su>, Jonathan Cameron <jic23@kernel.org>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Joshua Crofts" <joshua.crofts1@gmail.com>,
	"Simon Glass" <sjg@chromium.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] Fix RV1106 SAR-ADC support
Date: Mon, 31 Aug 2026 10:17:17 +0200	[thread overview]
Message-ID: <5330090.ejJDZkT8p0@diego> (raw)
In-Reply-To: <20260831025557.6ee7c42e@jic23-huawei>

Hi Jonathan,

Am Montag, 31. August 2026, 03:55:57 Mitteleuropäische Sommerzeit schrieb Jonathan Cameron:
> On Sun, 23 Aug 2026 15:20:31 +0300
> Vladislav Leonov <vlad@zlab.su> wrote:
> 
> > This series fixes the support for the RV1106 SAR-ADC in the
> > rockchip_saradc driver and its device tree bindings.
> 
> I debated how to apply this.  Technically patch 3 is a fix, 2 is an enabler
> and 1 is also a fix, but one for something that we just effectively patched
> out from running in patch 3.
> 
> So in the end I'm thinking take this the slow path for next cycle.  Shout
> if anyone thinks this should go in during the -RCs and whether all 3
> should do so or just patches 2 and 3 (leaving us without driver support for
> now).
> 
> Applied to the testing branch of iio.git

I guess I should shout then ;-) .

DT-Binding patches are sort of independent of the driver change and
are considered API which should not change after the fact.

Our DTs (but also ones possibly contained in firmware somewhere) are
validated against the binding and it seems the correct compartible goes
from 
    "rockchip,rv1106-saradc", " rockchip,rk3588-saradc"
to
    "rockchip,rv1106-saradc"

As the fixed commit is part of 7.3-rc1, I guess it would be nice to
have patches 2+3 in 7.3 and patch 1 can wait for 7.4 .

We don't need the driver support (dt-nodes just doesn't bind to
anything), but it would be nice to not proliferate the wrong binding in
an actual release.

my 2ct :-)
Heiko

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip