From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98EE6C48BDF for ; Tue, 22 Jun 2021 13:02:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2EAF613AB for ; Tue, 22 Jun 2021 13:02:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2EAF613AB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WWlTvCzciy/WK+X7/S41rTnJ6EyPe900aZVJyTD7vMU=; b=X6SuumH1vrw1Vi SfEKdOQ/4DaqMR/SIfVVdmIzZoT4MJwjq8AIc01pUBiJIPbc2bkila7TdIwmjcNjaFC0kpFAZvSlR Xfcj1amOycDas/plmHbx+xYkjErtv57HWDNjg2Y3TsV6mrkrM/eLAYFJ0AV3BN9FQBYFrXn1W07zM XN1renIFn6wp96+RPJR/lfY3PVMbWdZzlv+zxxr2AvTU6KXAHPuw1UG4d7HXJMzJc45GSfTClCThn cLUlU/ZIB2lVxEgUofYnuKTq4oosRStX6KIzw8qbMcLqzW/D88607fl7tM4fN4qVNwTkJ9hoYfIwJ BtteMLUuHP0cPC35f9Ew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvg2z-007FGJ-8O; Tue, 22 Jun 2021 13:02:33 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvg2x-007FFR-8f for linux-rockchip@lists.infradead.org; Tue, 22 Jun 2021 13:02:32 +0000 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lvg2t-0003mM-KV; Tue, 22 Jun 2021 15:02:27 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: linus.walleij@linaro.org, Jianqun Xu Cc: linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, kever.yang@rock-chips.com, Liang Chen Subject: Re: [PATCH 4/9] dt-bindings: gpio: change items restriction of clock for rockchip, gpio-bank Date: Tue, 22 Jun 2021 15:02:26 +0200 Message-ID: <5359180.zXnORWrf4K@diego> In-Reply-To: <20210618062449.1067106-5-jay.xu@rock-chips.com> References: <20210618062449.1067106-1-jay.xu@rock-chips.com> <20210618062449.1067106-5-jay.xu@rock-chips.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210622_060231_361451_4B84B6BA X-CRM114-Status: GOOD ( 14.66 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Jay, Am Freitag, 18. Juni 2021, 08:24:44 CEST schrieb Jianqun Xu: > From: Liang Chen > > The clock property need 2 items on some rockchip chips. > > Signed-off-by: Liang Chen > --- > .../devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > index d993e002cebe..0d62c28fb58d 100644 > --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > @@ -22,7 +22,10 @@ properties: > maxItems: 1 > > clocks: > - maxItems: 1 > + minItems: 1 > + items: > + - description: APB interface clock source > + - description: GPIO debounce reference clock source as said in a previous mail, please adapt this to use clock-names for the two clock variant. Maybe something like clocks: minItems: 1 maxItems: 2 clock-names: minItems: 1 maxItems: 2 items: - const: apb_pclk - const: debounce if: properties: clocks: items: const: 2 then: required: - clock-names [not yet sure if that works] Heiko > > gpio-controller: true > > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip