Re: [PATCH] arm64: dts: rockchip: sapphire: add chosen node

[Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>]

Hi Vicente,

Am Freitag, 26. Oktober 2018, 15:36:55 CET schrieb Vicente Bergas:
> In order to use earlycon, the stdout-path property needs to be set in
> the chosen node.
> 
> ---
> 
> Also, this works around this kexec bug:
> http://lists.infradead.org/pipermail/kexec/2018-October/021746.html
> 
> Signed-off-by: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399-sapphire.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dts b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dts
> index 5a5806044..326615018 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dts
> @@ -9,4 +9,8 @@
>  / {
>  	model = "Sapphire-RK3399 Board";
>  	compatible = "rockchip,rk3399-sapphire", "rockchip,rk3399";
> +
> +	chosen {
> +		stdout-path = "serial2:1500000n8";
> +	};

shouldn't that maybe live in the shared .dtsi instead?
I do guess the excavator will have the same default serial?


Heiko