linux-rockchip.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH v3 0/3] Improve eye-diagram & single-ended test for rk3288 hdmi
       [not found] <1425894141-360-1-git-send-email-ykk@rock-chips.com>
@ 2015-03-31 16:25 ` Russell King - ARM Linux
       [not found]   ` <20150331162548.GT24899-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
  2015-04-01  2:38   ` Yakir
       [not found] ` <1425894199-489-1-git-send-email-ykk@rock-chips.com>
  1 sibling, 2 replies; 6+ messages in thread
From: Russell King - ARM Linux @ 2015-03-31 16:25 UTC (permalink / raw)
  To: Yakir Yang
  Cc: Fabio Estevam, mmind00, linux-kernel, dianders, linux-rockchip,
	dri-devel, marcheu, Andy Yan

On Mon, Mar 09, 2015 at 05:42:21PM +0800, Yakir Yang wrote:
> RK3288 hdmi eye-diagram test would fail when pixel clock is 148.5MHz,
> and single-ended test would failed when display mode is 74.25MHz.

Has anyone reviewed these changes yet?  I don't see any replies, nor
are they in David's git tree.  To me, they look mostly fine - the only
issue I get is that the final patch doesn't apply cleanly to dw_hdmi.h
since they're generated against a tree which has audio support merged.
I also see no regressions on iMX6, so I think they can be merged.

Unless anyone has any objections, I'll add these to my queue for David.

Thanks.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 2/3] drm: bridge/dw_hdmi_rockchip: improve hdmi eye-diagram test
       [not found] ` <1425894199-489-1-git-send-email-ykk@rock-chips.com>
@ 2015-03-31 16:57   ` Russell King - ARM Linux
       [not found]     ` <20150331165758.GV24899-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
  2015-04-01  2:37     ` Yakir
  0 siblings, 2 replies; 6+ messages in thread
From: Russell King - ARM Linux @ 2015-03-31 16:57 UTC (permalink / raw)
  To: Yakir Yang
  Cc: Fabio Estevam, mmind00, linux-kernel, dianders, linux-rockchip,
	dri-devel, marcheu, Andy Yan

On Mon, Mar 09, 2015 at 05:43:19PM +0800, Yakir Yang wrote:
> As for 1920x1080 display resolution, we should turn on the
> Transmitter Trailer-B.
> 
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---

BTW, one of:

 drm/rockchip: dw_hdmi-rockchip: ...
 drm/rockchip: dw_hdmi: ...
 drm: rockchip: dw_hdmi-rockchip: ...
 drm: rockchip: dw_hdmi: ...
 drm: rockchip/dw_hdmi-rockchip: ...
 drm: rockchip/dw_hdmi: ...

might be a better subject line for patches which only touch the rockchip
part of this driver.  I'd also suggest one of:

 drm/imx: dw_hdmi-imx: ...
 drm/imx: dw_hdmi: ...
 drm: imx: dw_hdmi-imx: ...
 drm: imx: dw_hdmi: ...
 drm: imx/dw_hdmi-imx: ...
 drm: imx/dw_hdmi: ...

for iMX-only patches.  It doesn't really mater which as we already have
a mixture of these formats already.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 2/3] drm: bridge/dw_hdmi_rockchip: improve hdmi eye-diagram test
       [not found]     ` <20150331165758.GV24899-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
@ 2015-04-01  0:41       ` Yakir
  0 siblings, 0 replies; 6+ messages in thread
From: Yakir @ 2015-04-01  0:41 UTC (permalink / raw)
  To: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

Hi Russell,

在 2015/4/1 0:57, Russell King - ARM Linux 写道:
> On Mon, Mar 09, 2015 at 05:43:19PM +0800, Yakir Yang wrote:
>> As for 1920x1080 display resolution, we should turn on the
>> Transmitter Trailer-B.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> ---
> BTW, one of:
>
>   drm/rockchip: dw_hdmi-rockchip: ...
>   drm/rockchip: dw_hdmi: ...
>   drm: rockchip: dw_hdmi-rockchip: ...
>   drm: rockchip: dw_hdmi: ...
>   drm: rockchip/dw_hdmi-rockchip: ...
>   drm: rockchip/dw_hdmi: ...
Okay, I choose the "drm: rockchip/dw_hdmi-rockchip: ...", improve in v4

Thanks :)
Yakir Yang
> might be a better subject line for patches which only touch the rockchip
> part of this driver.  I'd also suggest one of:
>
>   drm/imx: dw_hdmi-imx: ...
>   drm/imx: dw_hdmi: ...
>   drm: imx: dw_hdmi-imx: ...
>   drm: imx: dw_hdmi: ...
>   drm: imx/dw_hdmi-imx: ...
>   drm: imx/dw_hdmi: ...
>
> for iMX-only patches.  It doesn't really mater which as we already have
> a mixture of these formats already.
>



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 0/3] Improve eye-diagram & single-ended test for rk3288 hdmi
       [not found]   ` <20150331162548.GT24899-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
@ 2015-04-01  0:47     ` Yakir
  0 siblings, 0 replies; 6+ messages in thread
From: Yakir @ 2015-04-01  0:47 UTC (permalink / raw)
  To: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

Hi Russell,

在 2015/4/1 0:25, Russell King - ARM Linux 写道:
> On Mon, Mar 09, 2015 at 05:42:21PM +0800, Yakir Yang wrote:
>> RK3288 hdmi eye-diagram test would fail when pixel clock is 148.5MHz,
>> and single-ended test would failed when display mode is 74.25MHz.
> Has anyone reviewed these changes yet?  I don't see any replies, nor
> are they in David's git tree.  To me, they look mostly fine - the only
> issue I get is that the final patch doesn't apply cleanly to dw_hdmi.h
> since they're generated against a tree which has audio support merged.
> I also see no regressions on iMX6, so I think they can be merged.
>
> Unless anyone has any objections, I'll add these to my queue for David.
>
> Thanks.
Wooh, thanks, I will send v4 now to improve the "drm: 
dw_hdmi/dw_hdmi-rockchip".

Best regards,
Yakir Yang



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 2/3] drm: bridge/dw_hdmi_rockchip: improve hdmi eye-diagram test
  2015-03-31 16:57   ` [PATCH v3 2/3] drm: bridge/dw_hdmi_rockchip: improve hdmi eye-diagram test Russell King - ARM Linux
       [not found]     ` <20150331165758.GV24899-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
@ 2015-04-01  2:37     ` Yakir
  1 sibling, 0 replies; 6+ messages in thread
From: Yakir @ 2015-04-01  2:37 UTC (permalink / raw)
  To: Russell King - ARM Linux
  Cc: David Airlie, Philipp Zabel, djkurtz, Fabio Estevam, Shawn Guo,
	Rob Clark, Mark Yao, Daniel Vetter, dri-devel, linux-kernel,
	Andy Yan, mmind00, dianders, marcheu, linux-rockchip

Hi Russell,

在 2015/4/1 0:57, Russell King - ARM Linux 写道:
> On Mon, Mar 09, 2015 at 05:43:19PM +0800, Yakir Yang wrote:
>> As for 1920x1080 display resolution, we should turn on the
>> Transmitter Trailer-B.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> ---
> BTW, one of:
>
>   drm/rockchip: dw_hdmi-rockchip: ...
>   drm/rockchip: dw_hdmi: ...
>   drm: rockchip: dw_hdmi-rockchip: ...
>   drm: rockchip: dw_hdmi: ...
>   drm: rockchip/dw_hdmi-rockchip: ...
>   drm: rockchip/dw_hdmi: ...
>
> might be a better subject line for patches which only touch the rockchip
> part of this driver.  I'd also suggest one of:

Okay, I choose the "drm: rockchip/dw_hdmi-rockchip: ...", improve in v4

Thanks
Yakir Yang

>   drm/imx: dw_hdmi-imx: ...
>   drm/imx: dw_hdmi: ...
>   drm: imx: dw_hdmi-imx: ...
>   drm: imx: dw_hdmi: ...
>   drm: imx/dw_hdmi-imx: ...
>   drm: imx/dw_hdmi: ...
>
> for iMX-only patches.  It doesn't really mater which as we already have
> a mixture of these formats already.
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 0/3] Improve eye-diagram & single-ended test for rk3288 hdmi
  2015-03-31 16:25 ` [PATCH v3 0/3] Improve eye-diagram & single-ended test for rk3288 hdmi Russell King - ARM Linux
       [not found]   ` <20150331162548.GT24899-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
@ 2015-04-01  2:38   ` Yakir
  1 sibling, 0 replies; 6+ messages in thread
From: Yakir @ 2015-04-01  2:38 UTC (permalink / raw)
  To: Russell King - ARM Linux
  Cc: David Airlie, Philipp Zabel, djkurtz, Fabio Estevam, Shawn Guo,
	Rob Clark, Mark Yao, Daniel Vetter, dri-devel, linux-kernel,
	Andy Yan, mmind00, dianders, marcheu, linux-rockchip

Hi Russell,

在 2015/4/1 0:25, Russell King - ARM Linux 写道:
> On Mon, Mar 09, 2015 at 05:42:21PM +0800, Yakir Yang wrote:
>> RK3288 hdmi eye-diagram test would fail when pixel clock is 148.5MHz,
>> and single-ended test would failed when display mode is 74.25MHz.
> Has anyone reviewed these changes yet?  I don't see any replies, nor
> are they in David's git tree.  To me, they look mostly fine - the only
> issue I get is that the final patch doesn't apply cleanly to dw_hdmi.h
> since they're generated against a tree which has audio support merged.
> I also see no regressions on iMX6, so I think they can be merged.
>
> Unless anyone has any objections, I'll add these to my queue for David.
>
> Thanks.

Wooh, thanks, I will send v4 now to improve the "drm: 
dw_hdmi/dw_hdmi-rockchip".

Best regards,
Yakir Yang

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-04-01  2:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1425894141-360-1-git-send-email-ykk@rock-chips.com>
2015-03-31 16:25 ` [PATCH v3 0/3] Improve eye-diagram & single-ended test for rk3288 hdmi Russell King - ARM Linux
     [not found]   ` <20150331162548.GT24899-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2015-04-01  0:47     ` Yakir
2015-04-01  2:38   ` Yakir
     [not found] ` <1425894199-489-1-git-send-email-ykk@rock-chips.com>
2015-03-31 16:57   ` [PATCH v3 2/3] drm: bridge/dw_hdmi_rockchip: improve hdmi eye-diagram test Russell King - ARM Linux
     [not found]     ` <20150331165758.GV24899-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2015-04-01  0:41       ` Yakir
2015-04-01  2:37     ` Yakir

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).