From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhengxing Subject: Re: [PATCH 2/2] ASoC: rockchip: Add machine driver for rt5645/rt5650 codec Date: Sat, 18 Jul 2015 11:52:10 +0800 Message-ID: <55A9CD6A.806@rock-chips.com> References: <1436930143-31361-1-git-send-email-zhengxing@rock-chips.com> <1436930143-31361-3-git-send-email-zhengxing@rock-chips.com> <20150717181122.GT11162@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20150717181122.GT11162@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: dgreid@chromium.org, dianders@chromium.org, heiko@sntech.de, sonnyrao@chromium.org, linux-rockchip@lists.infradead.org, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org Hi Mark, On 2015=E5=B9=B407=E6=9C=8818=E6=97=A5 02:11, Mark Brown wrote: > On Wed, Jul 15, 2015 at 11:15:43AM +0800, Xing Zheng wrote: >> From: zhengxing >> >> The driver is used for rockchip board using a rt5645/rt5650. > Same comments here, mostly good but some minor issues. The other thi= ng > with both of these is that you need to have a binding document for th= em. OK. Thank you.