From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yakir Yang <ykk@rock-chips.com>
Subject: Re: [PATCH] drm/rockchip: vop: Correct enabled clocks during setup
Date: Tue, 29 Sep 2015 18:58:07 +0800
Message-ID: <560A6EBF.4080902@rock-chips.com>
References: <1443518893-28142-1-git-send-email-sjoerd.simons@collabora.co.uk>
 <560A600C.8060203@rock-chips.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <560A600C.8060203@rock-chips.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Sjoerd Simons <sjoerd.simons@collabora.co.uk>, Mark Yao <mark.yao@rock-chips.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org
List-Id: linux-rockchip.vger.kernel.org

CgpPbiAwOS8yOS8yMDE1IDA1OjU1IFBNLCBZYWtpciBZYW5nIHdyb3RlOgo+Cj4KPiBPbiAwOS8y
OS8yMDE1IDA1OjI4IFBNLCBTam9lcmQgU2ltb25zIHdyb3RlOgo+PiBXaGVuIGRvaW5nIHRoZSBp
bml0aWFsIHNldHVwIGJvdGggdGhlIGhjbGsgYW5kIHRoZSBhY2xrIG5lZWQgdG8gYmUKPj4gZW5h
YmxlZCBvdGhlcndpc2UgdGhlIGJvYXJkIHdpbGwgc2ltcGx5IGhhbmcuIFRoaXMgb25seSBvY2N1
cnMgd2hlbgo+PiBidWlsZGluZyB0aGUgdm9wIGRyaXZlciBhcyBhIG1vZHVsZSwgd2hlbiBpdHMg
YnVpbHQtaW4gdGhlIGluaXRpYWwgc2V0dXAKCkhtbS4uLiBNeSBwcmV2aW91cyB0ZXN0IHdhcyBi
dWlsdC1pbiB0aGUgdm9wIGRyaXZlciwgYW5kIGp1c3Qgbm90aWNlIHRoYXQKeW91IHNheSBwcm9i
bGVtIG9ubHkgb2NjdXJyZWQgd2hlbiBidWlsZGluZyB0aGUgdm9wIGRyaXZlciBhcyBtb2R1bGUu
ClRoYXQncyB0byBzYXkgbXkgdGVzdCB3YXMgd3JvbmcsIHNvIEkgdHJ5IHRvIGRvIHRoZSByaWdo
dCB0aGluZ3MuCgpCdXQgSSBmb3VuZCB0aGF0IHZvcCBkcml2ZXIgbW9kdWxlIGFuZCByb2NrY2hp
cGRybSBkcml2ZXIgbW9kdWxlIGluCmRlcGVuZGVuY3kgY3ljbGVzLCBoZXJlIGFyZSB0aGUgYnVp
bGQgbWVzc2FnZToKICAgICBkZXBtb2Q6IEVSUk9SOiBGb3VuZCAyIG1vZHVsZXMgaW4gZGVwZW5k
ZW5jeSBjeWNsZXMhCiAgICAgZGVwbW9kOiBFUlJPUjogQ3ljbGUgZGV0ZWN0ZWQ6IHJvY2tjaGlw
X2RybV92b3AgLT4gcm9ja2NoaXBkcm0gLT4gCnJvY2tjaGlwX2RybV92b3AKICAgICBNYWtlZmls
ZToxMDU0OiByZWNpcGUgZm9yIHRhcmdldCAnX21vZGluc3RfcG9zdCcgZmFpbGVkCgpBbmQgcGFz
dCBteSBNYWtlZmlsZToKdm9wLXkgOj0gcm9ja2NoaXBfZHJtX2Rydi5vIHJvY2tjaGlwX2RybV9m
Yi5vIHJvY2tjaGlwX2RybV9mYmRldi5vIApyb2NrY2hpcF9kcm1fZ2VtLm8Kb2JqLW0gPSByb2Nr
Y2hpcF9kcm1fdm9wLm8gdm9wLm8KClZlcnkgbGlrZSB0byBrbm93IGhvdyB5b3UgaGFuZGxlIHRo
aXMgZGVwZW5kZW5jeSBjeWNsZXMgOikKClRoYW5rcywKLSBZYWtpcgoKPj4gaGFwcGVucyB0byBy
dW4gYmVmb3JlIHRoZSBjbG9jayBmcmFtZXdvcmsgc2h1dHMgb2YgdW51c2VkIGNsb2Nrcwo+PiAo
aW5jbHVkaW5nIHRoZSBhY2xrKS4KPj4KPj4gV2hpbGUgdGhlcmUgYWxzbyBzd2l0Y2ggdG8gZG9p
bmcgcHJlcGFyZSBhbmQgZW5hYmxlIGluIG9uZSBzdGVwIHJhdGhlcgo+PiB0aGVuIHNlcGFyYXRl
IHN0ZXBzIHRvIHJlZHVjZSB0aGUgYW1vdW50IG9mIGNvZGUgcmVxdWlyZWQuCj4+Cj4+IFNpZ25l
ZC1vZmYtYnk6IFNqb2VyZCBTaW1vbnMgPHNqb2VyZC5zaW1vbnNAY29sbGFib3JhLmNvLnVrPgo+
Cj4gTG9va3MgZ29vZCBhbmQgdGVzdCBvbiBjaHJvbWVvcy0zLjE0IHRyZWUsIG5vIHByb2JsZW0s
IHNvCj4KPiBUZXN0ZWQtYnk6IFlha2lyIFlhbmcgPHlra0Byb2NrLWNoaXBzLmNvbT4KPgo+PiAt
LS0KPj4KPj4gICBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5jIHwg
MzYgCj4+ICsrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCj4+ICAgMSBmaWxlIGNoYW5nZWQs
IDE0IGluc2VydGlvbnMoKyksIDIyIGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJp
dmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AuYyAKPj4gYi9kcml2ZXJzL2dw
dS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5jCj4+IGluZGV4IDVkOGFlNWUuLjQ4NzE5
ZGYgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1f
dm9wLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3Au
Ywo+PiBAQCAtMTU3NSwzMiArMTU3NSwyNSBAQCBzdGF0aWMgaW50IHZvcF9pbml0aWFsKHN0cnVj
dCB2b3AgKnZvcCkKPj4gICAgICAgICAgIHJldHVybiBQVFJfRVJSKHZvcC0+ZGNsayk7Cj4+ICAg
ICAgIH0KPj4gICAtICAgIHJldCA9IGNsa19wcmVwYXJlKHZvcC0+aGNsayk7Cj4+IC0gICAgaWYg
KHJldCA8IDApIHsKPj4gLSAgICAgICAgZGV2X2Vycih2b3AtPmRldiwgImZhaWxlZCB0byBwcmVw
YXJlIGhjbGtcbiIpOwo+PiAtICAgICAgICByZXR1cm4gcmV0Owo+PiAtICAgIH0KPj4gLQo+PiAg
ICAgICByZXQgPSBjbGtfcHJlcGFyZSh2b3AtPmRjbGspOwo+PiAgICAgICBpZiAocmV0IDwgMCkg
ewo+PiAgICAgICAgICAgZGV2X2Vycih2b3AtPmRldiwgImZhaWxlZCB0byBwcmVwYXJlIGRjbGtc
biIpOwo+PiAtICAgICAgICBnb3RvIGVycl91bnByZXBhcmVfaGNsazsKPj4gKyAgICAgICAgcmV0
dXJuIHJldDsKPj4gICAgICAgfQo+PiAgIC0gICAgcmV0ID0gY2xrX3ByZXBhcmUodm9wLT5hY2xr
KTsKPj4gKyAgICAvKiBFbmFibGUgYm90aCB0aGUgaGNsayBhbmQgYWNsayB0byBzZXR1cCB0aGUg
dm9wICovCj4+ICsgICAgcmV0ID0gY2xrX3ByZXBhcmVfZW5hYmxlKHZvcC0+aGNsayk7Cj4+ICAg
ICAgIGlmIChyZXQgPCAwKSB7Cj4+IC0gICAgICAgIGRldl9lcnIodm9wLT5kZXYsICJmYWlsZWQg
dG8gcHJlcGFyZSBhY2xrXG4iKTsKPj4gKyAgICAgICAgZGV2X2Vycih2b3AtPmRldiwgImZhaWxl
ZCB0byBwcmVwYXJlL2VuYWJsZSBoY2xrXG4iKTsKPj4gICAgICAgICAgIGdvdG8gZXJyX3VucHJl
cGFyZV9kY2xrOwo+PiAgICAgICB9Cj4+ICAgLSAgICAvKgo+PiAtICAgICAqIGVuYWJsZSBoY2xr
LCBzbyB0aGF0IHdlIGNhbiBjb25maWcgdm9wIHJlZ2lzdGVyLgo+PiAtICAgICAqLwo+PiAtICAg
IHJldCA9IGNsa19lbmFibGUodm9wLT5oY2xrKTsKPj4gKyAgICByZXQgPSBjbGtfcHJlcGFyZV9l
bmFibGUodm9wLT5hY2xrKTsKPj4gICAgICAgaWYgKHJldCA8IDApIHsKPj4gLSAgICAgICAgZGV2
X2Vycih2b3AtPmRldiwgImZhaWxlZCB0byBwcmVwYXJlIGFjbGtcbiIpOwo+PiAtICAgICAgICBn
b3RvIGVycl91bnByZXBhcmVfYWNsazsKPj4gKyAgICAgICAgZGV2X2Vycih2b3AtPmRldiwgImZh
aWxlZCB0byBwcmVwYXJlL2VuYWJsZSBhY2xrXG4iKTsKPj4gKyAgICAgICAgZ290byBlcnJfZGlz
YWJsZV9oY2xrOwo+PiAgICAgICB9Cj4+ICsKPj4gICAgICAgLyoKPj4gICAgICAgICogZG8gaGNs
a19yZXNldCwgcmVzZXQgYWxsIHZvcCByZWdpc3RlcnMuCj4+ICAgICAgICAqLwo+PiBAQCAtMTYw
OCw3ICsxNjAxLDcgQEAgc3RhdGljIGludCB2b3BfaW5pdGlhbChzdHJ1Y3Qgdm9wICp2b3ApCj4+
ICAgICAgIGlmIChJU19FUlIoYWhiX3JzdCkpIHsKPj4gICAgICAgICAgIGRldl9lcnIodm9wLT5k
ZXYsICJmYWlsZWQgdG8gZ2V0IGFoYiByZXNldFxuIik7Cj4+ICAgICAgICAgICByZXQgPSBQVFJf
RVJSKGFoYl9yc3QpOwo+PiAtICAgICAgICBnb3RvIGVycl9kaXNhYmxlX2hjbGs7Cj4+ICsgICAg
ICAgIGdvdG8gZXJyX2Rpc2FibGVfYWNsazsKPj4gICAgICAgfQo+PiAgICAgICByZXNldF9jb250
cm9sX2Fzc2VydChhaGJfcnN0KTsKPj4gICAgICAgdXNsZWVwX3JhbmdlKDEwLCAyMCk7Cj4+IEBA
IC0xNjM0LDI2ICsxNjI3LDI1IEBAIHN0YXRpYyBpbnQgdm9wX2luaXRpYWwoc3RydWN0IHZvcCAq
dm9wKQo+PiAgICAgICBpZiAoSVNfRVJSKHZvcC0+ZGNsa19yc3QpKSB7Cj4+ICAgICAgICAgICBk
ZXZfZXJyKHZvcC0+ZGV2LCAiZmFpbGVkIHRvIGdldCBkY2xrIHJlc2V0XG4iKTsKPj4gICAgICAg
ICAgIHJldCA9IFBUUl9FUlIodm9wLT5kY2xrX3JzdCk7Cj4+IC0gICAgICAgIGdvdG8gZXJyX3Vu
cHJlcGFyZV9hY2xrOwo+PiArICAgICAgICBnb3RvIGVycl9kaXNhYmxlX2FjbGs7Cj4+ICAgICAg
IH0KPj4gICAgICAgcmVzZXRfY29udHJvbF9hc3NlcnQodm9wLT5kY2xrX3JzdCk7Cj4+ICAgICAg
IHVzbGVlcF9yYW5nZSgxMCwgMjApOwo+PiAgICAgICByZXNldF9jb250cm9sX2RlYXNzZXJ0KHZv
cC0+ZGNsa19yc3QpOwo+PiAgICAgICAgIGNsa19kaXNhYmxlKHZvcC0+aGNsayk7Cj4+ICsgICAg
Y2xrX2Rpc2FibGUodm9wLT5hY2xrKTsKPj4gICAgICAgICB2b3AtPmlzX2VuYWJsZWQgPSBmYWxz
ZTsKPj4gICAgICAgICByZXR1cm4gMDsKPj4gICArZXJyX2Rpc2FibGVfYWNsazoKPj4gKyAgICBj
bGtfZGlzYWJsZV91bnByZXBhcmUodm9wLT5hY2xrKTsKPj4gICBlcnJfZGlzYWJsZV9oY2xrOgo+
PiAtICAgIGNsa19kaXNhYmxlKHZvcC0+aGNsayk7Cj4+IC1lcnJfdW5wcmVwYXJlX2FjbGs6Cj4+
IC0gICAgY2xrX3VucHJlcGFyZSh2b3AtPmFjbGspOwo+PiArICAgIGNsa19kaXNhYmxlX3VucHJl
cGFyZSh2b3AtPmhjbGspOwo+PiAgIGVycl91bnByZXBhcmVfZGNsazoKPj4gICAgICAgY2xrX3Vu
cHJlcGFyZSh2b3AtPmRjbGspOwo+PiAtZXJyX3VucHJlcGFyZV9oY2xrOgo+PiAtICAgIGNsa191
bnByZXBhcmUodm9wLT5oY2xrKTsKPj4gICAgICAgcmV0dXJuIHJldDsKPj4gICB9Cj4KCgpfX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp
bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy
ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=