* [PATCH 1/2] clocksource/drivers/rockchip: Fix bad NO_IRQ usage
[not found] <560BB452.1020000@linaro.org>
@ 2015-09-30 10:08 ` Daniel Lezcano
2015-09-30 10:17 ` Caesar Wang
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Lezcano @ 2015-09-30 10:08 UTC (permalink / raw)
To: tglx
Cc: linux, Heiko Stuebner, open list:CLOCKSOURCE, CLOC...,
moderated list:ARM/Rockchip SoC..., open list:ARM/Rockchip SoC...
The current code assumes the 'irq_of_parse_and_map' will return NO_IRQ in case
of failure. Unfortunately, the NO_IRQ is not consistent across the different
architectures and we must not rely on it.
NO_IRQ is equal to '-1' on ARM and 'irq_of_parse_and_map' returns '0' in case
of an error. Hence, the latter won't be detected and will lead to a crash.
Fix this by just checking 'irq' is different from zero.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/clocksource/rockchip_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/rockchip_timer.c b/drivers/clocksource/rockchip_timer.c
index bb2c2b0..d3c1742 100644
--- a/drivers/clocksource/rockchip_timer.c
+++ b/drivers/clocksource/rockchip_timer.c
@@ -148,7 +148,7 @@ static void __init rk_timer_init(struct device_node *np)
bc_timer.freq = clk_get_rate(timer_clk);
irq = irq_of_parse_and_map(np, 0);
- if (irq == NO_IRQ) {
+ if (!irq) {
pr_err("Failed to map interrupts for '%s'\n", TIMER_NAME);
return;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] clocksource/drivers/rockchip: Fix bad NO_IRQ usage
2015-09-30 10:08 ` [PATCH 1/2] clocksource/drivers/rockchip: Fix bad NO_IRQ usage Daniel Lezcano
@ 2015-09-30 10:17 ` Caesar Wang
0 siblings, 0 replies; 2+ messages in thread
From: Caesar Wang @ 2015-09-30 10:17 UTC (permalink / raw)
To: Daniel Lezcano, tglx
Cc: open list:ARM/Rockchip SoC..., linux, Heiko Stuebner,
moderated list:ARM/Rockchip SoC...,
open list:CLOCKSOURCE, CLOC...
在 2015年09月30日 18:08, Daniel Lezcano 写道:
> The current code assumes the 'irq_of_parse_and_map' will return NO_IRQ in case
> of failure. Unfortunately, the NO_IRQ is not consistent across the different
> architectures and we must not rely on it.
>
> NO_IRQ is equal to '-1' on ARM and 'irq_of_parse_and_map' returns '0' in case
> of an error. Hence, the latter won't be detected and will lead to a crash.
>
> Fix this by just checking 'irq' is different from zero.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
As Per- discuss, you can free add my test tag.
Tested-by: Caesar Wang <wxt@rock-chips.com>
> ---
> drivers/clocksource/rockchip_timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/rockchip_timer.c b/drivers/clocksource/rockchip_timer.c
> index bb2c2b0..d3c1742 100644
> --- a/drivers/clocksource/rockchip_timer.c
> +++ b/drivers/clocksource/rockchip_timer.c
> @@ -148,7 +148,7 @@ static void __init rk_timer_init(struct device_node *np)
> bc_timer.freq = clk_get_rate(timer_clk);
>
> irq = irq_of_parse_and_map(np, 0);
> - if (irq == NO_IRQ) {
> + if (!irq) {
> pr_err("Failed to map interrupts for '%s'\n", TIMER_NAME);
> return;
> }
--
Thanks,
Caesar
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-30 10:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <560BB452.1020000@linaro.org>
2015-09-30 10:08 ` [PATCH 1/2] clocksource/drivers/rockchip: Fix bad NO_IRQ usage Daniel Lezcano
2015-09-30 10:17 ` Caesar Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).