From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Lin Subject: Re: [PATCH v6 09/10] snd: dmaengine-pcm: add snd_dmaengine_pcm_get_caps interface Date: Thu, 15 Oct 2015 14:50:32 +0800 Message-ID: <561F4CB8.1000500@rock-chips.com> References: <1444872865-2169-1-git-send-email-shawn.lin@rock-chips.com> <1444872998-2548-1-git-send-email-shawn.lin@rock-chips.com> <20151015040500.GB27370@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151015040500.GB27370@localhost> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vinod Koul Cc: shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org, Heiko Stuebner , Jaroslav Kysela , Takashi Iwai , Mark Brown , Lars-Peter Clausen , Doug Anderson , Olof Johansson , Sonny Rao , Addy Ke , Boojin Kim , dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rockchip.vger.kernel.org On 2015/10/15 12:05, Vinod Koul wrote: > On Thu, Oct 15, 2015 at 09:36:38AM +0800, Shawn Lin wrote: >> +int snd_dmaengine_pcm_get_caps(struct device *dev, struct dma_slave_caps *caps) >> +{ >> + struct snd_soc_platform *platform; >> + struct dmaengine_pcm *pcm; >> + int ret = -ENODEV; >> + >> + platform = snd_soc_lookup_platform(dev); >> + if (!platform) >> + return ret; >> + >> + pcm = soc_platform_to_pcm(platform); >> + >> + if (pcm->chan) >> + ret = dma_get_slave_caps(pcm->chan[0], caps); >> + >> + return ret; >> +} >> +EXPORT_SYMBOL_GPL(snd_dmaengine_pcm_get_caps); > > I don't see the need of this wrapper if you are not going to use this inside > common code.. Why not read this in driver, anyway you setting taht up in > next patch okay, I will read it in driver directly. Thanks. > -- Best Regards Shawn Lin -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html