linux-rockchip.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Yakir Yang <ykk@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	linux-kernel@vger.kernel.org, Andrzej Hajda <a.hajda@samsung.com>,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
	el.org@null.null, Russell King <linux@arm.linux.org.uk>,
	linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kern,
	Kishon Vijay Abraham I <kishon@ti.com>,
	javier@osg.samsung.com, Kukjin Kim <kgene@kernel.org>,
	robherring2@gmail.com, Thierry Reding <treding@nvidia.com>,
	devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Rob Herring <robh+dt@kernel.org>,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	Jingoo Han <jingoohan1@gmail.com>,
	emil.l.velikov@gmail.com, dianders@chromium.org,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Kumar Gala <galak@codeaurora.org>,
	ajaynumb@gmail.com, Andy
Subject: Re: [PATCH v8 06/17] dt-bindings: add document for analogix display port driver
Date: Thu, 29 Oct 2015 16:56:34 +0800	[thread overview]
Message-ID: <5631DF42.9050402@rock-chips.com> (raw)
In-Reply-To: <1689999.2MgYqJktlx@phil>


[-- Attachment #1.1: Type: text/plain, Size: 4280 bytes --]


On 10/29/2015 04:40 PM, Heiko Stuebner wrote:
> Am Donnerstag, 29. Oktober 2015, 09:12:21 schrieb Yakir Yang:
>> Hi Heiko,
>>
>> On 10/29/2015 04:02 AM, Heiko Stuebner wrote:
>>> Hi Yakir,
>>>
>>> Am Mittwoch, 28. Oktober 2015, 16:26:33 schrieb Yakir Yang:
>>>> diff --git a/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt b/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt
>>>> index 7a3a9cd..9905081 100644
>>>> --- a/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt
>>>> +++ b/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt
>>>> @@ -31,45 +31,31 @@ Required properties for dp-controller:
>>>>    		from general PHY binding: the phandle for the PHY device.
>>>>    	-phy-names:
>>>>    		from general PHY binding: Should be "dp".
>>>> -	-samsung,color-space:
>>>> -		input video data format.
>>>> -			COLOR_RGB = 0, COLOR_YCBCR422 = 1, COLOR_YCBCR444 = 2
>>>> -	-samsung,dynamic-range:
>>>> -		dynamic range for input video data.
>>>> -			VESA = 0, CEA = 1
>>>> -	-samsung,ycbcr-coeff:
>>>> -		YCbCr co-efficients for input video.
>>>> -			COLOR_YCBCR601 = 0, COLOR_YCBCR709 = 1
>>>> -	-samsung,color-depth:
>>>> -		number of bits per colour component.
>>>> -			COLOR_6 = 0, COLOR_8 = 1, COLOR_10 = 2, COLOR_12 = 3
>>>> -	-samsung,link-rate:
>>>> -		link rate supported by the panel.
>>>> -			LINK_RATE_1_62GBPS = 0x6, LINK_RATE_2_70GBPS = 0x0A
>>>> -	-samsung,lane-count:
>>>> -		number of lanes supported by the panel.
>>>> -			LANE_COUNT1 = 1, LANE_COUNT2 = 2, LANE_COUNT4 = 4
>>>> -	- display-timings: timings for the connected panel as described by
>>>> -		Documentation/devicetree/bindings/video/display-timing.txt
>>> 											^^ display/display-timings.txt
>>> otherwise this patch does not apply.
>> I thought I have deleted this old path of "display-timing.txt", and
>> changed it to
>>
>> -		Documentation/devicetree/bindings/video/display-timing.txt
> in the changes I got from Rob Hering's dt-branch [0] the path in the file
> is already display/display-timing.txt so applying a change with video/...
> in it fails. Anyway, as this will probably only make it in after the merge-
> window, we can see how this ends up before anyway :-) .

Agree

>
>> +		Documentation/devicetree/bindings/display/panel/display-timing.txt
>>
>> And the real path of "display-timing.txt" in linux-next [tag 20151022]
>> do under
>> the "display/panel/", those change should be right.
>
> Heiko
>
> [0] https://git.kernel.org/cgit/linux/kernel/git/robh/linux.git/commit/?h=dt/next&id=efdbd7345f8836f7495f3ac6ee237d86cb3bb6b0

Found some conflicting things in that commit:

He move the display-timing.txt from "video/" to "display/panel"
diff --git a/Documentation/devicetree/bindings/video/display-timing.txt 
b/Documentation/devicetree/bindings/display/panel/display-timing.txt
index e1d4a0b..e1d4a0b 100644 --- 
a/Documentation/devicetree/bindings/video/display-timing.txt 
<https://git.kernel.org/cgit/linux/kernel/git/robh/linux.git/tree/Documentation/devicetree/bindings/video/display-timing.txt?h=dt/next&id=9ffecb10283508260936b96022d4ee43a7798b4c> 
+++ b/Documentation/devicetree/bindings/display/panel/display-timing.txt 
<https://git.kernel.org/cgit/linux/kernel/git/robh/linux.git/tree/Documentation/devicetree/bindings/display/panel/display-timing.txt?h=dt/next&id=efdbd7345f8836f7495f3ac6ee237d86cb3bb6b0> 
But didn't give the real path to other documents
--- a/Documentation/devicetree/bindings/video/fsl,imx-fb.txt 
<https://git.kernel.org/cgit/linux/kernel/git/robh/linux.git/tree/Documentation/devicetree/bindings/video/fsl,imx-fb.txt?h=dt/next&id=9ffecb10283508260936b96022d4ee43a7798b4c> 
+++ b/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt 
<https://git.kernel.org/cgit/linux/kernel/git/robh/linux.git/tree/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt?h=dt/next&id=efdbd7345f8836f7495f3ac6ee237d86cb3bb6b0>
@@ -9,7 +9,7 @@ Required properties:
Required nodes:
- display: Phandle to a display node as described in
- Documentation/devicetree/bindings/video/display-timing.txt
+ Documentation/devicetree/bindings/display/display-timing.txt
Additional, the display node has to define properties:
- bits-per-pixel: Bits per pixel
- fsl,pcr: LCDC PCR value
Thanks, - Yakir
>
>
>

[-- Attachment #1.2: Type: text/html, Size: 12238 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-10-29  8:56 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28  8:15 [PATCH v8 0/17] Add Analogix Core Display Port Driver Yakir Yang
2015-10-28  8:19 ` [PATCH v8 01/17] drm: exynos: dp: convert to drm bridge mode Yakir Yang
2016-03-22 22:22   ` Inki Dae
2015-10-28  8:25 ` [PATCH v8 05/17] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & dynamic_range Yakir Yang
2015-10-28  8:27 ` [PATCH v8 07/17] ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp driver Yakir Yang
2015-10-28  8:27 ` [PATCH v8 08/17] drm: rockchip: dp: add rockchip platform dp driver Yakir Yang
2015-11-27  8:41   ` Heiko Stübner
2015-10-28  8:28 ` [PATCH v8 09/17] dt-bindings: add document for rockchip variant of analogix_dp Yakir Yang
2015-10-30 16:46   ` Rob Herring
     [not found]     ` <CAL_JsqLxkz43gj-O+r0LURg0_41SrDB7g8EAHwjxbytoUPijhA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-31  3:15       ` Yakir Yang
2015-10-28  8:30 ` [PATCH v8 10/17] phy: Add driver for rockchip Display Port PHY Yakir Yang
2015-10-28 20:36   ` Heiko Stuebner
2015-10-29  1:14     ` Yakir Yang
     [not found]   ` <1446021033-11537-1-git-send-email-ykk-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-11-11 23:23     ` Heiko Stuebner
2015-11-12  2:36       ` Yakir Yang
     [not found]         ` <5643FB43.6090408-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-11-12  9:21           ` Heiko Stuebner
2015-10-28  8:31 ` [PATCH v8 11/17] dt-bindings: add document for rockchip dp phy Yakir Yang
2015-10-30 16:42   ` Rob Herring
     [not found]     ` <CAL_JsqL=pL8SXLEzhbJHS_djFSh+Ctky0igzagZ6E0M9Q_TFuA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-31  3:13       ` Yakir Yang
2015-10-28  8:55 ` [PATCH v8 13/17] drm: bridge: analogix/dp: add some rk3288 special registers setting Yakir Yang
2015-10-28  8:56 ` [PATCH v8 14/17] drm: bridge: analogix/dp: add max link rate and lane count limit for RK3288 Yakir Yang
2015-11-27 13:32   ` Heiko Stübner
2015-12-02 10:46     ` Yakir Yang
2015-10-28  9:13 ` [PATCH v8 17/17] drm: bridge: analogix/dp: add edid modes parse in get_modes method Yakir Yang
2015-10-29  1:58 ` [PATCH v9 10/17] phy: Add driver for rockchip Display Port PHY Yakir Yang
2015-11-03  4:38   ` Brian Norris
2015-11-04  0:48     ` Yakir Yang
2015-11-04  1:13       ` Brian Norris
2015-11-05 23:45         ` Brian Norris
2015-11-17 12:58           ` Yakir Yang
     [not found] ` <1446020143-32645-1-git-send-email-ykk-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-10-28  8:21   ` [PATCH v8 02/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory Yakir Yang
2015-11-26 17:30     ` Heiko Stübner
2015-11-27  1:20       ` Yakir Yang
     [not found]         ` <5657AFEC.60004-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-11-27  8:42           ` Heiko Stübner
2015-10-28  8:23   ` [PATCH v8 03/17] drm: bridge: analogix/dp: fix some obvious code style Yakir Yang
2015-10-28  8:24   ` [PATCH v8 04/17] drm: bridge: analogix/dp: remove duplicate configuration of link rate and link count Yakir Yang
2015-10-28  8:26   ` [PATCH v8 06/17] dt-bindings: add document for analogix display port driver Yakir Yang
     [not found]     ` <1446020793-10532-1-git-send-email-ykk-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-10-28 20:02       ` Heiko Stuebner
2015-10-29  1:12         ` Yakir Yang
     [not found]           ` <56317275.90508-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-10-29  8:40             ` Heiko Stuebner
2015-10-29  8:56               ` Yakir Yang [this message]
2015-10-28  8:52   ` [PATCH v8 12/17] drm: rockchip: vop: add bpc and color mode setting Yakir Yang
2015-10-28  9:12   ` [PATCH v8 16/17] drm: bridge: analogix/dp: move hpd detect to connector detect function Yakir Yang
2015-10-29 17:49   ` [PATCH v8 0/17] Add Analogix Core Display Port Driver Heiko Stuebner
2015-10-30  1:05     ` Yakir Yang
2015-10-31  6:30   ` [PATCH v9 09/17] dt-bindings: add document for rockchip variant of analogix_dp Yakir Yang
2015-10-31  6:40     ` Yakir Yang
2015-11-17 13:09   ` [PATCH v10 10/17] phy: Add driver for rockchip Display Port PHY Yakir Yang
2015-10-30  1:09 ` [PATCH v9 15/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed Yakir Yang
2015-11-11 23:10   ` Rob Herring
2015-11-12  1:27     ` Yakir Yang
2015-11-12 23:38       ` Rob Herring
2015-11-13  7:31         ` Yakir Yang
2015-10-31  6:42 ` [PATCH v10 09/17] dt-bindings: add document for rockchip variant of analogix_dp Yakir Yang
2015-10-31 18:37   ` Rob Herring
2015-11-02  0:41     ` Yakir Yang
2015-11-17 13:31 ` [PATCH v8 0/17] Add Analogix Core Display Port Driver Yakir Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5631DF42.9050402@rock-chips.com \
    --to=ykk@rock-chips.com \
    --cc=a.hajda@samsung.com \
    --cc=ajaynumb@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=el.org@null.null \
    --cc=emil.l.velikov@gmail.com \
    --cc=galak@codeaurora.org \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=heiko@sntech.de \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=javier@osg.samsung.com \
    --cc=jingoohan1@gmail.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=kishon@ti.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kern \
    --cc=linux@arm.linux.org.uk \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=robherring2@gmail.com \
    --cc=sw0312.kim@samsung.com \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).