public inbox for linux-rockchip@lists.infradead.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: Andy Yan <andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/3] arm64: dts: rockchip: add sdmmc support for px5-evb
Date: Fri, 14 Oct 2016 19:29:08 +0200	[thread overview]
Message-ID: <5652149.PmckHYSsLx@phil> (raw)
In-Reply-To: <1474516939-22001-2-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

Am Donnerstag, 22. September 2016, 12:02:18 CEST schrieb Shawn Lin:
> px5-evb has one sdmmc slot, so we could support sdmmc.
> 
> Signed-off-by: Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

applied for 4.10 with the changes described below. Please keep them in mind 
for future patches :-) .


>  arch/arm64/boot/dts/rockchip/rk3368-px5-evb.dts | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368-px5-evb.dts
> b/arch/arm64/boot/dts/rockchip/rk3368-px5-evb.dts index 3e0b522..f59049b
> 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368-px5-evb.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3368-px5-evb.dts
> @@ -98,6 +98,25 @@
>  	vqmmc-supply = <&vcc18_flash>;
>  };
> 
> +&sdmmc {

moved sdmmc node to its alphabetical correct position

> +	status = "okay";
> +	bus-width = <4>;
> +	cap-mmc-highspeed;
> +	cap-sd-highspeed;
> +	card-detect-delay = <200>;
> +	rockchip,default-sample-phase = <90>;
> +	num-slots = <1>;

restored alphabetical ordering

> +	no-emmc;
> +	no-sdio;
> +	sd-uhs-sdr12;
> +	sd-uhs-sdr25;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&sdmmc_clk>, <&sdmmc_cmd>, <&sdmmc_bus4>, <&sdmmc_cd>;
> +	vmmc-supply = <&vcc_sd>;
> +	vqmmc-supply = <&vccio_sd>;
> +};
> +
> +

removed 2nd blank line

>  &i2c0 {
>  	status = "okay";


Heiko

  parent reply	other threads:[~2016-10-14 17:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-22  4:02 [PATCH 1/3] arm64: dts: rockchip: Add more properties for emmc on px5-evb Shawn Lin
     [not found] ` <1474516939-22001-1-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-09-22  4:02   ` [PATCH 2/3] arm64: dts: rockchip: add sdmmc support for px5-evb Shawn Lin
     [not found]     ` <1474516939-22001-2-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-10-14 17:29       ` Heiko Stuebner [this message]
2016-09-22  4:02   ` [PATCH 3/3] arm64: dts: rockchip: remove always-on and boot-on from vcc_sd Shawn Lin
     [not found]     ` <1474516939-22001-3-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-10-09 13:42       ` Shawn Lin
2016-10-14 17:18       ` Heiko Stuebner
2016-10-14 17:20   ` [PATCH 1/3] arm64: dts: rockchip: Add more properties for emmc on px5-evb Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5652149.PmckHYSsLx@phil \
    --to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
    --cc=andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox