linux-rockchip.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>
To: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
	mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org
Cc: hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	arnd-r2nGTMty4D4@public.gmane.org,
	sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v3 7/8] clk: rockchip: fix usbphy-related clocks
Date: Sun, 20 Dec 2015 14:39:15 +0530	[thread overview]
Message-ID: <5676703B.90300@ti.com> (raw)
In-Reply-To: <80597401.Y78Rj8FshV@diego>

Hi,

On Saturday 19 December 2015 10:51 PM, Heiko Stübner wrote:
> Hi Kishon,
> 
> Am Dienstag, 15. Dezember 2015, 16:22:32 schrieb Kishon Vijay Abraham I:
>> On Friday 20 November 2015 02:52 AM, Heiko Stuebner wrote:
>>> The otgphy clocks really only drive the phy blocks. These in turn
>>> contain plls that then generate the 480m clocks the clock controller
>>> uses to supply some other clocks like uart0, gpu or the video-codec.
>>>
>>> So fix this structure to actually respect that hirarchy and removed
>>> that usb480m fixed-rate clock working as a placeholder till now, as
>>> this wouldn't even work if the supplying phy gets turned off while
>>> its pll-output gets used elsewhere.
>>>
>>> Signed-off-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
>>> Reviewed-by: Douglas Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>>
>> I saw you've given your Acked-by in a previous version of this patch.
>> Do you want me to take this in linux-phy tree?
> 
> from my POV, this series should probably go through your tree in one go, as 
> this patch depends on the newly exposed clocks from the previous patch. So to 
> keep bisectability, it should most likely stay together.

I agree. But I can't take another subsystem patch without getting a clear nod
from the maintainer. I'll wait till tomorrow for Turquette to give his Acked-by.

Thanks
Kishon

  reply	other threads:[~2015-12-20  9:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19 21:22 [PATCH v3 0/8] phy: rockchip-usb: correct pll handling and usb-uart Heiko Stuebner
2015-11-19 21:22 ` [PATCH v3 1/8] phy: rockchip-usb: fix clock get-put mismatch Heiko Stuebner
2015-11-19 21:22 ` [PATCH v3 2/8] phy: rockchip-usb: introduce a common data-struct for the device Heiko Stuebner
2015-11-20  0:38   ` Doug Anderson
2015-11-19 21:22 ` [PATCH v3 3/8] phy: rockchip-usb: move per-phy init into a separate function Heiko Stuebner
     [not found] ` <1447968149-10979-1-git-send-email-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2015-11-19 21:22   ` [PATCH v3 4/8] phy: rockchip-usb: add compatible values for rk3066a and rk3188 Heiko Stuebner
2015-11-20  0:32     ` Doug Anderson
2015-11-22 19:49       ` Heiko Stuebner
2015-11-25 17:04         ` Doug Anderson
2015-11-25 18:24           ` Heiko Stübner
2015-11-25 18:35             ` Doug Anderson
2015-11-19 21:22   ` [PATCH v3 5/8] phy: rockchip-usb: expose the phy-internal PLLs Heiko Stuebner
     [not found]     ` <1447968149-10979-6-git-send-email-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2015-12-15 10:53       ` Kishon Vijay Abraham I
2015-12-21 20:00         ` Michael Turquette
2015-11-19 21:22   ` [PATCH v3 8/8] phy: rockchip-usb: add handler for usb-uart functionality Heiko Stuebner
2015-11-19 21:22 ` [PATCH v3 6/8] ARM: dts: rockchip: add clock-cells for usb phy nodes Heiko Stuebner
2016-01-25 14:06   ` Heiko Stübner
2015-11-19 21:22 ` [PATCH v3 7/8] clk: rockchip: fix usbphy-related clocks Heiko Stuebner
     [not found]   ` <1447968149-10979-8-git-send-email-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2015-12-15 10:52     ` Kishon Vijay Abraham I
2015-12-19 17:21       ` Heiko Stübner
2015-12-20  9:09         ` Kishon Vijay Abraham I [this message]
2016-01-25 14:04   ` Heiko Stübner
2015-12-02 15:32 ` [PATCH v3 0/8] phy: rockchip-usb: correct pll handling and usb-uart Heiko Stübner
2015-12-03  6:05   ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5676703B.90300@ti.com \
    --to=kishon-l0cymroini0@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).