From: "Heiko Stübner" <heiko@sntech.de>
To: hugo@ahdrone.com, Linus Walleij <linusw@kernel.org>
Cc: linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Dmitry Yashin <dmt.yashin@gmail.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Jonas Karlman <jonas@kwiboo.se>
Subject: Re: [PATCH 0/3] pinctrl: rockchip: add support for RK3308B SoC
Date: Wed, 29 Jul 2026 12:22:19 +0200 [thread overview]
Message-ID: <5689456.tWeucmBOSa@diego> (raw)
In-Reply-To: <CAD++jL=ASH7jx8YOL2Z5i4K8w4RQd4eWKEGtY1KRBwM-JDaw-g@mail.gmail.com>
Am Samstag, 25. Juli 2026, 00:13:39 Mitteleuropäische Sommerzeit schrieb Linus Walleij:
> On Fri, Jul 17, 2026 at 9:59 AM Hugo VALTIER <hugo@ahdrone.com> wrote:
>
> > The RK3308B is a silicon revision of the RK3308 with a different iomux
> > register layout: several pins (GPIO2_A2, GPIO2_A3, GPIO2_C0, GPIO3_B2,
> > GPIO3_B3) gained 3-bit mux fields in new GRF registers that override
> > the original 2-bit fields. I believe the bootloader enables the new
> > registers via the sel_src_ctrl bits, after which the kernel's writes
> > to the old iomux registers are silently ignored. Whatever the exact
> > mechanism, on RK3308B boards (e.g. current Radxa ROCK Pi S revisions)
> > SPI1, I2C3 and other peripherals on the affected pins are
> > non-functional without this series.
> >
> > This is a continuation of Dmitry Yashin's series from 2024 [1], which
> > was never resubmitted after review and got dropped. Following the
>
> No reactions for a week so patches applied.
For the record, looks good.
Too late for the git history, but nevertheless
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Heiko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
prev parent reply other threads:[~2026-07-29 10:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 7:59 [PATCH 0/3] pinctrl: rockchip: add support for RK3308B SoC Hugo VALTIER
2026-07-17 7:59 ` [PATCH 1/3] pinctrl: rockchip: constify mux recalced and route data arrays Hugo VALTIER
2026-07-17 7:59 ` [PATCH 2/3] pinctrl: rockchip: extract iomux_recalced_routes_init() Hugo VALTIER
2026-07-17 7:59 ` [PATCH 3/3] pinctrl: rockchip: add support for RK3308B SoC Hugo VALTIER
2026-07-21 14:48 ` Dmitry Yashin
2026-07-24 22:13 ` [PATCH 0/3] " Linus Walleij
2026-07-29 10:22 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5689456.tWeucmBOSa@diego \
--to=heiko@sntech.de \
--cc=dmt.yashin@gmail.com \
--cc=hugo@ahdrone.com \
--cc=jonas@kwiboo.se \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=luca.ceresoli@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox