Re: [PATCH] drm/rockchip/dsi: fix handling mipi_dsi_pixel_format_to_bpp result

From: Chris Zhong <zyw@rock-chips.com>
To: Andrzej Hajda <a.hajda@samsung.com>, Mark Yao <mark.yao@rock-chips.com>
Cc: "open list:ARM/Rockchip SoC support"
	<linux-rockchip@lists.infradead.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	"open list:DRM DRIVERS FOR ROCKCHIP"
	<dri-devel@lists.freedesktop.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] drm/rockchip/dsi: fix handling mipi_dsi_pixel_format_to_bpp result
Date: Fri, 15 Jan 2016 09:04:12 +0800	[thread overview]
Message-ID: <5698458C.3070901@rock-chips.com> (raw)
In-Reply-To: <1452761942-23864-1-git-send-email-a.hajda@samsung.com>

Hi Andrzej

On 01/14/2016 04:59 PM, Andrzej Hajda wrote:
> The function can return negative value so it should be assigned to signed
> variable.
>
> The problem has been detected using patch
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci.
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
>   drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
> index 7bfe243..f8f8f29 100644
> --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
> @@ -461,10 +461,11 @@ static int dw_mipi_dsi_phy_init(struct dw_mipi_dsi *dsi)
>   
>   static int dw_mipi_dsi_get_lane_bps(struct dw_mipi_dsi *dsi)
>   {
> -	unsigned int bpp, i, pre;
> +	unsigned int i, pre;
>   	unsigned long mpclk, pllref, tmp;
>   	unsigned int m = 1, n = 1, target_mbps = 1000;
>   	unsigned int max_mbps = dptdin_map[ARRAY_SIZE(dptdin_map) - 1].max_mbps;
> +	int bpp;
>   
>   	bpp = mipi_dsi_pixel_format_to_bpp(dsi->format);
>   	if (bpp < 0) {
Reviewed-by: Chris Zhong <zyw@rock-chips.com>

Thanks

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel