Re: [Bug] usb: dwc2: Add functions to set and clear force mode

From: Caesar Wang <caesar.upstream-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: John Youn <John.Youn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
Cc: "Caesar Wang"
	<caesar.upstream-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Huang, Tao" <huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	"Heiko Stuebner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
	"Doug Anderson"
	<dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	"Felipe Balbi" <balbi-l0cyMroinI0@public.gmane.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	吴良峰 <wulf-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Subject: Re: [Bug] usb: dwc2: Add functions to set and clear force mode
Date: Wed, 3 Feb 2016 08:35:57 +0800	[thread overview]
Message-ID: <56B14B6D.1060808@gmail.com> (raw)
In-Reply-To: <2B3535C5ECE8B5419E3ECBE30077290901DC431FDB-Yu2iAY70zvrYN67daEjeMPufCSb+aD3WLzEdoUbNIic@public.gmane.org>

Hi John,

在 2016年02月03日 08:03, John Youn 写道:
> On 2/1/2016 6:53 PM, Caesar Wang wrote:
>> John,
>>
>> I will suggest the msleep(25) delay should  put in
>> 'dwc2_force_dr_mode()' instead of the 'dwc2_clear_force_mode()'
>>
> Hi Caesar,
>
> Are you saying that just msleep(25) in that function like this solves
> your issue?
>
> diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c
> index 39a0fa8..e8a9688 100644
> --- a/drivers/usb/dwc2/core.c
> +++ b/drivers/usb/dwc2/core.c
> @@ -625,6 +625,8 @@ void dwc2_force_dr_mode(struct dwc2_hsotg *hsotg)
>                           __func__, hsotg->dr_mode);
>                  break;
>          }
> +
> +       msleep(25);

Yep, that will solve this issue.

>   }
>   
>
>
> Although that is still not ideal, it's better than the alternative.
>
> Regards,
> John
>
> -- 
> Thanks,
> Caesar

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip