* Re: [Bug] usb: dwc2: Add functions to set and clear force mode [not found] ` <56A7603C.1000409-TNX95d0MmH7DzftRWevZcw@public.gmane.org> @ 2016-01-26 16:05 ` Doug Anderson [not found] ` <CAD=FV=Xk4v=1QMYG9XmXh6hJLKU6i_wVakOArF1du-Z_4_+Neg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 13+ messages in thread From: Doug Anderson @ 2016-01-26 16:05 UTC (permalink / raw) To: Caesar Wang Cc: John Youn, open list:ARM/Rockchip SoC..., Heiko Stuebner, Felipe Balbi Hi, On Tue, Jan 26, 2016 at 4:02 AM, Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org> wrote: > Hi John, Felipe > > > I'm no familiar with usb stuff. > then I found this patch will break usb working for rk3036 SoCs, maybe more > SoCs. > Says, U disk can't work on usb host. > > The failure log: > > 32.645481] usb usb2-port1: connect-debounce failed > > > Tested by following branch: > https://github.com/Caesar-github/rockchip/tree/kylin/next (kernel: > 4.5-rc1) > > Revert "usb: dwc2: Add functions to set and clear force mode" will work for > it. > > > Maybe, someone have some suggestions or ideas? Can you check if this series helps you? http://marc.info/?l=linux-usb&m=145255851516121&w=2 I know USB on mainline was failing pretty badly for me for rk3288 until I applied those patches, though I didn't debug it further than just applying those patches. -Doug ^ permalink raw reply [flat|nested] 13+ messages in thread
[parent not found: <CAD=FV=Xk4v=1QMYG9XmXh6hJLKU6i_wVakOArF1du-Z_4_+Neg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [Bug] usb: dwc2: Add functions to set and clear force mode [not found] ` <CAD=FV=Xk4v=1QMYG9XmXh6hJLKU6i_wVakOArF1du-Z_4_+Neg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2016-01-27 2:12 ` Caesar Wang [not found] ` <56A8277F.9-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 13+ messages in thread From: Caesar Wang @ 2016-01-27 2:12 UTC (permalink / raw) To: Doug Anderson Cc: Huang, Tao, Heiko Stuebner, John Youn, Felipe Balbi, open list:ARM/Rockchip SoC..., 吴良峰 Thanks Doug's reply. Cc: Wulf 在 2016年01月27日 00:05, Doug Anderson 写道: > Hi, > > On Tue, Jan 26, 2016 at 4:02 AM, Caesar Wang <wxt@rock-chips.com> wrote: >> Hi John, Felipe >> >> >> I'm no familiar with usb stuff. >> then I found this patch will break usb working for rk3036 SoCs, maybe more >> SoCs. >> Says, U disk can't work on usb host. >> >> The failure log: >> >> 32.645481] usb usb2-port1: connect-debounce failed >> >> >> Tested by following branch: >> https://github.com/Caesar-github/rockchip/tree/kylin/next (kernel: >> 4.5-rc1) >> >> Revert "usb: dwc2: Add functions to set and clear force mode" will work for >> it. >> >> >> Maybe, someone have some suggestions or ideas? > Can you check if this series helps you? > > http://marc.info/?l=linux-usb&m=145255851516121&w=2 Unluckily, this series patches can't fix it on rk3036 SoCs. I revert this CL ("usb: dwc2: Add functions to set and clear force mode") to work firstly. > I know USB on mainline was failing pretty badly for me for rk3288 > until I applied those patches, though I didn't debug it further than > just applying those patches. > > -Doug > > > > > -- > Thanks, > Caesar _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 13+ messages in thread
[parent not found: <56A8277F.9-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [Bug] usb: dwc2: Add functions to set and clear force mode [not found] ` <56A8277F.9-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2016-01-29 19:11 ` Doug Anderson [not found] ` <CAD=FV=Uab6H6sFVj_bPRs7H4HcBi2pqZK3HDCHQxC+EDk=inDA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 13+ messages in thread From: Doug Anderson @ 2016-01-29 19:11 UTC (permalink / raw) To: Caesar Wang Cc: Huang, Tao, Heiko Stuebner, John Youn, Felipe Balbi, open list:ARM/Rockchip SoC..., 吴良峰 Caesar, On Tue, Jan 26, 2016 at 6:12 PM, Caesar Wang <caesar.upstream@gmail.com> wrote: > Thanks Doug's reply. > > Cc: Wulf > 在 2016年01月27日 00:05, Doug Anderson 写道: >> >> Hi, >> >> On Tue, Jan 26, 2016 at 4:02 AM, Caesar Wang <wxt@rock-chips.com> wrote: >>> >>> Hi John, Felipe >>> >>> >>> I'm no familiar with usb stuff. >>> then I found this patch will break usb working for rk3036 SoCs, maybe >>> more >>> SoCs. >>> Says, U disk can't work on usb host. >>> >>> The failure log: >>> >>> 32.645481] usb usb2-port1: connect-debounce failed >>> >>> >>> Tested by following branch: >>> https://github.com/Caesar-github/rockchip/tree/kylin/next (kernel: >>> 4.5-rc1) >>> >>> Revert "usb: dwc2: Add functions to set and clear force mode" will work >>> for >>> it. >>> >>> >>> Maybe, someone have some suggestions or ideas? >> >> Can you check if this series helps you? >> >> http://marc.info/?l=linux-usb&m=145255851516121&w=2 > > > Unluckily, this series patches can't fix it on rk3036 SoCs. > I revert this CL ("usb: dwc2: Add functions to set and clear force mode") to > work firstly. You're 100% positive? In particular you made sure you had this patch (one of the two in John's series I pointed at), which explicitly mentions fixing a problem with the patch you mention? Author: John Youn <John.Youn@synopsys.com> AuthorDate: Mon Jan 11 16:32:28 2016 -0800 usb: dwc2: Fix probe problem on bcm2835 Fixes an issue found on Raspberry PI platform that prevents probe. Don't skip setting the force mode if it's already set. Fixes: 09c96980dc72 ("usb: dwc2: Add functions to set and clear force mode") Signed-off-by: John Youn <johnyoun@synopsys.com> Reported-by: Stefan Wahren <stefan.wahren@i2se.com> Reported-by: Remi Pommarel <repk@triplefau.lt> Tested-by: Stefan Wahren <stefan.wahren@i2se.com> Tested-by: Remi Pommarel <repk@triplefau.lt> Maybe try again just in case there was some problem updating your kernel when you tested before? If you're sure you can reproduce the problem even with John's two patches, perhaps you can give more details about what part of his patch broke things for you. -Doug _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 13+ messages in thread
[parent not found: <CAD=FV=Uab6H6sFVj_bPRs7H4HcBi2pqZK3HDCHQxC+EDk=inDA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [Bug] usb: dwc2: Add functions to set and clear force mode [not found] ` <CAD=FV=Uab6H6sFVj_bPRs7H4HcBi2pqZK3HDCHQxC+EDk=inDA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2016-02-01 11:12 ` Caesar Wang [not found] ` <56AF3D80.90807-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 13+ messages in thread From: Caesar Wang @ 2016-02-01 11:12 UTC (permalink / raw) To: Doug Anderson Cc: Caesar Wang, Huang, Tao, Heiko Stuebner, John Youn, Felipe Balbi, open list:ARM/Rockchip SoC..., 吴良峰 Doug 在 2016年01月30日 03:11, Doug Anderson 写道: > Caesar, > > On Tue, Jan 26, 2016 at 6:12 PM, Caesar Wang <caesar.upstream@gmail.com> wrote: >> Thanks Doug's reply. >> >> Cc: Wulf >> 在 2016年01月27日 00:05, Doug Anderson 写道: >>> Hi, >>> >>> On Tue, Jan 26, 2016 at 4:02 AM, Caesar Wang <wxt@rock-chips.com> wrote: >>>> Hi John, Felipe >>>> >>>> >>>> I'm no familiar with usb stuff. >>>> then I found this patch will break usb working for rk3036 SoCs, maybe >>>> more >>>> SoCs. >>>> Says, U disk can't work on usb host. >>>> >>>> The failure log: >>>> >>>> 32.645481] usb usb2-port1: connect-debounce failed >>>> >>>> >>>> Tested by following branch: >>>> https://github.com/Caesar-github/rockchip/tree/kylin/next (kernel: >>>> 4.5-rc1) >>>> >>>> Revert "usb: dwc2: Add functions to set and clear force mode" will work >>>> for >>>> it. >>>> >>>> >>>> Maybe, someone have some suggestions or ideas? >>> Can you check if this series helps you? >>> >>> http://marc.info/?l=linux-usb&m=145255851516121&w=2 >> >> Unluckily, this series patches can't fix it on rk3036 SoCs. >> I revert this CL ("usb: dwc2: Add functions to set and clear force mode") to >> work firstly. > You're 100% positive? In particular you made sure you had this patch > (one of the two in John's series I pointed at), which explicitly > mentions fixing a problem with the patch you mention? I'm 100% positive the John's patches can fix this issue. As the following verified on https://github.com/Caesar-github/rockchip/commits/for-usb-tests Anyway, Meanwhile if we add the folllowing patch can work for me. I will track it on tomorrow if you have other suggestions. diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c index e991d55..90f4abf 100644 --- a/drivers/usb/dwc2/core.c +++ b/drivers/usb/dwc2/core.c @@ -637,6 +637,13 @@ int dwc2_core_reset_and_force_dr_mode(struct dwc2_hsotg *hsotg) return retval; dwc2_force_dr_mode(hsotg); + + /* + * NOTE: This long sleep is _very_ important, otherwise the core will + * not stay in host mode after a connector ID change! + */ + usleep_range(150000, 160000); + return 0; } > > Author: John Youn <John.Youn@synopsys.com> > AuthorDate: Mon Jan 11 16:32:28 2016 -0800 > > usb: dwc2: Fix probe problem on bcm2835 > > Fixes an issue found on Raspberry PI platform that prevents probe. Don't > skip setting the force mode if it's already set. > > Fixes: 09c96980dc72 ("usb: dwc2: Add functions to set and clear force mode") > Signed-off-by: John Youn <johnyoun@synopsys.com> > Reported-by: Stefan Wahren <stefan.wahren@i2se.com> > Reported-by: Remi Pommarel <repk@triplefau.lt> > Tested-by: Stefan Wahren <stefan.wahren@i2se.com> > Tested-by: Remi Pommarel <repk@triplefau.lt> > > > Maybe try again just in case there was some problem updating your > kernel when you tested before? If you're sure you can reproduce the > problem even with John's two patches, perhaps you can give more > details about what part of his patch broke things for you. > > -Doug > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip -- Thanks, Caesar _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply related [flat|nested] 13+ messages in thread
[parent not found: <56AF3D80.90807-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [Bug] usb: dwc2: Add functions to set and clear force mode [not found] ` <56AF3D80.90807-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2016-02-01 11:13 ` Caesar Wang 2016-02-01 23:31 ` John Youn 0 siblings, 1 reply; 13+ messages in thread From: Caesar Wang @ 2016-02-01 11:13 UTC (permalink / raw) To: Doug Anderson Cc: Huang, Tao, Heiko Stuebner, John Youn, Felipe Balbi, open list:ARM/Rockchip SoC..., 吴良峰 在 2016年02月01日 19:12, Caesar Wang 写道: > Doug > > 在 2016年01月30日 03:11, Doug Anderson 写道: >> Caesar, >> >> On Tue, Jan 26, 2016 at 6:12 PM, Caesar Wang >> <caesar.upstream@gmail.com> wrote: >>> Thanks Doug's reply. >>> >>> Cc: Wulf >>> 在 2016年01月27日 00:05, Doug Anderson 写道: >>>> Hi, >>>> >>>> On Tue, Jan 26, 2016 at 4:02 AM, Caesar Wang <wxt@rock-chips.com> >>>> wrote: >>>>> Hi John, Felipe >>>>> >>>>> >>>>> I'm no familiar with usb stuff. >>>>> then I found this patch will break usb working for rk3036 SoCs, maybe >>>>> more >>>>> SoCs. >>>>> Says, U disk can't work on usb host. >>>>> >>>>> The failure log: >>>>> >>>>> 32.645481] usb usb2-port1: connect-debounce failed >>>>> >>>>> >>>>> Tested by following branch: >>>>> https://github.com/Caesar-github/rockchip/tree/kylin/next (kernel: >>>>> 4.5-rc1) >>>>> >>>>> Revert "usb: dwc2: Add functions to set and clear force mode" will >>>>> work >>>>> for >>>>> it. >>>>> >>>>> >>>>> Maybe, someone have some suggestions or ideas? >>>> Can you check if this series helps you? >>>> >>>> http://marc.info/?l=linux-usb&m=145255851516121&w=2 >>> >>> Unluckily, this series patches can't fix it on rk3036 SoCs. >>> I revert this CL ("usb: dwc2: Add functions to set and clear force >>> mode") to >>> work firstly. >> You're 100% positive? In particular you made sure you had this patch >> (one of the two in John's series I pointed at), which explicitly >> mentions fixing a problem with the patch you mention? > > I'm 100% positive the John's patches can fix this issue Sorry, John's patches can't fix this issue. > As the following verified on > https://github.com/Caesar-github/rockchip/commits/for-usb-tests > > Anyway, Meanwhile if we add the folllowing patch can work for me. I > will track it on tomorrow if you have other suggestions. > > diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c > index e991d55..90f4abf 100644 > --- a/drivers/usb/dwc2/core.c > +++ b/drivers/usb/dwc2/core.c > @@ -637,6 +637,13 @@ int dwc2_core_reset_and_force_dr_mode(struct > dwc2_hsotg *hsotg) > return retval; > > dwc2_force_dr_mode(hsotg); > + > + /* > + * NOTE: This long sleep is _very_ important, otherwise the > core will > + * not stay in host mode after a connector ID change! > + */ > + usleep_range(150000, 160000); > + > return 0; > } > > >> >> Author: John Youn <John.Youn@synopsys.com> >> AuthorDate: Mon Jan 11 16:32:28 2016 -0800 >> >> usb: dwc2: Fix probe problem on bcm2835 >> >> Fixes an issue found on Raspberry PI platform that prevents >> probe. Don't >> skip setting the force mode if it's already set. >> >> Fixes: 09c96980dc72 ("usb: dwc2: Add functions to set and clear >> force mode") >> Signed-off-by: John Youn <johnyoun@synopsys.com> >> Reported-by: Stefan Wahren <stefan.wahren@i2se.com> >> Reported-by: Remi Pommarel <repk@triplefau.lt> >> Tested-by: Stefan Wahren <stefan.wahren@i2se.com> >> Tested-by: Remi Pommarel <repk@triplefau.lt> >> >> >> Maybe try again just in case there was some problem updating your >> kernel when you tested before? If you're sure you can reproduce the >> problem even with John's two patches, perhaps you can give more >> details about what part of his patch broke things for you. >> >> -Doug >> >> _______________________________________________ >> Linux-rockchip mailing list >> Linux-rockchip@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-rockchip > > -- Thanks, Caesar _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Bug] usb: dwc2: Add functions to set and clear force mode 2016-02-01 11:13 ` Caesar Wang @ 2016-02-01 23:31 ` John Youn [not found] ` <2B3535C5ECE8B5419E3ECBE30077290901DC42FD26-Yu2iAY70zvrYN67daEjeMPufCSb+aD3WLzEdoUbNIic@public.gmane.org> 0 siblings, 1 reply; 13+ messages in thread From: John Youn @ 2016-02-01 23:31 UTC (permalink / raw) To: Caesar Wang, Doug Anderson Cc: Huang, Tao, Heiko Stuebner, Felipe Balbi, John Youn, open list:ARM/Rockchip SoC..., 吴良峰 On 2/1/2016 3:13 AM, Caesar Wang wrote: > > > 在 2016年02月01日 19:12, Caesar Wang 写道: >> Doug >> >> 在 2016年01月30日 03:11, Doug Anderson 写道: >>> Caesar, >>> >>> On Tue, Jan 26, 2016 at 6:12 PM, Caesar Wang >>> <caesar.upstream@gmail.com> wrote: >>>> Thanks Doug's reply. >>>> >>>> Cc: Wulf >>>> 在 2016年01月27日 00:05, Doug Anderson 写道: >>>>> Hi, >>>>> >>>>> On Tue, Jan 26, 2016 at 4:02 AM, Caesar Wang <wxt@rock-chips.com> >>>>> wrote: >>>>>> Hi John, Felipe >>>>>> >>>>>> >>>>>> I'm no familiar with usb stuff. >>>>>> then I found this patch will break usb working for rk3036 SoCs, maybe >>>>>> more >>>>>> SoCs. >>>>>> Says, U disk can't work on usb host. >>>>>> >>>>>> The failure log: >>>>>> >>>>>> 32.645481] usb usb2-port1: connect-debounce failed >>>>>> >>>>>> >>>>>> Tested by following branch: >>>>>> https://github.com/Caesar-github/rockchip/tree/kylin/next (kernel: >>>>>> 4.5-rc1) >>>>>> >>>>>> Revert "usb: dwc2: Add functions to set and clear force mode" will >>>>>> work >>>>>> for >>>>>> it. >>>>>> >>>>>> >>>>>> Maybe, someone have some suggestions or ideas? >>>>> Can you check if this series helps you? >>>>> >>>>> http://marc.info/?l=linux-usb&m=145255851516121&w=2 >>>> >>>> Unluckily, this series patches can't fix it on rk3036 SoCs. >>>> I revert this CL ("usb: dwc2: Add functions to set and clear force >>>> mode") to >>>> work firstly. >>> You're 100% positive? In particular you made sure you had this patch >>> (one of the two in John's series I pointed at), which explicitly >>> mentions fixing a problem with the patch you mention? >> >> I'm 100% positive the John's patches can fix this issue > > Sorry, John's patches can't fix this issue. > > >> As the following verified on >> https://github.com/Caesar-github/rockchip/commits/for-usb-tests >> >> Anyway, Meanwhile if we add the folllowing patch can work for me. I >> will track it on tomorrow if you have other suggestions. >> >> diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c >> index e991d55..90f4abf 100644 >> --- a/drivers/usb/dwc2/core.c >> +++ b/drivers/usb/dwc2/core.c >> @@ -637,6 +637,13 @@ int dwc2_core_reset_and_force_dr_mode(struct >> dwc2_hsotg *hsotg) >> return retval; >> >> dwc2_force_dr_mode(hsotg); >> + >> + /* >> + * NOTE: This long sleep is _very_ important, otherwise the >> core will >> + * not stay in host mode after a connector ID change! >> + */ >> + usleep_range(150000, 160000); >> + >> return 0; >> } Hi Cesar, On your platform, is the dwc2 controller OTG? If so, what mode is the driver running in (dr_mode=HOST, PERIPHERAL, or OTG)? The force mode only requires 25ms delay but maybe the sleep needs to be longer on your system for some other reason. Which is unfortunate because 150ms is very long. Under what condition do you see the problem. Is it on connector ID change? If so we might put the long delay in a more appropriate location so as not to affect delay in probe. Also, could you try *only* reverting the following: commit 97e463886b873f62bea2293e7edf81fdb884b84f ("usb: dwc2: Reduce delay when forcing mode in reset") The original patch you referred to preserves the long delay at the point it is used for OTG but then this later patch (97e46388) decreased the value. So maybe we can just revert this later patch. Regards, John _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 13+ messages in thread
[parent not found: <2B3535C5ECE8B5419E3ECBE30077290901DC42FD26-Yu2iAY70zvrYN67daEjeMPufCSb+aD3WLzEdoUbNIic@public.gmane.org>]
* Re: [Bug] usb: dwc2: Add functions to set and clear force mode [not found] ` <2B3535C5ECE8B5419E3ECBE30077290901DC42FD26-Yu2iAY70zvrYN67daEjeMPufCSb+aD3WLzEdoUbNIic@public.gmane.org> @ 2016-02-02 2:42 ` Caesar Wang [not found] ` <56B01785.3030803-9Onoh4P/yGk@public.gmane.org> 0 siblings, 1 reply; 13+ messages in thread From: Caesar Wang @ 2016-02-02 2:42 UTC (permalink / raw) To: John Youn, Caesar Wang, Doug Anderson Cc: Huang, Tao, open list:ARM/Rockchip SoC..., Heiko Stuebner, Felipe Balbi, 吴良峰 Hi John, 在 2016年02月02日 07:31, John Youn 写道: > On 2/1/2016 3:13 AM, Caesar Wang wrote: >> >> 在 2016年02月01日 19:12, Caesar Wang 写道: >>> Doug >>> >>> 在 2016年01月30日 03:11, Doug Anderson 写道: >>>> Caesar, >>>> >>>> On Tue, Jan 26, 2016 at 6:12 PM, Caesar Wang >>>> <caesar.upstream@gmail.com> wrote: >>>>> Thanks Doug's reply. >>>>> >>>>> Cc: Wulf >>>>> 在 2016年01月27日 00:05, Doug Anderson 写道: >>>>>> Hi, >>>>>> >>>>>> On Tue, Jan 26, 2016 at 4:02 AM, Caesar Wang <wxt@rock-chips.com> >>>>>> wrote: >>>>>>> Hi John, Felipe >>>>>>> >>>>>>> >>>>>>> I'm no familiar with usb stuff. >>>>>>> then I found this patch will break usb working for rk3036 SoCs, maybe >>>>>>> more >>>>>>> SoCs. >>>>>>> Says, U disk can't work on usb host. >>>>>>> >>>>>>> The failure log: >>>>>>> >>>>>>> 32.645481] usb usb2-port1: connect-debounce failed >>>>>>> >>>>>>> >>>>>>> Tested by following branch: >>>>>>> https://github.com/Caesar-github/rockchip/tree/kylin/next (kernel: >>>>>>> 4.5-rc1) >>>>>>> >>>>>>> Revert "usb: dwc2: Add functions to set and clear force mode" will >>>>>>> work >>>>>>> for >>>>>>> it. >>>>>>> >>>>>>> >>>>>>> Maybe, someone have some suggestions or ideas? >>>>>> Can you check if this series helps you? >>>>>> >>>>>> http://marc.info/?l=linux-usb&m=145255851516121&w=2 >>>>> Unluckily, this series patches can't fix it on rk3036 SoCs. >>>>> I revert this CL ("usb: dwc2: Add functions to set and clear force >>>>> mode") to >>>>> work firstly. >>>> You're 100% positive? In particular you made sure you had this patch >>>> (one of the two in John's series I pointed at), which explicitly >>>> mentions fixing a problem with the patch you mention? >>> I'm 100% positive the John's patches can fix this issue >> Sorry, John's patches can't fix this issue. >> >> >>> As the following verified on >>> https://github.com/Caesar-github/rockchip/commits/for-usb-tests >>> >>> Anyway, Meanwhile if we add the folllowing patch can work for me. I >>> will track it on tomorrow if you have other suggestions. >>> >>> diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c >>> >>> index e991d55..90f4abf 100644 >>> >>> --- a/drivers/usb/dwc2/core.c >>> >>> +++ b/drivers/usb/dwc2/core.c >>> >>> @@ -637,6 +637,13 @@ int dwc2_core_reset_and_force_dr_mode(struct >>> dwc2_hsotg *hsotg) >>> >>> return retval; >>> >>> >>> >>> dwc2_force_dr_mode(hsotg); >>> >>> + >>> >>> + /* >>> >>> + * NOTE: This long sleep is_very_ important, otherwise the core >>> will >>> >>> + * not stay in host mode after a connector ID change! >>> >>> + */ >>> >>> + usleep_range(150000, 160000); >>> >>> + >>> >>> return 0; >>> >>> } >>> > Hi Cesar, > > On your platform, is the dwc2 controller OTG? If so, what mode is the > driver running in (dr_mode=HOST, PERIPHERAL, or OTG)? It's the Host mode. ( USB_DR_MODE_HOST) > > The force mode only requires 25ms delay but maybe the sleep needs to > be longer on your system for some other reason. Which is unfortunate > because 150ms is very long. > > Under what condition do you see the problem. Is it on connector ID > change? If so we might put the long delay in a more appropriate > location so as not to affect delay in probe. > > Also, could you try *only* reverting the following: > > commit 97e463886b873f62bea2293e7edf81fdb884b84f ("usb: dwc2: Reduce > delay when forcing mode in reset") I'm sure can't work if we revert it. log ...: "[ 5.705971] usb usb2-port1: connect-debounce failed" d4b3ff1 Revert "usb: dwc2: Reduce delay when forcing mode in reset" c69654f usb: dwc2: Fix probe problem on bcm283 b9da0ff Revert "usb: dwc2: Move reset into dwc2_get_hwparams() -- Then, add the following patch can work. diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c index e991d55..90f4abf 100644 --- a/drivers/usb/dwc2/core.c +++ b/drivers/usb/dwc2/core.c @@ -637,6 +637,13 @@ int dwc2_core_reset_and_force_dr_mode(struct dwc2_hsotg *hsotg) return retval; dwc2_force_dr_mode(hsotg); + + /* + * NOTE: This long sleep is _very_ important, otherwise the core will + * not stay in host mode after a connector ID change! + */ + usleep_range(150000, 160000); + return 0; } > The original patch you referred to preserves the long delay at the > point it is used for OTG but then this later patch (97e46388) > decreased the value. So maybe we can just revert this later patch. > > Regards, > John > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply related [flat|nested] 13+ messages in thread
[parent not found: <56B01785.3030803-9Onoh4P/yGk@public.gmane.org>]
* Re: [Bug] usb: dwc2: Add functions to set and clear force mode [not found] ` <56B01785.3030803-9Onoh4P/yGk@public.gmane.org> @ 2016-02-02 2:53 ` Caesar Wang 2016-02-03 0:03 ` John Youn 0 siblings, 1 reply; 13+ messages in thread From: Caesar Wang @ 2016-02-02 2:53 UTC (permalink / raw) To: John Youn Cc: Huang, Tao, Heiko Stuebner, Doug Anderson, Felipe Balbi, open list:ARM/Rockchip SoC..., 吴良峰, CaesarWang John, I will suggest the msleep(25) delay should put in 'dwc2_force_dr_mode()' instead of the 'dwc2_clear_force_mode()' 在 2016年02月02日 10:42, Caesar Wang 写道: > Hi John, > > 在 2016年02月02日 07:31, John Youn 写道: >> On 2/1/2016 3:13 AM, Caesar Wang wrote: >>> >>> 在 2016年02月01日 19:12, Caesar Wang 写道: >>>> Doug >>>> >>>> 在 2016年01月30日 03:11, Doug Anderson 写道: >>>>> Caesar, >>>>> >>>>> On Tue, Jan 26, 2016 at 6:12 PM, Caesar Wang >>>>> <caesar.upstream@gmail.com> wrote: >>>>>> Thanks Doug's reply. >>>>>> >>>>>> Cc: Wulf >>>>>> 在 2016年01月27日 00:05, Doug Anderson 写道: >>>>>>> Hi, >>>>>>> >>>>>>> On Tue, Jan 26, 2016 at 4:02 AM, Caesar Wang <wxt@rock-chips.com> >>>>>>> wrote: >>>>>>>> Hi John, Felipe >>>>>>>> >>>>>>>> >>>>>>>> I'm no familiar with usb stuff. >>>>>>>> then I found this patch will break usb working for rk3036 SoCs, >>>>>>>> maybe >>>>>>>> more >>>>>>>> SoCs. >>>>>>>> Says, U disk can't work on usb host. >>>>>>>> >>>>>>>> The failure log: >>>>>>>> >>>>>>>> 32.645481] usb usb2-port1: connect-debounce failed >>>>>>>> >>>>>>>> >>>>>>>> Tested by following branch: >>>>>>>> https://github.com/Caesar-github/rockchip/tree/kylin/next (kernel: >>>>>>>> 4.5-rc1) >>>>>>>> >>>>>>>> Revert "usb: dwc2: Add functions to set and clear force mode" will >>>>>>>> work >>>>>>>> for >>>>>>>> it. >>>>>>>> >>>>>>>> >>>>>>>> Maybe, someone have some suggestions or ideas? >>>>>>> Can you check if this series helps you? >>>>>>> >>>>>>> http://marc.info/?l=linux-usb&m=145255851516121&w=2 >>>>>> Unluckily, this series patches can't fix it on rk3036 SoCs. >>>>>> I revert this CL ("usb: dwc2: Add functions to set and clear force >>>>>> mode") to >>>>>> work firstly. >>>>> You're 100% positive? In particular you made sure you had this patch >>>>> (one of the two in John's series I pointed at), which explicitly >>>>> mentions fixing a problem with the patch you mention? >>>> I'm 100% positive the John's patches can fix this issue >>> Sorry, John's patches can't fix this issue. >>> >>> >>>> As the following verified on >>>> https://github.com/Caesar-github/rockchip/commits/for-usb-tests >>>> >>>> Anyway, Meanwhile if we add the folllowing patch can work for me. I >>>> will track it on tomorrow if you have other suggestions. >>>> >>>> diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c >>>> >>>> index e991d55..90f4abf 100644 >>>> >>>> --- a/drivers/usb/dwc2/core.c >>>> >>>> +++ b/drivers/usb/dwc2/core.c >>>> >>>> @@ -637,6 +637,13 @@ int dwc2_core_reset_and_force_dr_mode(struct >>>> dwc2_hsotg *hsotg) >>>> >>>> return retval; >>>> >>>> >>>> >>>> dwc2_force_dr_mode(hsotg); >>>> >>>> + >>>> >>>> + /* >>>> >>>> + * NOTE: This long sleep is_very_ important, otherwise the >>>> core >>>> will >>>> >>>> + * not stay in host mode after a connector ID change! >>>> >>>> + */ >>>> >>>> + usleep_range(150000, 160000); >>>> >>>> + >>>> >>>> return 0; >>>> >>>> } >>>> >> Hi Cesar, >> >> On your platform, is the dwc2 controller OTG? If so, what mode is the >> driver running in (dr_mode=HOST, PERIPHERAL, or OTG)? > > > It's the Host mode. ( USB_DR_MODE_HOST) > >> >> The force mode only requires 25ms delay but maybe the sleep needs to >> be longer on your system for some other reason. Which is unfortunate >> because 150ms is very long. >> >> Under what condition do you see the problem. Is it on connector ID >> change? If so we might put the long delay in a more appropriate >> location so as not to affect delay in probe. >> >> Also, could you try *only* reverting the following: >> >> commit 97e463886b873f62bea2293e7edf81fdb884b84f ("usb: dwc2: Reduce >> delay when forcing mode in reset") > > I'm sure can't work if we revert it. > log > ...: > "[ 5.705971] usb usb2-port1: connect-debounce failed" > > d4b3ff1 Revert "usb: dwc2: Reduce delay when forcing mode in reset" > c69654f usb: dwc2: Fix probe problem on bcm283 > b9da0ff Revert "usb: dwc2: Move reset into dwc2_get_hwparams() > > -- > > Then, add the following patch can work. > > diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c > index e991d55..90f4abf 100644 > --- a/drivers/usb/dwc2/core.c > +++ b/drivers/usb/dwc2/core.c > @@ -637,6 +637,13 @@ int dwc2_core_reset_and_force_dr_mode(struct > dwc2_hsotg *hsotg) > return retval; > > dwc2_force_dr_mode(hsotg); > + > + /* > + * NOTE: This long sleep is _very_ important, otherwise the > core will > + * not stay in host mode after a connector ID change! > + */ > + usleep_range(150000, 160000); > + > return 0; > } > >> The original patch you referred to preserves the long delay at the >> point it is used for OTG but then this later patch (97e46388) >> decreased the value. So maybe we can just revert this later patch. >> >> Regards, >> John >> _______________________________________________ >> Linux-rockchip mailing list >> Linux-rockchip@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-rockchip > > > -- Thanks, Caesar _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Bug] usb: dwc2: Add functions to set and clear force mode 2016-02-02 2:53 ` Caesar Wang @ 2016-02-03 0:03 ` John Youn [not found] ` <2B3535C5ECE8B5419E3ECBE30077290901DC431FDB-Yu2iAY70zvrYN67daEjeMPufCSb+aD3WLzEdoUbNIic@public.gmane.org> 0 siblings, 1 reply; 13+ messages in thread From: John Youn @ 2016-02-03 0:03 UTC (permalink / raw) To: Caesar Wang, John Youn Cc: Huang, Tao, Heiko Stuebner, Doug Anderson, Felipe Balbi, open list:ARM/Rockchip SoC..., 吴良峰, CaesarWang On 2/1/2016 6:53 PM, Caesar Wang wrote: > John, > > I will suggest the msleep(25) delay should put in > 'dwc2_force_dr_mode()' instead of the 'dwc2_clear_force_mode()' > Hi Caesar, Are you saying that just msleep(25) in that function like this solves your issue? diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c index 39a0fa8..e8a9688 100644 --- a/drivers/usb/dwc2/core.c +++ b/drivers/usb/dwc2/core.c @@ -625,6 +625,8 @@ void dwc2_force_dr_mode(struct dwc2_hsotg *hsotg) __func__, hsotg->dr_mode); break; } + + msleep(25); } Although that is still not ideal, it's better than the alternative. Regards, John ^ permalink raw reply related [flat|nested] 13+ messages in thread
[parent not found: <2B3535C5ECE8B5419E3ECBE30077290901DC431FDB-Yu2iAY70zvrYN67daEjeMPufCSb+aD3WLzEdoUbNIic@public.gmane.org>]
* Re: [Bug] usb: dwc2: Add functions to set and clear force mode [not found] ` <2B3535C5ECE8B5419E3ECBE30077290901DC431FDB-Yu2iAY70zvrYN67daEjeMPufCSb+aD3WLzEdoUbNIic@public.gmane.org> @ 2016-02-03 0:35 ` Caesar Wang 2016-02-03 1:08 ` John Youn 0 siblings, 1 reply; 13+ messages in thread From: Caesar Wang @ 2016-02-03 0:35 UTC (permalink / raw) To: John Youn Cc: Caesar Wang, Huang, Tao, Heiko Stuebner, Doug Anderson, Felipe Balbi, open list:ARM/Rockchip SoC..., 吴良峰 Hi John, 在 2016年02月03日 08:03, John Youn 写道: > On 2/1/2016 6:53 PM, Caesar Wang wrote: >> John, >> >> I will suggest the msleep(25) delay should put in >> 'dwc2_force_dr_mode()' instead of the 'dwc2_clear_force_mode()' >> > Hi Caesar, > > Are you saying that just msleep(25) in that function like this solves > your issue? > > diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c > index 39a0fa8..e8a9688 100644 > --- a/drivers/usb/dwc2/core.c > +++ b/drivers/usb/dwc2/core.c > @@ -625,6 +625,8 @@ void dwc2_force_dr_mode(struct dwc2_hsotg *hsotg) > __func__, hsotg->dr_mode); > break; > } > + > + msleep(25); Yep, that will solve this issue. > } > > > > Although that is still not ideal, it's better than the alternative. > > Regards, > John > > -- > Thanks, > Caesar _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Bug] usb: dwc2: Add functions to set and clear force mode 2016-02-03 0:35 ` Caesar Wang @ 2016-02-03 1:08 ` John Youn [not found] ` <2B3535C5ECE8B5419E3ECBE30077290901DC4322F0-Yu2iAY70zvrYN67daEjeMPufCSb+aD3WLzEdoUbNIic@public.gmane.org> 0 siblings, 1 reply; 13+ messages in thread From: John Youn @ 2016-02-03 1:08 UTC (permalink / raw) To: Caesar Wang, John Youn Cc: Huang, Tao, Heiko Stuebner, Doug Anderson, Felipe Balbi, open list:ARM/Rockchip SoC..., 吴良峰 On 2/2/2016 4:36 PM, Caesar Wang wrote: > Hi John, > > 在 2016年02月03日 08:03, John Youn 写道: >> On 2/1/2016 6:53 PM, Caesar Wang wrote: >>> John, >>> >>> I will suggest the msleep(25) delay should put in >>> 'dwc2_force_dr_mode()' instead of the 'dwc2_clear_force_mode()' >>> >> Hi Caesar, >> >> Are you saying that just msleep(25) in that function like this solves >> your issue? >> >> diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c >> index 39a0fa8..e8a9688 100644 >> --- a/drivers/usb/dwc2/core.c >> +++ b/drivers/usb/dwc2/core.c >> @@ -625,6 +625,8 @@ void dwc2_force_dr_mode(struct dwc2_hsotg *hsotg) >> __func__, hsotg->dr_mode); >> break; >> } >> + >> + msleep(25); > > Yep, that will solve this issue. > Ok thanks. Though that still seems strange since you should be getting the msleep(25) from either the dwc2_force_mode() or dwc2_clear_force_mode(). Can you check if the following patch works? If so, I think we can go with that to fix the regression for now. Otherwise I'll just add the extra msleep(25) and revisit this later. Regards, John ---->8---- diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c index e991d55..13c060c 100644 --- a/drivers/usb/dwc2/core.c +++ b/drivers/usb/dwc2/core.c @@ -576,7 +576,6 @@ static bool dwc2_force_mode(struct dwc2_hsotg *hsotg, bool host) gusbcfg |= set; dwc2_writel(gusbcfg, hsotg->regs + GUSBCFG); - msleep(25); return true; } @@ -596,7 +595,6 @@ static void dwc2_clear_force_mode(struct dwc2_hsotg *hsotg) * NOTE: This long sleep is _very_ important, otherwise the core will * not stay in host mode after a connector ID change! */ - msleep(25); } /* @@ -619,6 +617,8 @@ void dwc2_force_dr_mode(struct dwc2_hsotg *hsotg) __func__, hsotg->dr_mode); break; } + + msleep(25); } _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply related [flat|nested] 13+ messages in thread
[parent not found: <2B3535C5ECE8B5419E3ECBE30077290901DC4322F0-Yu2iAY70zvrYN67daEjeMPufCSb+aD3WLzEdoUbNIic@public.gmane.org>]
* Re: [Bug] usb: dwc2: Add functions to set and clear force mode [not found] ` <2B3535C5ECE8B5419E3ECBE30077290901DC4322F0-Yu2iAY70zvrYN67daEjeMPufCSb+aD3WLzEdoUbNIic@public.gmane.org> @ 2016-02-03 1:10 ` Caesar Wang 2016-02-03 1:32 ` John Youn 0 siblings, 1 reply; 13+ messages in thread From: Caesar Wang @ 2016-02-03 1:10 UTC (permalink / raw) To: John Youn Cc: Huang, Tao, Heiko Stuebner, Doug Anderson, Felipe Balbi, open list:ARM/Rockchip SoC..., 吴良峰 在 2016年02月03日 09:08, John Youn 写道: > On 2/2/2016 4:36 PM, Caesar Wang wrote: >> Hi John, >> >> 在 2016年02月03日 08:03, John Youn 写道: >>> On 2/1/2016 6:53 PM, Caesar Wang wrote: >>>> John, >>>> >>>> I will suggest the msleep(25) delay should put in >>>> 'dwc2_force_dr_mode()' instead of the 'dwc2_clear_force_mode()' >>>> >>> Hi Caesar, >>> >>> Are you saying that just msleep(25) in that function like this solves >>> your issue? >>> >>> diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c >>> index 39a0fa8..e8a9688 100644 >>> --- a/drivers/usb/dwc2/core.c >>> +++ b/drivers/usb/dwc2/core.c >>> @@ -625,6 +625,8 @@ void dwc2_force_dr_mode(struct dwc2_hsotg *hsotg) >>> __func__, hsotg->dr_mode); >>> break; >>> } >>> + >>> + msleep(25); >> Yep, that will solve this issue. >> > Ok thanks. Though that still seems strange since you should be getting > the msleep(25) from either the dwc2_force_mode() or > dwc2_clear_force_mode(). > > Can you check if the following patch works? > > If so, I think we can go with that to fix the regression for > now. Otherwise I'll just add the extra msleep(25) and revisit this > later. > > Regards, > John > > ---->8---- > > diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c > index e991d55..13c060c 100644 > --- a/drivers/usb/dwc2/core.c > +++ b/drivers/usb/dwc2/core.c > @@ -576,7 +576,6 @@ static bool dwc2_force_mode(struct dwc2_hsotg *hsotg, bool host) > gusbcfg |= set; > dwc2_writel(gusbcfg, hsotg->regs + GUSBCFG); > > - msleep(25); > return true; > } > > @@ -596,7 +595,6 @@ static void dwc2_clear_force_mode(struct dwc2_hsotg *hsotg) > * NOTE: This long sleep is _very_ important, otherwise the core will > * not stay in host mode after a connector ID change! > */ > - msleep(25); > } > > /* > @@ -619,6 +617,8 @@ void dwc2_force_dr_mode(struct dwc2_hsotg *hsotg) > __func__, hsotg->dr_mode); > break; > } > + > + msleep(25); > } Right, that works for me. -- Thanks, Caesar _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Bug] usb: dwc2: Add functions to set and clear force mode 2016-02-03 1:10 ` Caesar Wang @ 2016-02-03 1:32 ` John Youn 0 siblings, 0 replies; 13+ messages in thread From: John Youn @ 2016-02-03 1:32 UTC (permalink / raw) To: Caesar Wang, John Youn Cc: Huang, Tao, Heiko Stuebner, Doug Anderson, Felipe Balbi, open list:ARM/Rockchip SoC..., 吴良峰 On 2/2/2016 5:10 PM, Caesar Wang wrote: > > > 在 2016年02月03日 09:08, John Youn 写道: >> On 2/2/2016 4:36 PM, Caesar Wang wrote: >>> Hi John, >>> >>> 在 2016年02月03日 08:03, John Youn 写道: >>>> On 2/1/2016 6:53 PM, Caesar Wang wrote: >>>>> John, >>>>> >>>>> I will suggest the msleep(25) delay should put in >>>>> 'dwc2_force_dr_mode()' instead of the 'dwc2_clear_force_mode()' >>>>> >>>> Hi Caesar, >>>> >>>> Are you saying that just msleep(25) in that function like this solves >>>> your issue? >>>> >>>> diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c >>>> index 39a0fa8..e8a9688 100644 >>>> --- a/drivers/usb/dwc2/core.c >>>> +++ b/drivers/usb/dwc2/core.c >>>> @@ -625,6 +625,8 @@ void dwc2_force_dr_mode(struct dwc2_hsotg *hsotg) >>>> __func__, hsotg->dr_mode); >>>> break; >>>> } >>>> + >>>> + msleep(25); >>> Yep, that will solve this issue. >>> >> Ok thanks. Though that still seems strange since you should be getting >> the msleep(25) from either the dwc2_force_mode() or >> dwc2_clear_force_mode(). >> >> Can you check if the following patch works? >> >> If so, I think we can go with that to fix the regression for >> now. Otherwise I'll just add the extra msleep(25) and revisit this >> later. >> >> Regards, >> John >> >> ---->8---- >> >> diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c >> index e991d55..13c060c 100644 >> --- a/drivers/usb/dwc2/core.c >> +++ b/drivers/usb/dwc2/core.c >> @@ -576,7 +576,6 @@ static bool dwc2_force_mode(struct dwc2_hsotg *hsotg, bool host) >> gusbcfg |= set; >> dwc2_writel(gusbcfg, hsotg->regs + GUSBCFG); >> >> - msleep(25); >> return true; >> } >> >> @@ -596,7 +595,6 @@ static void dwc2_clear_force_mode(struct dwc2_hsotg *hsotg) >> * NOTE: This long sleep is _very_ important, otherwise the core will >> * not stay in host mode after a connector ID change! >> */ >> - msleep(25); >> } >> >> /* >> @@ -619,6 +617,8 @@ void dwc2_force_dr_mode(struct dwc2_hsotg *hsotg) >> __func__, hsotg->dr_mode); >> break; >> } >> + >> + msleep(25); >> } > > Right, that works for me. > Ok, interesting. Actually this won't work either since we need the separate msleeps when those functions are called from other contexts. Is your controller by chance *not* OTG capable, i.e. dwc2_hw_is_otg(hsotg) == false Then the msleep in dwc2_force_mode() is skipped. Then, for some reason, skipping it (even though nothing was forced) causes the failure on your platform. Regards, John _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2016-02-03 1:32 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <56A7603C.1000409@rock-chips.com>
[not found] ` <56A7603C.1000409-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-01-26 16:05 ` [Bug] usb: dwc2: Add functions to set and clear force mode Doug Anderson
[not found] ` <CAD=FV=Xk4v=1QMYG9XmXh6hJLKU6i_wVakOArF1du-Z_4_+Neg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-27 2:12 ` Caesar Wang
[not found] ` <56A8277F.9-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-29 19:11 ` Doug Anderson
[not found] ` <CAD=FV=Uab6H6sFVj_bPRs7H4HcBi2pqZK3HDCHQxC+EDk=inDA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-01 11:12 ` Caesar Wang
[not found] ` <56AF3D80.90807-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-01 11:13 ` Caesar Wang
2016-02-01 23:31 ` John Youn
[not found] ` <2B3535C5ECE8B5419E3ECBE30077290901DC42FD26-Yu2iAY70zvrYN67daEjeMPufCSb+aD3WLzEdoUbNIic@public.gmane.org>
2016-02-02 2:42 ` Caesar Wang
[not found] ` <56B01785.3030803-9Onoh4P/yGk@public.gmane.org>
2016-02-02 2:53 ` Caesar Wang
2016-02-03 0:03 ` John Youn
[not found] ` <2B3535C5ECE8B5419E3ECBE30077290901DC431FDB-Yu2iAY70zvrYN67daEjeMPufCSb+aD3WLzEdoUbNIic@public.gmane.org>
2016-02-03 0:35 ` Caesar Wang
2016-02-03 1:08 ` John Youn
[not found] ` <2B3535C5ECE8B5419E3ECBE30077290901DC4322F0-Yu2iAY70zvrYN67daEjeMPufCSb+aD3WLzEdoUbNIic@public.gmane.org>
2016-02-03 1:10 ` Caesar Wang
2016-02-03 1:32 ` John Youn
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).