From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH] phy: rockchip-dp: fix return value check in rockchip_dp_phy_probe() Date: Fri, 17 Jun 2016 18:45:18 +0530 Message-ID: <5763F7E6.9090702@ti.com> References: <1465860707-26005-1-git-send-email-weiyj_lk@163.com> <4354296.6MbJoqdM2Z@diego> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4354296.6MbJoqdM2Z@diego> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: =?UTF-8?Q?Heiko_St=c3=bcbner?= , weiyj_lk-9Onoh4P/yGk@public.gmane.org Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Wei Yongjun , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rockchip.vger.kernel.org On Tuesday 14 June 2016 12:09 PM, Heiko St=FCbner wrote: > Am Montag, 13. Juni 2016, 23:31:47 schrieb weiyj_lk-9Onoh4P/yGk@public.gmane.org: >> From: Wei Yongjun >> >> In case of error, the function devm_kzalloc() returns NULL pointer >> not ERR_PTR(). The IS_ERR() test in the return value check should >> be replaced with NULL test. >> >> Signed-off-by: Wei Yongjun > = > obviously correct, thanks for catching. > = > Reviewed-by: Heiko Stuebner applied, thanks. -Kishon