From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH v4.1 1/2] drm/rockchip: analogix_dp: introduce the pclk for grf Date: Wed, 29 Jun 2016 11:35:15 +0800 Message-ID: <577341F3.5000803@rock-chips.com> References: <1466562678-11094-1-git-send-email-ykk@rock-chips.com> <1466647087-22207-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org To: Doug Anderson Cc: Mark Yao , Inki Dae , Jingoo Han , Heiko Stuebner , Javier Martinez Canillas , =?UTF-8?Q?St=c3=a9phane_Marchesin?= , Tomasz Figa , David Airlie , Daniel Vetter , Thierry Reding , Krzysztof Kozlowski , Emil Velikov , Dan Carpenter , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , linux-samsung-soc , "open list:ARM/Rockchip SoC..." List-Id: linux-rockchip.vger.kernel.org Doug, On 06/23/2016 01:16 PM, Doug Anderson wrote: > Yakir, > > On Wed, Jun 22, 2016 at 6:58 PM, Yakir Yang wrote: >> For RK3399's GRF module, if we want to operate the graphic related grf >> registers, we need to enable the pclk_vio_grf which supply power for VIO >> GRF IOs, so it's better to introduce an optional grf clock in driver. >> >> Signed-off-by: Yakir Yang >> --- >> Hi all, >> >> This is an external patch for analogix_dp misc cleanup thread [0] >> [0]: https://patchwork.kernel.org/patch/9175613/ >> >> BR, >> - Yakir >> >> Changes in v4.1: >> - Fix compiled error, sorry. >> "dp->cgfclk" --> 'dp->grfclk' >> >> Changes in v4: >> - Check the the error code properly, 'EPROBE_DEFER' should be returned, >> 'ENOENT' should assign a NULL point to grfclk, other errors should be >> regarded as failed. (Tomasz, Doug, reviewed at Google Gerrit) >> [https://chromium-review.googlesource.com/#/c/351821/20/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c@249] >> - Add the document about optional 'grf' clock (Tomasz, Doug, reviewed at Google Gerrit) >> [https://chromium-review.googlesource.com/#/c/351821/] >> >> Changes in v3: >> - Add this patch in v3 >> >> .../display/rockchip/analogix_dp-rockchip.txt | 6 ++++++ >> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 23 +++++++++++++++++++--- >> 2 files changed, 26 insertions(+), 3 deletions(-) > I probably would have split into two patches so the bindings was its > own patch, but I don't think it's strictly required. > > In any case, this seems good to me. > > Reviewed-by: Douglas Anderson > This is not big change, so collect them into one patch should be more cleaner, thanks for your reviewed ;) >