From: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Brian Norris
<briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Elaine Zhang <zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] arm64: dts: rockchip: Provide power-domains for sd/sdio/emmc controllers
Date: Wed, 03 Aug 2016 14:07:42 +0200 [thread overview]
Message-ID: <5792766.oYNWZEQPkG@diego> (raw)
In-Reply-To: <1470040874-17256-1-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Hi Shawn,
Am Montag, 1. August 2016, 16:41:14 schrieb Shawn Lin:
> The PM domain will be "powered on" once we have registered our PM domain
> with genpd and when the device (dw_mmc etc) gets attached to the domain.
> The attach occurs when the platform bus'->probe() function get invoked
> for the device.
>
> Due to this, we should be able to deploy genpd support by adding the
> phandle of related power-domains without first having to deploying
> runtime PM support in the related drivers.
>
> Let's do this in case of taking risk of accessing controller when the
> genpd is in "power off" status as the genpd will turn off all the
> power domains which are the referenced by drivers.
>
> Signed-off-by: Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
you're missing the subnodes below power: power-controller defining the power-
domains, - including the needed clocks. Thus currently you end up defering
probe of the emmc and friends indefinitly.
Ideally do it in this patch together with the assignment.
Thanks
Heiko
prev parent reply other threads:[~2016-08-03 12:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 8:41 [PATCH] arm64: dts: rockchip: Provide power-domains for sd/sdio/emmc controllers Shawn Lin
[not found] ` <1470040874-17256-1-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-08-03 12:07 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5792766.oYNWZEQPkG@diego \
--to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
--cc=briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox