Re: [PATCH v3 3/5] arm64: dts: rockchip: add the gmac power domain on rk3399

From: Caesar Wang <wxt@rock-chips.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Huang Tao <huangtao@rock-chips.com>,
	dbasehore@chromium.org, Elaine Zhang <zhangqing@rock-chips.com>,
	Xing Zheng <zhengxing@rock-chips.com>,
	linux-rockchip@lists.infradead.org, netdev@vger.kernel.org,
	Jianqun Xu <jay.xu@rock-chips.com>,
	Brian Norris <briannorris@chromium.org>,
	Will Deacon <will.deacon@arm.com>,
	Douglas Anderson <dianders@chromium.org>,
	linux-kernel@vger.kernel.org,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Roger Chen <roger.chen@rock-chips.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	David Wu <david.wu@rock-chips.com>,
	Shunqian Zheng <zhengsq@rock-chips.com>,
	linux-arm-kernel@lists.infradead.org,
	Caesar Wang <wxt@rock-chips.com>
Subject: Re: [PATCH v3 3/5] arm64: dts: rockchip: add the gmac power domain on rk3399
Date: Fri, 02 Sep 2016 01:53:37 +0800	[thread overview]
Message-ID: <57C86B21.4090409@rock-chips.com> (raw)
In-Reply-To: <2409903.3qiu7FpA8p@diego>

On 2016年09月01日 19:41, Heiko Stübner wrote:
> Hi Caesar,
>
> Am Donnerstag, 1. September 2016, 07:28:50 schrieb Caesar Wang:
>> This patch supports the gmac pd to save power consumption.
>> Even though some boards not need Ethernet support, the driver
>> core can also take care of powering up the pd before probe.
>>
>> Signed-off-by: Roger Chen <roger.chen@rock-chips.com>
>> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> who is the author of this patch? Roger or you? Because we should either drop
> Roger's Signed-off or fix the authorship to list him.

Thanks for reminding me.
Can you take a look at the newer v4 series patches? :)
https://patchwork.kernel.org/patch/9308013/

>
>
> Heiko
>
>> ---
>>
>> Changes in v3:
>> - leave into two patches based on patchv2, and fix nits and commit, as
>>    comment on https://patchwork.kernel.org/patch/9306339/
>>
>> Changes in v2:
>> - Fixes the order, ss Heiko commnets on
>>    https://patchwork.kernel.org/patch/9305991/
>>
>>   arch/arm64/boot/dts/rockchip/rk3399.dtsi | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index 32aebc8..2ab233f 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> @@ -611,6 +611,11 @@
>>   		status = "disabled";
>>   	};
>>
>> +	qos_gmac: qos@ffa5c000 {
>> +		compatible = "syscon";
>> +		reg = <0x0 0xffa5c000 0x0 0x20>;
>> +	};
>> +
>>   	qos_hdcp: qos@ffa90000 {
>>   		compatible = "syscon";
>>   		reg = <0x0 0xffa90000 0x0 0x20>;
>> @@ -739,6 +744,11 @@
>>   			};
>>
>>   			/* These power domains are grouped by VD_LOGIC */
>> +			pd_gmac@RK3399_PD_GMAC {
>> +				reg = <RK3399_PD_GMAC>;
>> +				clocks = <&cru ACLK_GMAC>;
>> +				pm_qos = <&qos_gmac>;
>> +			};
>>   			pd_vio@RK3399_PD_VIO {
>>   				reg = <RK3399_PD_VIO>;
>>   				#address-cells = <1>;
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

-- 
caesar wang | software engineer | wxt@rock-chip.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel