From: Dragan Simic <dsimic@manjaro.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pmdomain: rockchip: add regulator dependency
Date: Tue, 04 Mar 2025 21:23:21 +0100 [thread overview]
Message-ID: <57dc1e1b8a3f1134c5eed050a81de1b7@manjaro.org> (raw)
In-Reply-To: <20250304142803.689201-1-arnd@kernel.org>
Hello Arnd,
On 2025-03-04 15:27, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When CONFIG_REGULATOR is disabled, this pmdomain driver fails to build:
>
> drivers/pmdomain/rockchip/pm-domains.c:653:30: error: implicit
> declaration of function 'devm_of_regulator_get'; did you mean
> 'devm_regulator_get'? [-Wimplicit-function-declaration]
> 653 | pd->supply = devm_of_regulator_get(pmu->dev,
> pd->node, "domain");
> | ^~~~~~~~~~~~~~~~~~~~~
> | devm_regulator_get
> drivers/pmdomain/rockchip/pm-domains.c:653:28: error: assignment to
> 'struct regulator *' from 'int' makes pointer from integer without a
> cast [-Wint-conversion]
> 653 | pd->supply = devm_of_regulator_get(pmu->dev,
> pd->node, "domain");
> | ^
>
> Add a Kconfig dependency.
>
> Fixes: db6df2e3fc16 ("pmdomain: rockchip: add regulator support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/pmdomain/rockchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pmdomain/rockchip/Kconfig
> b/drivers/pmdomain/rockchip/Kconfig
> index 7e4f9b628f0b..218d43186e5b 100644
> --- a/drivers/pmdomain/rockchip/Kconfig
> +++ b/drivers/pmdomain/rockchip/Kconfig
> @@ -5,6 +5,7 @@ config ROCKCHIP_PM_DOMAINS
> bool "Rockchip generic power domain"
> depends on PM
> depends on HAVE_ARM_SMCCC_DISCOVERY
> + depends on REGULATOR
> select PM_GENERIC_DOMAINS
> help
> Say y here to enable power domain support.
Looking good to me, thanks for this patch.
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-03-04 20:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 14:27 [PATCH] pmdomain: rockchip: add regulator dependency Arnd Bergmann
2025-03-04 14:31 ` Sebastian Reichel
2025-03-04 20:23 ` Dragan Simic [this message]
2025-03-04 20:44 ` Heiko Stübner
2025-03-05 14:53 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57dc1e1b8a3f1134c5eed050a81de1b7@manjaro.org \
--to=dsimic@manjaro.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=sebastian.reichel@collabora.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox