From: jeffy <jeffy.chen@rock-chips.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Brian Norris <briannorris@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Tomasz Figa <tfiga@chromium.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Chris Zhong <zyw@rock-chips.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 7/9] drm/rockchip: Force disable all crtc when unload
Date: Wed, 05 Apr 2017 18:25:06 +0800 [thread overview]
Message-ID: <58E4C602.4090302@rock-chips.com> (raw)
In-Reply-To: <CAKMK7uFzpk0VNr-hdeKKxB0Ur+qC7ZWe-EwyzqcudABdjQZXfQ@mail.gmail.com>
Hi Daniel,
On 04/03/2017 03:58 PM, Daniel Vetter wrote:
> On Sat, Apr 1, 2017 at 1:35 PM, Jeffy Chen <jeffy.chen@rock-chips.com> wrote:
>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
>> index a5d83cb..5dbf011 100644
>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
>> @@ -246,6 +246,7 @@ static void rockchip_drm_unbind(struct device *dev)
>> rockchip_drm_fbdev_fini(drm_dev);
>> drm_kms_helper_poll_fini(drm_dev);
>>
>> + drm_crtc_force_disable_all(drm_dev);
>
> This will result in a WARN_ON in latest drm-next because rockchip is
> atomic, and this helper is for legacy kms drivers. You want to use
> drm_atomic_helper_shutdown here.
> -Daniel
>
oops, thanx for the notice.
next prev parent reply other threads:[~2017-04-05 10:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 11:35 [PATCH v2 0/9] drm: rockchip: Fix rockchip drm unbind crash error Jeffy Chen
2017-04-01 11:35 ` [PATCH v2 4/9] drm/rockchip: cdn-dp: Don't try to release firmware when not loaded Jeffy Chen
2017-04-01 11:35 ` [PATCH v2 5/9] drm/rockchip: vop: Enable pm domain when resetting vop Jeffy Chen
2017-04-04 19:42 ` Sean Paul
2017-04-05 10:23 ` jeffy
2017-04-01 11:35 ` [PATCH v2 6/9] drm/rockchip: Reoder unload sequence Jeffy Chen
2017-04-04 19:44 ` Sean Paul
2017-04-05 10:20 ` jeffy
2017-04-01 11:35 ` [PATCH v2 7/9] drm/rockchip: Force disable all crtc when unload Jeffy Chen
2017-04-03 7:58 ` Daniel Vetter
2017-04-05 10:25 ` jeffy [this message]
2017-04-01 11:35 ` [PATCH v2 8/9] drm/rockchip: gem: Don't alloc/free gem buf before drm dev registered Jeffy Chen
2017-04-03 7:41 ` Daniel Vetter
2017-04-05 1:28 ` jeffy
2017-04-01 11:35 ` [PATCH v2 9/9] drm/rockchip: cdn-dp: Don't unregister audio dev when unbinding Jeffy Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58E4C602.4090302@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=briannorris@chromium.org \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=tfiga@chromium.org \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).