From: jeffy <jeffy.chen@rock-chips.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, dmitry.torokhov@gmail.com,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>,
briannorris@chromium.org, Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
dianders@chromium.org, linux-samsung-soc@vger.kernel.org,
Kukjin Kim <kgene@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-tegra@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v3 3/6] ARM/arm64: dts: enable wakeup for cros-ec-spi devices
Date: Wed, 21 Jun 2017 23:33:29 +0800 [thread overview]
Message-ID: <594A91C9.1090906@rock-chips.com> (raw)
In-Reply-To: <CAJKOXPdL2CB9VWNo=it0dos-4hJYrgHUSZwcG1DS=9c+YxXzhQ@mail.gmail.com>
Hi Krzysztof,
thanx for your comment.
On 06/21/2017 06:45 PM, Krzysztof Kozlowski wrote:
> On Wed, Jun 21, 2017 at 12:01 PM, Jeffy Chen <jeffy.chen@rock-chips.com> wrote:
>> We used to enable wakeup for cros-ec-spi devices unconditionally.
>> Now we are using the more generic wakeup-source property to enable it.
>
> Using wakeup-source property is still enabling this unconditionally.
> What do you exactly mean here?
i mean the wakeup-source is an optional property, we can disable wakeup
by not adding it.
but now i enable it to all exist cros-ec-spi devices for not breaking
current stuffs :)
>
>>
>> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>> ---
>>
>> Changes in v3: None
>>
>> arch/arm/boot/dts/exynos5420-peach-pit.dts | 1 +
>> arch/arm/boot/dts/exynos5800-peach-pi.dts | 1 +
>> arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 1 +
>> arch/arm/boot/dts/tegra124-nyan.dtsi | 1 +
>> arch/arm/boot/dts/tegra124-venice2.dts | 1 +
>> arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 1 +
>> arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 1 +
>> 7 files changed, 7 insertions(+)
>
> Please split it per arch (arm and arm64) and per machine. I'll take
> exynos after splitting.
ok, sounds good, will do it in next version, thanx~
>
> Best regards,
> Krzysztof
>
>
>
next prev parent reply other threads:[~2017-06-21 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 10:01 [RFC PATCH v3 0/6] Report wakeup events in cros_ec_keyb and make cros-ec-spi wakeup optional Jeffy Chen
[not found] ` <1498039313-24220-1-git-send-email-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-06-21 10:01 ` [RFC PATCH v3 3/6] ARM/arm64: dts: enable wakeup for cros-ec-spi devices Jeffy Chen
[not found] ` <1498039313-24220-4-git-send-email-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-06-21 10:45 ` Krzysztof Kozlowski
2017-06-21 15:33 ` jeffy [this message]
2017-06-21 15:36 ` Krzysztof Kozlowski
2017-06-22 2:33 ` jeffy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=594A91C9.1090906@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=briannorris@chromium.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=heiko@sntech.de \
--cc=jonathanh@nvidia.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox