From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F354C2A072 for ; Mon, 5 Jan 2026 07:55:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T5VyJf9JUMGcIozn9ow/EjF+SASNtQlQhPSkx8KCA9Q=; b=uMNU0xyMd/fshJ vziGZ1R5jrXp1rr4Lc4CWsClHRRC265Og4jPorVGhhVoU8maf/XLD1s9Z853EEH2uDKtxqG300e54 uOIRcx+hltTjDmvoz00q2QkPrdu2seqKCw8AySqeWgqrK9hnldjslNJ9N36a/lXjm5h030BztSt06 4pe1JVauae8tO9hKhlim8XTAHa+o2rVM0ilCfwHGTZv57Cq9xpnfTq5WpwluCT3C4T4ahmpGg4hen JwVYB4uK0CgvNksRuRJ5GOu7UfVOU9uxuZT/E3mzoTh8p0IJgPhOBkqu4gGu6wlKzFEDVAOlUmvPl 8iarpOwnEvqcfzf+zIrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vcfRB-0000000AwCz-3qEx; Mon, 05 Jan 2026 07:55:37 +0000 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vcfR8-0000000AwC4-2eyJ; Mon, 05 Jan 2026 07:55:35 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1767599726; cv=none; d=zohomail.com; s=zohoarc; b=ApyVmbqvyvvb8na3d/melHLpY2DTPtJeJzJ9aWMiXiAmqnz89jYsWoPJ0vVj5aTgXvgnWPOwPPfqDU/LNUOkE6MQEZu2okpX1MjtLqGfcVTyg1Py7MQgJSE8Gk4P07RiQyKrTCte+OCs4BgDYf3sey5i+mVfz6hngJY8gmK3UYk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767599726; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=aWPAionUGYVqkBpz5QQVAcYUIfxJMKwBFtRZhqGCqzM=; b=RuiFb+t17z7NWutMYXVwxR3XZl8vkhaNc+HPwldTvIxBW6iyroeFZlOxk4gQPyZXwMi0q/fFm32VS+2LnzuALx0/ZKwHfOe9HNXwL90TgwrZWwMkyhSkYRdbeL6qDnv6SPMU1W/6wcWNx61Y9DdZXz68YT2tF0eO1hrTkhFQfAc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1767599726; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=aWPAionUGYVqkBpz5QQVAcYUIfxJMKwBFtRZhqGCqzM=; b=dejfNqMo6xmOUjexvSDcHRAdx7eGKVoKzOgsSAouO/QpFOaFtb/2l++R+0lz/IIE GA1s1tqndtY+CqwFmV4yoqxwS+YAzplmyPeZ88imwA/+zgkAwGVoPqWSMcSAHKcC4t9 g3QSRCI3m5/DeUkzc8rpw6Q/Z4h7E5iLJDvEHf7w= Received: by mx.zohomail.com with SMTPS id 1767599722778915.547246258709; Sun, 4 Jan 2026 23:55:22 -0800 (PST) From: Nicolas Frattaroli To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Chaoyi Chen , Kever Yang , Sebastian Reichel , Cristian Ciocaltea , Frank Wang , Alexey Charkov , Liang Chen , Finley Xiao , Elaine Zhang , Yifeng Zhao , Chaoyi Chen Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: rockchip: Fix wrong register range of rk3576 gpu Date: Mon, 05 Jan 2026 08:55:17 +0100 Message-ID: <5954009.DvuYhMxLoT@workhorse> In-Reply-To: <20251230090246.46-1-kernel@airkyi.com> References: <20251230090246.46-1-kernel@airkyi.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260104_235534_739917_7C5A8B15 X-CRM114-Status: GOOD ( 17.11 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Tuesday, 30 December 2025 10:02:46 Central European Standard Time Chaoyi Chen wrote: > From: Chaoyi Chen > > According to RK3576 TRM part1 page13, the size of the GPU registers > is 128 KB. > > Fixes: 57b1ce903966 ("arm64: dts: rockchip: Add rk3576 SoC base DT") > Signed-off-by: Chaoyi Chen > --- > arch/arm64/boot/dts/rockchip/rk3576.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi > index 6284e7bdc442..b375015f0662 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi > @@ -1271,7 +1271,7 @@ power-domain@RK3576_PD_VO1 { > > gpu: gpu@27800000 { > compatible = "rockchip,rk3576-mali", "arm,mali-bifrost"; > - reg = <0x0 0x27800000 0x0 0x200000>; > + reg = <0x0 0x27800000 0x0 0x20000>; > assigned-clocks = <&scmi_clk SCMI_CLK_GPU>; > assigned-clock-rates = <198000000>; > clocks = <&cru CLK_GPU>; > This is only true if you only consider the GPU_CONTROL and JOB_CONTROL register ranges, and leave out the MMU_STAGE1 and MMU_STAGE2 ranges. I don't know if those need to be mapped, since the MMU control registers are < 0x2000. What do other bifrost devices do? Kind regards, Nicolas Frattaroli _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip